From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Kaushal Modi Newsgroups: gmane.emacs.devel Subject: Re: bug#27644: 26.0.50; [PATCH] Add binding for vc-region-history Date: Thu, 21 Sep 2017 20:39:50 +0000 Message-ID: References: <83h8vxfobt.fsf@gnu.org> <6ab17adb-c05e-628d-6b53-666c8bf26a75@yandex.ru> <83o9q4dshj.fsf@gnu.org> <75512192-de23-07dd-2492-ec8ec0888161@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a114fbf50a23bab0559b918a0" X-Trace: blaine.gmane.org 1506026455 3683 195.159.176.226 (21 Sep 2017 20:40:55 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 21 Sep 2017 20:40:55 +0000 (UTC) To: Dmitry Gutov , Eli Zaretskii , Emacs developers Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 21 22:40:51 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dv8HA-0000ZO-Te for ged-emacs-devel@m.gmane.org; Thu, 21 Sep 2017 22:40:49 +0200 Original-Received: from localhost ([::1]:55452 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dv8HI-00014W-8C for ged-emacs-devel@m.gmane.org; Thu, 21 Sep 2017 16:40:56 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50510) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dv8H8-000148-BZ for emacs-devel@gnu.org; Thu, 21 Sep 2017 16:40:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dv8Gv-0003ge-6X for emacs-devel@gnu.org; Thu, 21 Sep 2017 16:40:46 -0400 Original-Received: from mail-yw0-x22c.google.com ([2607:f8b0:4002:c05::22c]:48287) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dv8GP-00036c-If; Thu, 21 Sep 2017 16:40:01 -0400 Original-Received: by mail-yw0-x22c.google.com with SMTP id u205so4909874ywa.5; Thu, 21 Sep 2017 13:40:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=O1mgEoNfDslbQ60kWSmV/gSw5YGlOyDChi58Nl5Kp0E=; b=ExYCt7n34/5IkhdiydYLdeb9pPMC7lzbN4KOtv6wrH/m2ZYGz4psDDlXYjL9HZkMGs Rn2KUUPDozwmXi5WavvFsZD/HyCHUEcdOylZDuon+966wtF6+gFcWf9W6ajQva6r94/i luYieutgZF05GTPhbsKmR+6J/kRgWmt7BaKX+a482FqlSI13GOrKrJoeCGNYEAJAskhA WBKlp3W7qHVu+sG0Ahv9nxr5k8aTV5NPGgU4wKbSPoNOn1Rsn0XZnayvI4uj6DQFHC4E jKMa4hkTCpol7GH7njVbeVJxSQUzlr/9xzaWy3ssJelpSL+8FHjpAWHINwAHbdsPQuc6 KHzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=O1mgEoNfDslbQ60kWSmV/gSw5YGlOyDChi58Nl5Kp0E=; b=eS9rZzcI0EZK7NGtglxdL6egag0ZXXKkhoJP5GiVo6MPuu4P/Zd+PcoQrCPx3MbNm5 p4IUjncLp7Y6Sp3i40Arkr6x+XSDuT2Ktb1Mjir92IceDv4OnC5RLxmPFOAY+EFpSry5 y61+Z1mrBG3UawHOmzW14yxI94NU/tG1n9R3SBOxPtqnZbn4XyEZr3XkMb0NKIj1JZIy Kz9fXlSKJZIsdaIgERqim8f7aFw8NF85WUnVIIH226YOz/i0zymMirp/kLpGkw3/SovY 1U7tdQV9SMnHdL/UKCzv+gD0Uj0DWZ5U2q7CU/XZgGqVbey314dUP4ZtjqRjDEWI4tqe rwxg== X-Gm-Message-State: AHPjjUgx52bqwzvQbhtOPiLs9GOGLZLKVCMzzjX3ieDfBw1zu6SjUGKw vIYRMXreodiOuBQTdnVroDez4t8DnNQI8b7This= X-Google-Smtp-Source: AOwi7QBdkHXBRZgCJ+APc/Ct7WrKA2q7VjgzbjPv/0bN9huWEsBZVTTf8C28c3k9OrqaNxVv+zSfWMHf8mDE9b0QBIA= X-Received: by 10.13.226.69 with SMTP id l66mr2431074ywe.196.1506026400658; Thu, 21 Sep 2017 13:40:00 -0700 (PDT) In-Reply-To: <75512192-de23-07dd-2492-ec8ec0888161@yandex.ru> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4002:c05::22c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:218659 Archived-At: --001a114fbf50a23bab0559b918a0 Content-Type: text/plain; charset="UTF-8" Hello all, In https://debbugs.gnu.org/cgi/bugreport.cgi?bug=27644, I propose a patch to bind the vc-region-history command to C-x v H. * Why vc-region-history? - I find that command very useful; especially to dig though who specifically touched a set of lines in emacs code and when. I used it very recently[1] to associate a strange behavior I started seeing in ggtags.el package with an upstream change in emacs. * Why bind to C-x v H - That binding is an easy mnemonic; the "H" in C-x v H for vc-region-(H)istory. - That binding is available So the questions to the list: - How frequently do you guys use vc-region-history? - If you bind it, what do you bind it to? - Is there a reason why this patch should not be applied? Thanks all. Kaushal [1]: https://github.com/leoliu/ggtags/issues/157#issuecomment-330270080 On Thu, Sep 21, 2017 at 11:29 AM Dmitry Gutov wrote: > On 9/21/17 5:41 PM, Eli Zaretskii wrote: > > >> I don't have a strong opinion. > > > > About binding this to a key in general, or about the particular key > > proposed by Kaushal? > > Either. It's not a very technical decision, and I very rarely use this > command myself. > > > If the former, perhaps we should ask how many > > others bind this to a key, or how frequently they use this command. > > Sounds good to me. > -- Kaushal Modi --001a114fbf50a23bab0559b918a0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello all,

In=C2=A0https://debbugs.gnu.org/cgi/b= ugreport.cgi?bug=3D27644, I propose a patch to bind the vc-region-histo= ry command to C-x v H.

* Why vc-region-history?
- I find that command very useful; especially to dig though who spe= cifically touched a set of lines in emacs code and when. I used it very rec= ently[1] to associate a strange behavior I started seeing in ggtags.el pack= age with an upstream change in emacs.

* Why bind t= o C-x v H
- That binding is an easy mnemonic; the "H" i= n C-x v H for vc-region-(H)istory.
- That binding is available

So the questions to the list:
- How freque= ntly do you guys use vc-region-history?
- If you bind it, what do= you bind it to?
- Is there a reason why this patch should not be= applied?

Thanks all.



=C2=A0
On Thu, Sep 21, 2017 at 11:29 AM Dmitry Gutov <dgutov@yandex.ru> wrote:
=
On 9/21/17 5:41 PM, Eli Zaretskii wrote:

>> I don't have a strong opinion.
>
> About binding this to a key in general, or about the particular key > proposed by Kaushal?

Either. It's not a very technical decision, and I very rarely use this<= br> command myself.

> If the former, perhaps we should ask how many
> others bind this to a key, or how frequently they use this command.
Sounds good to me.

--

Kaushal Modi

--001a114fbf50a23bab0559b918a0--