From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kaushal Modi Newsgroups: gmane.emacs.bugs Subject: bug#23897: 25.1.50; Argument at point not being highlighted in eldoc hints Date: Thu, 07 Jul 2016 20:31:29 +0000 Message-ID: References: <577E80BF.7030304@gmx.at> <83h9c1jkrl.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a113ceb94c4fe530537119213 X-Trace: ger.gmane.org 1467923546 16406 80.91.229.3 (7 Jul 2016 20:32:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 7 Jul 2016 20:32:26 +0000 (UTC) Cc: 23897@debbugs.gnu.org, dgutov@yandex.ru To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 07 22:32:16 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bLFy3-0003SM-NT for geb-bug-gnu-emacs@m.gmane.org; Thu, 07 Jul 2016 22:32:15 +0200 Original-Received: from localhost ([::1]:42207 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLFy2-0001MY-Jd for geb-bug-gnu-emacs@m.gmane.org; Thu, 07 Jul 2016 16:32:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57730) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLFxv-0001MR-2b for bug-gnu-emacs@gnu.org; Thu, 07 Jul 2016 16:32:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bLFxq-0002KF-Ru for bug-gnu-emacs@gnu.org; Thu, 07 Jul 2016 16:32:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57473) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLFxq-0002K7-Ot for bug-gnu-emacs@gnu.org; Thu, 07 Jul 2016 16:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bLFxq-00033b-B8 for bug-gnu-emacs@gnu.org; Thu, 07 Jul 2016 16:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Kaushal Modi Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Jul 2016 20:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23897 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23897-submit@debbugs.gnu.org id=B23897.146792350711728 (code B ref 23897); Thu, 07 Jul 2016 20:32:02 +0000 Original-Received: (at 23897) by debbugs.gnu.org; 7 Jul 2016 20:31:47 +0000 Original-Received: from localhost ([127.0.0.1]:41577 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bLFxa-000336-Nw for submit@debbugs.gnu.org; Thu, 07 Jul 2016 16:31:47 -0400 Original-Received: from mail-oi0-f48.google.com ([209.85.218.48]:34993) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bLFxZ-00032t-H7 for 23897@debbugs.gnu.org; Thu, 07 Jul 2016 16:31:45 -0400 Original-Received: by mail-oi0-f48.google.com with SMTP id r2so39227837oih.2 for <23897@debbugs.gnu.org>; Thu, 07 Jul 2016 13:31:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=N502MyUJKdODVFIDQ/D4FT4ChVMFrV7DYht8+Wfjakc=; b=0Y5q7jNxA9TcOFwNyDk+BJ0hI9axPKQFqqeuqBUTXjzHgxA78MT1IlEXJNw0jdizEr nRRQdifNltRpHabW6enME95H55mC2k9PLo8AcQsgd1EjSpNTdosaTsNH+eDjHUcTbCmE dVjo3KupDA2SSUOCUh0e5IFDAYooeBMiPoURE1wKDSJ1NQK/6J8f7WzoyJOP+ukF15KD wFG6NrMqUYMD1QCWnsJsYUlAAQdn1++G55ZYsJDY3KAYdEDxxBfJM8arVHaQBqOUhYNf DTvK3JpP9DgyAg4jX1HmtpRNOTslUdeIPERQJkqgvyr8clHnedO/MW2AQElCbqUvZ27E 8a2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=N502MyUJKdODVFIDQ/D4FT4ChVMFrV7DYht8+Wfjakc=; b=fzjzvAcF6emLVBwRwGQdZWYCvN07n0DYnKlucQX/hVmTxMNZXYb3ehQ4J3CptJXFe3 DWO/Y8xmKmE+VHLOXiK6fidsA4hANdFPgp6RgKwhkqqMqSR+Bog08dWDGLI1j2mqslbR fH44ZTpTQuQ6o/n//qgaRpwGF+U1Sb9dR3MXG7Mg0O/OWbf2pPzfmxPKAqByuxuxro0U bxpEkLFTvPWq7Ksadm/TOSz+ogXuJMVRflga97Hv8Kgpmn2B/U265Chl2BWwYCL8FYY0 lBssF9bBvJR28491JvvFrjCpQm9xXflZ7LS0hqydFokipCiwy6trCvhGEyEcWjDao9nu Iuug== X-Gm-Message-State: ALyK8tLmevhbFScDJupusR0xkIiCk1xrOm47YIf54V+91fNvvjPyEaks2PPchh/cqyjLVpVLxS+eWCszWh/biQ== X-Received: by 10.202.172.146 with SMTP id v140mr1292685oie.98.1467923499906; Thu, 07 Jul 2016 13:31:39 -0700 (PDT) In-Reply-To: <83h9c1jkrl.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:120604 Archived-At: --001a113ceb94c4fe530537119213 Content-Type: text/plain; charset=UTF-8 Looks like the fixes will be needed in major modes? For instance, by adding the following debug statement in elisp--highlight-function-argument function in elisp-mode.el, ===== diff --git a/lisp/progmodes/elisp-mode.el b/lisp/progmodes/elisp-mode.el index f360791..16365dd 100644 --- a/lisp/progmodes/elisp-mode.el +++ b/lisp/progmodes/elisp-mode.el @@ -1481,6 +1481,7 @@ elisp--highlight-function-argument (setq doc (copy-sequence args)) (add-text-properties start end (list 'face argument-face) doc)) (setq doc (eldoc-docstring-format-sym-doc prefix doc)) + (message "debug: doc = %S" doc) doc))) ;; Return a string containing a brief (one-line) documentation string for ===== I get the below when the cursor is after a defun: debug: doc = #("defun: (NAME ARGLIST &optional DOCSTRING DECL &rest BODY)" 0 5 (face font-lock-keyword-face)) I get the same debug output in both emacs-25 and master builds. So I am wondering if this doc output needs to be adjusted to the change in the format function then .. Also, I can see if debug of incorrect face display in both mode-line (when I am using the minibuffer to eval stuff using M-: binding) and echo area. On Thu, Jul 7, 2016 at 3:45 PM Eli Zaretskii wrote: > > From: Kaushal Modi > > Date: Thu, 07 Jul 2016 19:31:26 +0000 > > Cc: martin rudalics , Dmitry Gutov > > > > [0644e6f56d2be82dd716478eb65e7b3c761d813d] Fix copying properties in > 'format' when it produces padding > > > > Building emacs using that commit shows that bug. > > Then the fix will have to be in the code which calls format, because > the above commit is going to stay. > > If no one beats me to it, I will look into this in a day or two. > > Thanks for the analysis. > -- -- Kaushal Modi --001a113ceb94c4fe530537119213 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Looks like the fixes will be needed in major modes?
For instance, by adding the following debug statement in elisp= --highlight-function-argument function in elisp-mode.el,

=3D=3D=3D=3D=3D
diff --git a/lisp/progmodes/elisp-mod= e.el b/lisp/progmodes/elisp-mode.el
index f360791..16365dd 100644=
--- a/lisp/progmodes/elisp-mode.el
+++ b/lisp/progmode= s/elisp-mode.el
@@ -1481,6 +1481,7 @@ elisp--highlight-function-a= rgument
=C2=A0 (setq doc (copy-sequence args))
=C2=A0 (add-text-properties = start end (list 'face argument-face) doc))
=C2=A0 =C2=A0 =C2= =A0 =C2=A0(setq doc (eldoc-docstring-format-sym-doc prefix doc))
= + =C2=A0 =C2=A0 =C2=A0(message "debug: doc =3D %S" doc)
=C2=A0 =C2=A0 =C2=A0 =C2=A0doc)))
=C2=A0
=C2=A0;; Retu= rn a string containing a brief (one-line) documentation string for
=3D=3D=3D=3D=3D

I get the below when the c= ursor is after a defun:

debug: doc =3D #(&quo= t;defun: (NAME ARGLIST &optional DOCSTRING DECL &rest BODY)" 0= 5 (face font-lock-keyword-face))

I get the = same debug output in both emacs-25 and master builds. So I am wondering if = this doc output needs to be adjusted to the change in the format function t= hen ..

Also, I can see if debug of incorrect face = display in both mode-line (when I am using the minibuffer to eval stuff usi= ng M-: binding) and echo area.

On Thu, Jul 7, 2016 at 3:45 PM Eli Zaretskii <eliz@gnu.org> wrote:
> From: Kaushal Modi <kaushal.modi@gmail.com>
> Date: Thu, 07 Jul 2016 19:31:26 +0000
> Cc: martin rudalics <rudalics@gmx.at>, Dmitry Gutov <dgutov@yandex.ru>
>
> [0644e6f56d2be82dd716478eb65e7b3c761d813d] Fix copying properties in &= #39;format' when it produces padding
>
> Building emacs using that commit shows that bug.

Then the fix will have to be in the code which calls format, because
the above commit is going to stay.

If no one beats me to it, I will look into this in a day or two.

Thanks for the analysis.
--

--
Kaushal Modi

--001a113ceb94c4fe530537119213--