From: Kaushal Modi <kaushal.modi@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 23897@debbugs.gnu.org, dgutov@yandex.ru
Subject: bug#23897: 25.1.50; Argument at point not being highlighted in eldoc hints
Date: Thu, 07 Jul 2016 20:31:29 +0000 [thread overview]
Message-ID: <CAFyQvY2NZZZ95rywGun=24QZYKo+LBGm-JmBgPDXyzf_UuFPeQ@mail.gmail.com> (raw)
In-Reply-To: <83h9c1jkrl.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1822 bytes --]
Looks like the fixes will be needed in major modes?
For instance, by adding the following debug statement in
elisp--highlight-function-argument function in elisp-mode.el,
=====
diff --git a/lisp/progmodes/elisp-mode.el b/lisp/progmodes/elisp-mode.el
index f360791..16365dd 100644
--- a/lisp/progmodes/elisp-mode.el
+++ b/lisp/progmodes/elisp-mode.el
@@ -1481,6 +1481,7 @@ elisp--highlight-function-argument
(setq doc (copy-sequence args))
(add-text-properties start end (list 'face argument-face) doc))
(setq doc (eldoc-docstring-format-sym-doc prefix doc))
+ (message "debug: doc = %S" doc)
doc)))
;; Return a string containing a brief (one-line) documentation string for
=====
I get the below when the cursor is after a defun:
debug: doc = #("defun: (NAME ARGLIST &optional DOCSTRING DECL &rest BODY)"
0 5 (face font-lock-keyword-face))
I get the same debug output in both emacs-25 and master builds. So I am
wondering if this doc output needs to be adjusted to the change in the
format function then ..
Also, I can see if debug of incorrect face display in both mode-line (when
I am using the minibuffer to eval stuff using M-: binding) and echo area.
On Thu, Jul 7, 2016 at 3:45 PM Eli Zaretskii <eliz@gnu.org> wrote:
> > From: Kaushal Modi <kaushal.modi@gmail.com>
> > Date: Thu, 07 Jul 2016 19:31:26 +0000
> > Cc: martin rudalics <rudalics@gmx.at>, Dmitry Gutov <dgutov@yandex.ru>
> >
> > [0644e6f56d2be82dd716478eb65e7b3c761d813d] Fix copying properties in
> 'format' when it produces padding
> >
> > Building emacs using that commit shows that bug.
>
> Then the fix will have to be in the code which calls format, because
> the above commit is going to stay.
>
> If no one beats me to it, I will look into this in a day or two.
>
> Thanks for the analysis.
>
--
--
Kaushal Modi
[-- Attachment #2: Type: text/html, Size: 2865 bytes --]
next prev parent reply other threads:[~2016-07-07 20:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 15:25 bug#23897: 25.1.50; Argument at point not being highlighted in eldoc hints Kaushal Modi
2016-07-07 16:18 ` martin rudalics
2016-07-07 16:28 ` Clément Pit--Claudel
2016-07-07 16:57 ` Kaushal Modi
2016-07-07 17:06 ` Dmitry Gutov
2016-07-07 19:31 ` Kaushal Modi
2016-07-07 19:38 ` Kaushal Modi
2016-07-07 19:44 ` Eli Zaretskii
2016-07-07 20:31 ` Kaushal Modi [this message]
2016-07-07 22:19 ` Kaushal Modi
2016-07-08 9:25 ` Eli Zaretskii
2016-07-08 19:39 ` Eli Zaretskii
2016-07-08 19:42 ` Kaushal Modi
2016-07-08 19:49 ` Eli Zaretskii
2016-07-08 20:01 ` Kaushal Modi
2016-07-09 6:40 ` Clément Pit--Claudel
2016-07-07 19:36 ` Clément Pit--Claudel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFyQvY2NZZZ95rywGun=24QZYKo+LBGm-JmBgPDXyzf_UuFPeQ@mail.gmail.com' \
--to=kaushal.modi@gmail.com \
--cc=23897@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.