From: Kaushal Modi <kaushal.modi@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Cc: Eric Abrahamsen <eric@ericabrahamsen.net>
Subject: Re: [Emacs-diffs] emacs-26 ee512e9: Ignore buffers whose name begins with a space in save-some-buffers
Date: Tue, 19 Sep 2017 10:48:38 +0000 [thread overview]
Message-ID: <CAFyQvY2NFF58EkqhSOBS277CjPUiY8DS2woG4biv=EEYVmDfCg@mail.gmail.com> (raw)
In-Reply-To: <jwv4lrz76my.fsf-monnier+emacsdiffs@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1342 bytes --]
On Mon, Sep 18, 2017, 10:44 PM Stefan Monnier <monnier@iro.umontreal.ca>
wrote:
> > Ignore buffers whose name begins with a space in save-some-buffers
> > * lisp/files.el (save-some-buffers): Consider these buffers
> > "internal", and don't prompt the user to save them.
> > * doc/lispref/files.texi: Document.
>
> Why? Currently we only prompt for buffers with a leading space
> in 2 case:
> - the buffer is associated with a file: rather unlikely, but if it
> occurs, it's probably a good idea not to ignore this buffer.
> - the buffer has buffer-offer-save set to a non-nil value: here again if
> someone bothered to set this, it's a good idea not to ignore this buffer.
The previous commit that started promoting for file save if
write-file-functions was non-nil starting breaking my use case (ggtags.el +
verilog-mode).
Details here: https://github.com/leoliu/ggtags/issues/157
Summary:
- ggtags.el create an internal buffer with name starting with space "
*Code-Fontify*"
- verilog-mode is enabled in that buffer
- verilog-mode sets write-file-functions to a non-nil value
- So now I was promoted to save that " *Code-Fontify*" each time I quit
emacs.
ANDing the internal buffer check with OR of the 2 cases you mentioned will
work fine (won't undo the fix that Eric made in this commit).
--
Kaushal Modi
[-- Attachment #2: Type: text/html, Size: 1977 bytes --]
next prev parent reply other threads:[~2017-09-19 10:48 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170918202953.21378.63492@vcs0.savannah.gnu.org>
[not found] ` <20170918202955.5043420AC4@vcs0.savannah.gnu.org>
2017-09-19 2:44 ` [Emacs-diffs] emacs-26 ee512e9: Ignore buffers whose name begins with a space in save-some-buffers Stefan Monnier
2017-09-19 3:12 ` Eric Abrahamsen
2017-09-19 12:42 ` Stefan Monnier
2017-09-19 13:25 ` Kaushal Modi
2017-09-19 15:44 ` Eric Abrahamsen
2017-09-19 15:50 ` Kaushal Modi
2017-09-19 15:53 ` Stefan Monnier
2017-09-19 16:03 ` Eric Abrahamsen
2017-09-19 15:37 ` Leo Liu
2017-09-19 15:56 ` Stefan Monnier
2017-09-19 10:48 ` Kaushal Modi [this message]
2017-09-19 12:08 ` Stefan Monnier
2017-09-19 12:26 ` Kaushal Modi
2017-09-19 18:13 ` Eric Abrahamsen
2017-09-20 2:10 ` Kaushal Modi
2017-09-20 7:16 ` Andreas Schwab
2017-09-20 17:14 ` Eric Abrahamsen
2017-09-21 8:01 ` Eli Zaretskii
2017-09-21 19:57 ` Eric Abrahamsen
2017-09-21 20:10 ` Kaushal Modi
2017-09-21 22:53 ` Eric Abrahamsen
2017-09-22 6:54 ` Eli Zaretskii
2017-09-22 15:52 ` Eric Abrahamsen
2017-09-22 16:18 ` Stefan Monnier
2017-09-22 16:54 ` Eric Abrahamsen
2017-09-22 19:03 ` Stefan Monnier
2017-09-22 23:27 ` Eric Abrahamsen
2017-09-23 2:43 ` Stefan Monnier
2017-09-24 19:25 ` Eric Abrahamsen
2017-09-24 19:29 ` Stefan Monnier
2017-09-24 20:59 ` Eric Abrahamsen
2017-09-22 17:21 ` Eli Zaretskii
2017-09-22 17:57 ` Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFyQvY2NFF58EkqhSOBS277CjPUiY8DS2woG4biv=EEYVmDfCg@mail.gmail.com' \
--to=kaushal.modi@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=eric@ericabrahamsen.net \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.