From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kaushal Newsgroups: gmane.emacs.devel Subject: Re: Supporting multiline Package-Requires header Date: Mon, 10 Aug 2015 07:42:42 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=089e015382b6d0f3a2051cf37b34 X-Trace: ger.gmane.org 1439206971 9003 80.91.229.3 (10 Aug 2015 11:42:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 10 Aug 2015 11:42:51 +0000 (UTC) Cc: Emacs developers To: Bruce Connor Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 10 13:42:51 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZOlTe-00078Q-Tc for ged-emacs-devel@m.gmane.org; Mon, 10 Aug 2015 13:42:51 +0200 Original-Received: from localhost ([::1]:57754 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZOlTe-0004YW-Ex for ged-emacs-devel@m.gmane.org; Mon, 10 Aug 2015 07:42:50 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55678) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZOlTa-0004YP-Id for emacs-devel@gnu.org; Mon, 10 Aug 2015 07:42:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZOlTZ-00044I-9J for emacs-devel@gnu.org; Mon, 10 Aug 2015 07:42:46 -0400 Original-Received: from mail-ob0-x230.google.com ([2607:f8b0:4003:c01::230]:32846) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZOlTY-00043f-P4 for emacs-devel@gnu.org; Mon, 10 Aug 2015 07:42:44 -0400 Original-Received: by obbhe7 with SMTP id he7so25228630obb.0 for ; Mon, 10 Aug 2015 04:42:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=v9bKH0AOhT9Ffq2vQowLYM837ZN4yaBksKMN0YOyF0w=; b=Chu6kX/9uI450KYtp2oyz0uEEHjkQcCTdnbq9mxwxosqYtNhMg7qGOoGBvBGSh2nk/ CfnLQ4hxmV/FY/V/zzC76MSNtJ0AtOi3YmW3qc6MxQX5jSInxgoaXswTRn4QTFg43d/U tAHK7DJ2bOh0SZemRJs206uFYxvbYa+w2tN8pNI2JJmmehJybR/g5kPrCgdkM1lqmuqe Y5jE5kYeLrh3NA5BoWuzqnM9EkSeqvSBd2jCySgZysGaI4jAHMetYfxo+tfDCz4PeBBl U/RCUT/B93mUyIui5sWZWLYcL83J/U/TEJJ+d5nvdheCDzCRv8smEaPgR+VW783P+qLe xGKw== X-Received: by 10.182.128.234 with SMTP id nr10mr18938685obb.81.1439206963473; Mon, 10 Aug 2015 04:42:43 -0700 (PDT) Original-Received: by 10.202.78.1 with HTTP; Mon, 10 Aug 2015 04:42:42 -0700 (PDT) Original-Received: by 10.202.78.1 with HTTP; Mon, 10 Aug 2015 04:42:42 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4003:c01::230 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:188667 Archived-At: --089e015382b6d0f3a2051cf37b34 Content-Type: text/plain; charset=UTF-8 I think you meant to prefix the comment chars on each line of the multi-line header, correct? As for preference, I like (1) ;; Package-Requires: ((pkg-a "4.2.0") ;; (pkg-b "1.0") (pkg-c "2.0")) In (2), it is not clear where the requires end. -- Kaushal Modi On Aug 10, 2015 7:12 AM, "Artur Malabarba" wrote: > I'd like to add support for multiline Package-Requires headers in > package.el. Does anyone have any preference over the following 2 > possible formats? > > 1. Same as now, just allow it to span more than one line. E.g.: > > ;; Package-Requires: ((pkg-a "4.2.0") > (pkg-b "1.0") (pkg-c "2.0")) > > 2. Without parenthesis, with exactly one per line. E.g.: > > ;; Package-Requires: pkg-a "4.2.0" > pkg-b "1.0" > pkg-c "2.0" > > > Of course, the current way will still be supported. For reference, > here is the current method. > > ;; Package-Requires: ((pkg-a "4.2.0") (pkg-b "1.0") (pkg-c "2.0")) > > --089e015382b6d0f3a2051cf37b34 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

I think you meant to prefix the comment chars on each line o= f the multi-line header, correct?

As for preference, I like (1)

=C2=A0 =C2=A0 ;; Package-Requires: ((pkg-a "4.2.0"= )
=C2=A0 =C2=A0 ;;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (pkg-b "1.0") (pkg-c "2.0&qu= ot;))

In (2), it is not clear where the requires end.

--
Kaushal Modi

On Aug 10, 2015 7:12 AM, "Artur Malabarba&q= uot; <bruce.connor.am@gmail= .com> wrote:
= I'd like to add support for multiline Package-Requires headers in
package.el. Does anyone have any preference over the following 2
possible formats?

1. Same as now, just allow it to span more than one line. E.g.:

=C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; Package-Requires: ((pkg-a "4.2.0")=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (pkg-b "1.0") (pkg-c "2.0&qu= ot;))

2. Without parenthesis, with exactly one per line. E.g.:

=C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; Package-Requires: pkg-a "4.2.0" =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0pkg-b "1.0"
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0pkg-c "2.0"


Of course, the current way will still be supported. For reference,
here is the current method.

=C2=A0 =C2=A0 ;; Package-Requires: ((pkg-a "4.2.0") (pkg-b "= 1.0") (pkg-c "2.0"))

--089e015382b6d0f3a2051cf37b34--