From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kaushal Modi Newsgroups: gmane.emacs.bugs Subject: bug#23897: 25.1.50; Argument at point not being highlighted in eldoc hints Date: Thu, 07 Jul 2016 19:38:21 +0000 Message-ID: References: <577E80BF.7030304@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a11c1684cb9bd72053710d4d9 X-Trace: ger.gmane.org 1467920409 31234 80.91.229.3 (7 Jul 2016 19:40:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 7 Jul 2016 19:40:09 +0000 (UTC) Cc: Dmitry Gutov To: Eli Zaretskii , 23897@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 07 21:40:00 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bLF9T-0003Ae-Cf for geb-bug-gnu-emacs@m.gmane.org; Thu, 07 Jul 2016 21:39:59 +0200 Original-Received: from localhost ([::1]:41942 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLF9S-0003JJ-Kg for geb-bug-gnu-emacs@m.gmane.org; Thu, 07 Jul 2016 15:39:58 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44102) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLF8d-0002ns-SH for bug-gnu-emacs@gnu.org; Thu, 07 Jul 2016 15:39:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bLF8Y-00075Y-NG for bug-gnu-emacs@gnu.org; Thu, 07 Jul 2016 15:39:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57436) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLF8Y-00075T-K9 for bug-gnu-emacs@gnu.org; Thu, 07 Jul 2016 15:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bLF8Y-0006zU-Do for bug-gnu-emacs@gnu.org; Thu, 07 Jul 2016 15:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Kaushal Modi Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Jul 2016 19:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23897 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23897-submit@debbugs.gnu.org id=B23897.146792031926840 (code B ref 23897); Thu, 07 Jul 2016 19:39:02 +0000 Original-Received: (at 23897) by debbugs.gnu.org; 7 Jul 2016 19:38:39 +0000 Original-Received: from localhost ([127.0.0.1]:41540 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bLF8B-0006yq-00 for submit@debbugs.gnu.org; Thu, 07 Jul 2016 15:38:39 -0400 Original-Received: from mail-oi0-f47.google.com ([209.85.218.47]:34119) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bLF89-0006yd-4e for 23897@debbugs.gnu.org; Thu, 07 Jul 2016 15:38:37 -0400 Original-Received: by mail-oi0-f47.google.com with SMTP id s66so37386500oif.1 for <23897@debbugs.gnu.org>; Thu, 07 Jul 2016 12:38:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=INTKrrtWcdIR7UGxSAYqp4eUryqb9C4EX69pVW0cO7k=; b=jpzR+OLTgViwmbxVUaK3y9dvJux602v60L0UfdHebC0ksFnnFtxmmNSjW2cLHJ8swL UTTiwNkn/aia3ZupbwXYBQAtDfF6fTLmlxYBzKYyoacHKNEykuxj0jqScsQw15wUr9Ei gxyFLLyVi7GvwXQthKWgr0kUloTdFdXjuTWpBSNz1HqUzVub71wq/feW52NtR6oSjvz4 S8bV26Il9EhTqcAa+JqGlnsQN8KZ+zXYRw4iH5FrhoFeMZ/40bGp2HZm3e0+O4mqdXXx Mr0qE5esyCqq3POepi8P+UeM0c5iuForFtSNgjJmx0EdLPylsjqBhhohZUWjKDa1ZF+l ZKiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=INTKrrtWcdIR7UGxSAYqp4eUryqb9C4EX69pVW0cO7k=; b=OEzl2HZPFh/rD26E5EO57BxFwRHQghwS03UJk47crzC2Qmn1L6TFLGEkZTb8bpFDv5 egQkTjGdEPzDA7d4HITcyMFd7OKBCc/3AmBQ2nHiOUyAPeE3hLrzSy2oY/eDtDNEAHkd OJLdL51cp4G9ugL8BZqsHk9fp9UqJY6Y3N27RKFNzqof1Q6IZcWVXFosSwMOnEoSU3un yDmB61Stw9UZ0xjXmSbH/CKUCpHFj3wWH5gMxgKd2Vnq0NnDmHNt/kuQxGsGQdXmlpb6 PU86EX29LwKsuEDaGY+Ffx6gSMJQyWlogowhjqi1RKcI100CyLY1dc47x0wNzmeHt/3i vAXQ== X-Gm-Message-State: ALyK8tJx8iZSWhx4EOmmJMnkgO6OTY1ZRuqaMfHVPplTyoHWrVflXYPvo0PEp93dWElQt7S/dbPvil4zBrX4Fg== X-Received: by 10.157.43.108 with SMTP id f41mr1230454otd.189.1467920311495; Thu, 07 Jul 2016 12:38:31 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:120599 Archived-At: --001a11c1684cb9bd72053710d4d9 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Actually I had to run git bisect one last time (I just became impatient). But the conclusion in my previous email was right. git bisect ended with Saved working directory and index state WIP on (no branch): cfb3c61 Enable dividers in NS (bug#22973) HEAD is now at cfb3c61 Enable dividers in NS (bug#22973) 0644e6f56d2be82dd716478eb65e7b3c761d813d is the first bad commit commit 0644e6f56d2be82dd716478eb65e7b3c761d813d Author: Eli Zaretskii Date: Tue Jun 28 19:03:43 2016 +0300 Fix copying properties in 'format' when it produces padding * src/textprop.c (extend_property_ranges): Correct range extension when the new end is beyond the old end. (Bug#23859) :040000 040000 1e0b14a6241e1817a334ef67fdfef7555c2c8a4b eb7f473f651a351ecbb6edc4bb8c0ab3473edb5b M src On Thu, Jul 7, 2016 at 3:31 PM Kaushal Modi wrote: > Phew, finally. > > After git bisecting, I have narrowed down this bug to this commit: > http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3D0644e6f56d2be82dd= 716478eb65e7b3c761d813d > > So I ended git bisecting at this point: > > km=C2=B2~/downloads/:git/emacs> git stash save && git bisect good > > Saved working directory and index state WIP on (no branch): 1f55925 ; Fix > breakage from previous commit > HEAD is now at 1f55925 ; Fix breakage from previous commit > Bisecting: 0 revisions left to test after this (roughly 1 step) > [0644e6f56d2be82dd716478eb65e7b3c761d813d] Fix copying properties in > 'format' when it produces padding > > Building emacs using that commit shows that bug. > > I don't understand what the C code does. But the comments make somewhat > sense as that code change has to do with the format function, and thus > related to the incorrect text properties of eldoc hints. > -- > > -- > Kaushal Modi > --=20 --=20 Kaushal Modi --001a11c1684cb9bd72053710d4d9 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Actually I had to run git bisect one last time (I just bec= ame impatient). But the conclusion in my previous email was right.=C2=A0
git bisect ended with

Saved = working directory and index state WIP on (no branch): cfb3c61 Enable divide= rs in NS (bug#22973)
HEAD is now at cfb3c61 Enable dividers in NS= (bug#22973)
0644e6f56d2be82dd716478eb65e7b3c761d813d is the firs= t bad commit
commit 0644e6f56d2be82dd716478eb65e7b3c761d813d
Author: Eli Zaretskii <eliz@gnu.or= g>
Date: =C2=A0 Tue Jun 28 19:03:43 2016 +0300
<= br>
=C2=A0 =C2=A0 Fix copying properties in 'format' when= it produces padding

=C2=A0 =C2=A0 * src/textprop.= c (extend_property_ranges): Correct range extension
=C2=A0 =C2=A0= when the new end is beyond the old end. =C2=A0(Bug#23859)

:040000 040000 1e0b14a6241e1817a334ef67fdfef7555c2c8a4b eb7f473f65= 1a351ecbb6edc4bb8c0ab3473edb5b M =C2=A0 =C2=A0 =C2=A0src
<= br>
On Thu, Jul 7, 2016 at 3:31 = PM Kaushal Modi <kaushal.modi@= gmail.com> wrote:
Phew, finally.

After git bisecting, I have narr= owed down this bug to this commit:=C2=A0http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3D06= 44e6f56d2be82dd716478eb65e7b3c761d813d

So I ended git bisecting at this point:
=
km=C2=B2~/downloads/:git/emacs> git stash save &= & git bisect good =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0
Saved = working directory and index state WIP on (no branch): 1f55925 ; Fix breakag= e from previous commit
HEAD is now at 1f55925 ; Fix breakage from= previous commit
Bisecting: 0 revisions left to test after this (= roughly 1 step)
[0644e6f56d2be82dd716478eb65e7b3c761d813d] Fix co= pying properties in 'format' when it produces padding

Building emacs using that commit shows that bug.

I don't understand what the C code does. But the comme= nts make somewhat sense as that code change has to do with the format funct= ion, and thus related to the incorrect text properties of eldoc hints.
--

--
Kaushal Modi

--

--
Kaushal Modi

--001a11c1684cb9bd72053710d4d9--