Ah, well since you're replacing the interactive form, I suppose the
replacement should then make sure to check the read-only status as
well.
(interactive (progn (barf-if-buffer-read-only) ...))
The advice gets tricky because I want to add barf-if-buffer-read-only only if the original fn's interactive form had "*".
I am using the same advice fn for eval-region and indent-region.. so I don't need the barf fn call for eval-region.
@Eli: Based on the discussion[1] on emacs-devel, there isn't any opposition to doing what's proposed in this bug thread. So if it's alright by you, and if there is no strong reason to use the more concise alternative i.e. if both barf-if-buffer-read-only and interactive "*.." are equally correct, can the former approach be committed?
Thanks.