From: Kaushal Modi <kaushal.modi@gmail.com>
To: Noam Postavsky <npostavs@users.sourceforge.net>,
Eli Zaretskii <eliz@gnu.org>
Cc: 22819@debbugs.gnu.org
Subject: bug#22819: 25.0.91; Don't try to indent region if the buffer is read-only
Date: Tue, 08 Aug 2017 13:06:52 +0000 [thread overview]
Message-ID: <CAFyQvY299dZ_VrkGfdCu6ig41BBdfhmqAZa4mzcYsPDoTytnJQ@mail.gmail.com> (raw)
In-Reply-To: <CAM-tV-_HJS06f9EbGvD5eHWY7kgJVhfSocOG1jvXdcZShLGcwg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 975 bytes --]
On Mon, Aug 7, 2017 at 2:11 PM Noam Postavsky <
npostavs@users.sourceforge.net> wrote:
> Ah, well since you're replacing the interactive form, I suppose the
> replacement should then make sure to check the read-only status as
> well.
>
> (interactive (progn (barf-if-buffer-read-only) ...))
>
The advice gets tricky because I want to add barf-if-buffer-read-only only
if the original fn's interactive form had "*".
I am using the same advice fn for eval-region and indent-region.. so I
don't need the barf fn call for eval-region.
@Eli: Based on the discussion[1] on emacs-devel, there isn't any opposition
to doing what's proposed in this bug thread. So if it's alright by you, and
if there is no strong reason to use the more concise alternative i.e. if
both barf-if-buffer-read-only and interactive "*.." are equally correct,
can the former approach be committed?
Thanks.
[1]: http://lists.gnu.org/archive/html/emacs-devel/2017-08/msg00168.html
--
Kaushal Modi
[-- Attachment #2: Type: text/html, Size: 1596 bytes --]
next prev parent reply other threads:[~2017-08-08 13:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 13:54 bug#22819: 25.0.91; Don't try to indent region if the buffer is read-only Kaushal Modi
2017-08-05 1:56 ` npostavs
2017-08-05 6:52 ` Eli Zaretskii
2017-08-05 11:50 ` Kaushal Modi
2017-08-05 12:10 ` Eli Zaretskii
2017-08-05 12:29 ` Kaushal Modi
2017-08-05 12:37 ` Eli Zaretskii
2017-08-05 12:47 ` npostavs
2017-08-05 13:13 ` Eli Zaretskii
2017-08-07 17:45 ` Kaushal Modi
2017-08-07 17:53 ` Noam Postavsky
2017-08-07 18:02 ` Kaushal Modi
2017-08-07 18:11 ` Noam Postavsky
2017-08-08 13:06 ` Kaushal Modi [this message]
2017-08-08 13:15 ` npostavs
2017-08-08 19:05 ` Eli Zaretskii
2017-08-08 19:19 ` Kaushal Modi
2017-08-08 21:31 ` John Wiegley
2017-08-09 11:03 ` Kaushal Modi
2017-08-09 21:14 ` John Wiegley
2019-06-25 14:33 ` Lars Ingebrigtsen
2019-06-25 14:35 ` Kaushal Modi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFyQvY299dZ_VrkGfdCu6ig41BBdfhmqAZa4mzcYsPDoTytnJQ@mail.gmail.com \
--to=kaushal.modi@gmail.com \
--cc=22819@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.