From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kaushal Modi Newsgroups: gmane.emacs.bugs Subject: bug#23949: 25.0.95; Regression in handling error caused by (string-match-p "." nil) Date: Tue, 12 Jul 2016 19:29:45 +0000 Message-ID: References: <83lh17ati6.fsf@gnu.org> <83h9bvarb6.fsf@gnu.org> <83r3ayacl5.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a113d38061e07c80537754bb2 X-Trace: ger.gmane.org 1468351900 3687 80.91.229.3 (12 Jul 2016 19:31:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 12 Jul 2016 19:31:40 +0000 (UTC) Cc: schwab@suse.de, 23949@debbugs.gnu.org, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 12 21:31:29 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bN3Ox-00039N-IZ for geb-bug-gnu-emacs@m.gmane.org; Tue, 12 Jul 2016 21:31:27 +0200 Original-Received: from localhost ([::1]:42928 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bN3Ow-0004Ql-Mt for geb-bug-gnu-emacs@m.gmane.org; Tue, 12 Jul 2016 15:31:26 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33779) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bN3Od-0004MW-8N for bug-gnu-emacs@gnu.org; Tue, 12 Jul 2016 15:31:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bN3OY-00082p-FA for bug-gnu-emacs@gnu.org; Tue, 12 Jul 2016 15:31:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36399) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bN3OY-00082l-CT for bug-gnu-emacs@gnu.org; Tue, 12 Jul 2016 15:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bN3OY-0006BJ-7e for bug-gnu-emacs@gnu.org; Tue, 12 Jul 2016 15:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Kaushal Modi Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Jul 2016 19:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23949 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23949-submit@debbugs.gnu.org id=B23949.146835180223627 (code B ref 23949); Tue, 12 Jul 2016 19:31:02 +0000 Original-Received: (at 23949) by debbugs.gnu.org; 12 Jul 2016 19:30:02 +0000 Original-Received: from localhost ([127.0.0.1]:48736 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bN3NZ-00068s-MM for submit@debbugs.gnu.org; Tue, 12 Jul 2016 15:30:02 -0400 Original-Received: from mail-oi0-f51.google.com ([209.85.218.51]:36216) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bN3NY-00068L-5I for 23949@debbugs.gnu.org; Tue, 12 Jul 2016 15:30:00 -0400 Original-Received: by mail-oi0-f51.google.com with SMTP id w18so37835953oiw.3 for <23949@debbugs.gnu.org>; Tue, 12 Jul 2016 12:30:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CxG1RAqMADNConUUgHRdPpyzyicZ8Jwqx/vDL1YInms=; b=q5wGZBRo2n9Wsz7eeYh6Vh6GVa/aCUoDLr1d/wwJZUp5f8kdQiybRmK2ZWQZleJ+gA U+y6COrSQYuj/Yaqc5EiSUJUQITIhF4FP3IbcouFDupD+hvQSZS1vzh/EP7DwfP3kXeG 5dKWqbEjvfpY70DI9C4xVnphgbD6Cw78UQwFmv7NDlIxcqAwSyEFmZuMibKt6MCB5Y+G kU9pG+xeVGnGDtCOHt+4ok+65eRa5+7RA1YUIoONr3Uvg7fzlcXFmUk5J+C9qEnsTz0q 18Q/MdVNp9mEaGkEiiFSjK7AeXLXJPi4urjoh5snYc7VeBQI1L3GufOyvf/G6109HVZh OFRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CxG1RAqMADNConUUgHRdPpyzyicZ8Jwqx/vDL1YInms=; b=Uj6akyp8Ejh9mPsmA7PCWG6IMEo33gUa7/8VXqvWsOZ65G6f0APRjVw5ZqalSZMwRR uooD8NtPlQn1dMVBSv0PxBi7q8VlojZF9HJeEvwZ8slE7YsWNES5c/I7YMQZtFJLVPGg +v5wTPLbQuYxndw2j9mOrx41u3nvEBtWl4F7o6ekj0UzLKfEUeOf2worCua7q3MFd48D OBXXKjFlgD7gTbcKW4WcVoo5aCc7ztN/4s339TIvHJ+KMkh2l/N+U+4a/eoPNRrJR12G F8zd8Tmi2PahiaFjdrPEbWsG0QRUoV7Rm7cf8+79utehH8BSlcEFn9eU2LFRyAgNagJE JQwQ== X-Gm-Message-State: ALyK8tKtKBZsnedxiic71vVwMaZxD6nq4Wg5fHh5DfBsLZ58ZYsvNbEmrDiAoT4iyjuPZ/g0G295hNAVKmWVDg== X-Received: by 10.202.234.5 with SMTP id i5mr628387oih.98.1468351794508; Tue, 12 Jul 2016 12:29:54 -0700 (PDT) In-Reply-To: <83r3ayacl5.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:120947 Archived-At: --001a113d38061e07c80537754bb2 Content-Type: text/plain; charset=UTF-8 On Tue, Jul 12, 2016 at 3:20 PM Eli Zaretskii wrote: > Indeed, it shouldn't, but the question is: what code is responsible > for that which shouldn't happen? If some package or your own > customizations cause the debugger to call extra code, and that extra > code signals an error, then that extra code needs to be fixed, not > Emacs. > It should also be considered that the help-function-arglist error does not happen on emacs 24.5, using the exact same projectile version. > > Also concerning is the fact that, > > > > - (string-match "." nil) gives the expected error backtrace. > > - But (string-match-p "." nil) gives the help-function-arglist error. > > Sorry, I fail to see the significance of this to the issue at hand. > I find the above to be important because both forms give the expected error backtrace on emacs 24.5. But on emacs 25.x, string-match-p gives the unintended help-function-arglist error without any backtrace, while string-match gives the intended error backtrace. The same projectile advices are in effect for all of these. > They are two different functions, and we still don't know which > functions were advised and how. Projectile is advising the delete-file and compilation-find-file functions. The full advice definitions were posted in my previous email. > Perhaps the advice will explain the > difference. Or perhaps we understand the reason for the difference > once we get to the bottom of investigating the problem. Either way, > the efficient method of looking into this problem is to understand > what are those advices and where do they come from. -- -- Kaushal Modi --001a113d38061e07c80537754bb2 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On Tue, Jul 12= , 2016 at 3:20 PM Eli Zaretskii <eliz@gn= u.org> wrote:
Indeed, it sho= uldn't, but the question is: what code is responsible
for that which shouldn't happen?=C2=A0 If some package or your own
customizations cause the debugger to call extra code, and that extra
code signals an error, then that extra code needs to be fixed, not
Emacs.

It should also be considered tha= t the help-function-arglist error does not happen on emacs 24.5, using the = exact same projectile version.
=C2=A0
> Also concerning is the fact that,
>
> - (string-match "." nil) gives the expected error backtrace.=
> - But (string-match-p "." nil) gives the help-function-argli= st error.

Sorry, I fail to see the significance of this to the issue at hand.

I find the above to be important because both = forms give the expected error backtrace on emacs 24.5. But on emacs 25.x, s= tring-match-p gives the unintended help-function-arglist error without any = backtrace, while string-match gives the intended error backtrace. The same = projectile advices are in effect for all of these.
=C2=A0
They are two different functions, and we still don't know which
functions were advised and how.=C2=A0

Proj= ectile is advising the delete-file and compilation-find-file functions. The= full advice definitions were posted in my previous email.
=C2=A0=
Perhaps the advice will explain the difference.=C2=A0 Or perhaps we understand the reason=C2=A0 for the differe= nce
once we get to the bottom of investigating the problem.=C2=A0 Either way, the efficient method of looking into this problem is to understand
what are those advices and where do they come from.=C2=A0
--

--
Kaushal Modi

--001a113d38061e07c80537754bb2--