Re: [Emacs-diffs] master 644cdd1: Use grep's --null option (Bug#6843)

Re: [Emacs-diffs] master 644cdd1: Use grep's --null option (Bug#6843)

[Dmitry Gutov]

Hey Noam,
Sorry I'm late to the party. Some questions below. Thanks.

On 7/20/17 3:02 AM, Noam Postavsky wrote:
> branch: master
> commit 644cdd1aa0a10dbfffa3b9b4c7a97f8cddded0b8
> Author: Noam Postavsky <npostavs@gmail.com>
> Commit: Noam Postavsky <npostavs@gmail.com>
...
> +*** Grep commands will now use GNU grep's '--null' option if
> +available, which allows distinguishing the filename from contents if
> +they contain colons.  This can be controlled by the new custom option
> +'grep-use-null-filename-separator'.

Why do the want the option?

And on the same note, are there any versions of Grep in widespread usage 
that don't support '--null'? AFAICT this flag was added to GNU Grep 2.4 
which was released in 1999.

> +(defconst grep--regexp-alist-bin-matcher
> +  '("^Binary file \\(.+\\) matches$" 1 nil nil 0 1))
> +(defconst grep-with-null-regexp-alist
> +  `(("^\\([^\0]+\\)\\(\0\\)\\([0-9]+\\):" 1 3 ,grep--regexp-alist-column nil nil

Any reason to change 2 to 3? Why don't we use a non-capturing group for 
\0 here?

If the numbers are the same, we could keep the variable's name the same 
as well. As a result, most third-party code would continue to simply work.

> +     (2 '(face unspecified display ":")))
> +    ,grep--regexp-alist-bin-matcher)
> +  "Regexp used to match grep hits.
> +See `compilation-error-regexp-alist'.")
> +(defconst grep-fallback-regexp-alist

Compensating for the multitude of variables by eliminating newlines 
between them doesn't look too hot to me.

Re: [Emacs-diffs] master 644cdd1: Use grep's --null option (Bug#6843)

[Michael Albinus]

Dmitry Gutov <dgutov@yandex.ru> writes:

Hy Dmitry,

> And on the same note, are there any versions of Grep in widespread
> usage that don't support '--null'? AFAICT this flag was added to GNU
> Grep 2.4 which was released in 1999.

# grep --null a *
grep: unrecognized option `--null'
BusyBox v1.01 (2017.06.06-18:34+0000) multi-call binary

Best regards, Michael.

Re: [Emacs-diffs] master 644cdd1: Use grep's --null option (Bug#6843)

[Dmitry Gutov]

On 7/26/17 9:10 PM, Michael Albinus wrote:

> # grep --null a *
> grep: unrecognized option `--null'
> BusyBox v1.01 (2017.06.06-18:34+0000) multi-call binary

Thanks.

Do people use [recent versions of] Emacs in BusyBox environments, though?

Re: [Emacs-diffs] master 644cdd1: Use grep's --null option (Bug#6843)

[Alexis]

Dmitry Gutov <dgutov@yandex.ru> writes:

> On 7/26/17 9:10 PM, Michael Albinus wrote:
>
>> # grep --null a *
>> grep: unrecognized option `--null'
>> BusyBox v1.01 (2017.06.06-18:34+0000) multi-call binary
>
> Thanks.
>
> Do people use [recent versions of] Emacs in BusyBox 
> environments, though?

Iirc, BusyBox is the default userland on Alpine Linux.


Alexis.

Re: [Emacs-diffs] master 644cdd1: Use grep's --null option (Bug#6843)

[Herring, Davis]

> Do people use [recent versions of] Emacs in BusyBox environments, though?

Isn't the point of BusyBox to save enough disk and memory to install Emacs on otherwise overconstrained devices?

Davis

PS - I meant this as a joke, but having written it, it starts to sound like a good idea...

Re: [Emacs-diffs] master 644cdd1: Use grep's --null option (Bug#6843)

[Kaushal Modi]

[-- Attachment #1.1: Type: text/plain, Size: 522 bytes --]

On Thu, Jul 27, 2017, 8:01 AM Dmitry Gutov <dgutov@yandex.ru> wrote:

> On 7/26/17 9:10 PM, Michael Albinus wrote:
>
> > # grep --null a *
> > grep: unrecognized option `--null'
> > BusyBox v1.01 (2017.06.06-18:34+0000) multi-call binary
>
> Thanks.
>
> Do people use [recent versions of] Emacs in BusyBox environments, though?
>

I use Emacs 25.2 on my Android phone via Termux. I occasionally use grep
from within Emacs too directly (and pretty sure more so, indirectly,
through some other package).


-- 

Kaushal Modi

[-- Attachment #1.2: Type: text/html, Size: 1266 bytes --]

[-- Attachment #2: Screenshot_20170727-090641.png --]
[-- Type: image/png, Size: 314714 bytes --]

Re: [Emacs-diffs] master 644cdd1: Use grep's --null option (Bug#6843)

[Michael Albinus]

Dmitry Gutov <dgutov@yandex.ru> writes:

Hi Dmitry,

>> # grep --null a *
>> grep: unrecognized option `--null'
>> BusyBox v1.01 (2017.06.06-18:34+0000) multi-call binary
>
> Do people use [recent versions of] Emacs in BusyBox environments, though?

The example above is from my QNAP NAS server. Indeed, there is an Emacs
installation on this machine. But this is not my use case.

And it is not only BusyBox which counts. On HP-UX 11.31, you'll see HP's
grep implementation:

--8<---------------cut here---------------start------------->8---
# what /usr/bin/grep
/usr/bin/grep:
         $Revision: B.11.31_LR
# grep --null a *  
grep: illegal option -- -
grep: illegal option -- u
usage: grep [-E|-F] [-c|-l|-q] [-bhinsvwx] -e pattern_list...
        [-f pattern_file...] [file...]
usage: grep [-E|-F] [-c|-l|-q] [-bhinsvwx] [-e pattern_list...]
        -f pattern_file... [file...]
usage: grep [-E|-F] [-c|-l|-q] [-bhinsvwx] pattern [file...]
--8<---------------cut here---------------end--------------->8---

And yes, there's also an Emacs installation on HP-UX 11.31, I'll use
occasionally @work.

But my major use case is to call `grep' and friends remotely, from my
local Emacs, running in an Ubuntu environment. The remote machine could
run anything, which does not conform to GNU grep.

Best regards, Michael.

Re: [Emacs-diffs] master 644cdd1: Use grep's --null option (Bug#6843)

[Dmitry Gutov]

On 7/27/17 4:30 PM, Michael Albinus wrote:

> And yes, there's also an Emacs installation on HP-UX 11.31, I'll use
> occasionally @work.
> 
> But my major use case is to call `grep' and friends remotely, from my
> local Emacs, running in an Ubuntu environment. The remote machine could
> run anything, which does not conform to GNU grep.

All right. Thanks for the explanation.

Re: [Emacs-diffs] master 644cdd1: Use grep's --null option (Bug#6843)

[Andreas Schwab]

On Jul 26 2017, Dmitry Gutov <dgutov@yandex.ru> wrote:

>> +(defconst grep--regexp-alist-bin-matcher
>> +  '("^Binary file \\(.+\\) matches$" 1 nil nil 0 1))
>> +(defconst grep-with-null-regexp-alist
>> +  `(("^\\([^\0]+\\)\\(\0\\)\\([0-9]+\\):" 1 3 ,grep--regexp-alist-column nil nil
>
> Any reason to change 2 to 3? Why don't we use a non-capturing group for \0
> here?

Why using a group at all?

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: [Emacs-diffs] master 644cdd1: Use grep's --null option (Bug#6843)

[Eli Zaretskii]

> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Wed, 26 Jul 2017 19:58:32 +0300
> 
> And on the same note, are there any versions of Grep in widespread usage 
> that don't support '--null'? AFAICT this flag was added to GNU Grep 2.4 
> which was released in 1999.

That option is specific to GNU Grep, the other versions of Grep don't
support it.

Re: [Emacs-diffs] master 644cdd1: Use grep's --null option (Bug#6843)

[Noam Postavsky]

On Wed, Jul 26, 2017 at 12:58 PM, Dmitry Gutov <dgutov@yandex.ru> wrote:
> Hey Noam,
> Sorry I'm late to the party. Some questions below. Thanks.

I responded in Bug#6843 (also see #27840 since it's due to this commit).