Re: Relics of removed dir-locals-file-2 feature in pretest

[Kaushal Modi <kaushal.modi@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1397 bytes --]

On Wed, Nov 22, 2017 at 10:19 AM Eli Zaretskii <eliz@gnu.org> wrote:

> You keep saying that, but I don't understand why: I still see on the
> latest emacs-26 the code which you say was removed.  What am I
> missing?
>

OK, I grepped for dir-locals-file-2 in the whole emacs repo, and all I get
is:

etc/NEWS:369:19:See the variable 'dir-locals-file-2' for more information.
etc/DOC:46209:11:See also `dir-locals-file-2', whose values override this
one's.
etc/DOC:46210:64:See Info node `(elisp)Directory Local Variables' for
details. Vdir-locals-file-2
lisp/files.el:3908:11:See also `dir-locals-file-2', whose values override
this one's.
lisp/files.el:3911:11:(defconst dir-locals-file-2 ".dir-locals-2.el"
ChangeLog.2:9419:3:    (dir-locals-file-2, dir-locals--all-files): Remove.
ChangeLog.2:9935:3:    (dir-locals-file-2): New const.

I see defconst dir-locals-file-2, but I don't see it being used anywhere.
So I thought that the feature was removed.

But when you said that emacs-26 still has the feature (yay!), I looked at
files.el again.. and of course the feature is there:

I see this in dir-locals--all-files:

           (file-2 (when (string-match "\\.el\\'" file-1)
                     (replace-match "-2.el" t nil file-1)))

So.. there's an issue, though of a different kind.. may be
dir-locals-file-2 mention should be removed? Or instead be used in the
code?
-- 

Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 2050 bytes --]