From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kaushal Modi Newsgroups: gmane.emacs.devel Subject: Help understanding where report-emacs-bug-send-hook is run.. Date: Wed, 17 Feb 2016 09:42:44 -0500 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a113dc57ead8941052bf84514 X-Trace: ger.gmane.org 1455720236 21201 80.91.229.3 (17 Feb 2016 14:43:56 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 17 Feb 2016 14:43:56 +0000 (UTC) To: Emacs developers Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 17 15:43:46 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aW3KT-00023T-U2 for ged-emacs-devel@m.gmane.org; Wed, 17 Feb 2016 15:43:46 +0100 Original-Received: from localhost ([::1]:58064 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aW3KT-0003Sr-82 for ged-emacs-devel@m.gmane.org; Wed, 17 Feb 2016 09:43:45 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45155) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aW3KA-0003QQ-GL for emacs-devel@gnu.org; Wed, 17 Feb 2016 09:43:30 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aW3K9-0003gU-Fj for emacs-devel@gnu.org; Wed, 17 Feb 2016 09:43:26 -0500 Original-Received: from mail-ob0-x22a.google.com ([2607:f8b0:4003:c01::22a]:32815) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aW3K9-0003gN-81 for emacs-devel@gnu.org; Wed, 17 Feb 2016 09:43:25 -0500 Original-Received: by mail-ob0-x22a.google.com with SMTP id jq7so16755404obb.0 for ; Wed, 17 Feb 2016 06:43:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to:content-type; bh=vYRN5AMEFFEhKCKkJehG7ZEaICEn92TQjQXa84oriGc=; b=Uy50yJfF6uMdzJRbkgVEjHBWEDnSvtLLRFpPsNdx4eff+NAEkw5ZBdaPYiujjX6xgC YhKCDxmHNmsPWSBJWBAL0cksIrzZnxeqeyWmmZkAwjPP7PcBSOhHCs+5ImetNnk6wZiF iBIws4KO+fkTPMA6VwmNieo/uNviLy6+cHZQPeHrHbbYvH9VNa9XAaySBLPob1olnYKh PzAeCvcayKURrqZYNIGEFWtRR1DdiP8r6NEGUzLEvCxjqduslMupFhKu9tVOsiIqspqT uvyX2qXpK4STT7+Lz3l3Nbz5sX6JqMRee0juBZZJRlLohRSRkUu2kFJVYHBDxb/OoaB3 XnbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to :content-type; bh=vYRN5AMEFFEhKCKkJehG7ZEaICEn92TQjQXa84oriGc=; b=Oz9frNOur2lWbJDBTu8/xsZuL+QHoEMHP0P+xx8tr9od0FXsT0dIozSgo6Zs8hpIba h0g+uD92TAqaATr4TRfsrAcXv2vj9gVLtZXuto112+j6EzSVuEzm+RwR//bmAgHUKmT6 TFa+8N3xC7psGopb61n1Q5VE4R7GL52Otz/tLbNOUat1oD/ddD9AC+FYB6Am7H5BsJdd O/NZP601FFgio3hUvOzqiFEM/Hr+lEMadQY8f0+Q7TUP8RuGRxm7nabV+sptYyS4VZ2v qeOlPjNQnYn1Cnxf6Rh1DVDru3I0a+XyltSJMgMe4A9C3nux3BK0N+464hoOo0/eS5yH s6hg== X-Gm-Message-State: AG10YORsbu//x4LEJr3FCU+8L+GWLOrik6rigVR47pSp3bimQXIxUnR9kBb4zsLHlpTVtG2C5BNcokid3FcDzw== X-Received: by 10.202.67.133 with SMTP id q127mr1399034oia.116.1455720204435; Wed, 17 Feb 2016 06:43:24 -0800 (PST) Original-Received: by 10.202.201.73 with HTTP; Wed, 17 Feb 2016 06:42:44 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4003:c01::22a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:200083 Archived-At: --001a113dc57ead8941052bf84514 Content-Type: text/plain; charset=UTF-8 Hi, I was trying to fix this bug ( http://comments.gmane.org/gmane.emacs.bugs/113158 ) and while going through the emacsbug.el code, I saw that the report-emacs-bug-send-hook is defined but it is not run any where. My understanding is that you always need a run-hooks form to execute functions in a hook. I grepped the source, but couldn't find any instance where report-emacs-bug-send-hook is run. btw my proposed fix for this bug is to save and restore the windows configuration before and after sending/canceling a report. And bind the cancel action (kill buffers, restore windows config) to a generic binding like "C-c C-k". The currently suggested "C-x k RET" binding will of course continue the current behavior (of closing just the message buffer and not the Bug Help buffer). -- Kaushal Modi --001a113dc57ead8941052bf84514 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

I was trying to fix this bug (=C2= =A0http://com= ments.gmane.org/gmane.emacs.bugs/113158 )

and = while going through the emacsbug.el code, I saw that the report-emacs-bug-s= end-hook is defined but it is not run any where.

M= y understanding is that you always need a run-hooks form to execute functio= ns in a hook.
I grepped the source, but couldn't find any ins= tance where report-emacs-bug-send-hook is run.

btw= my proposed fix for this bug is to save and restore the windows configurat= ion before and after sending/canceling a report.

A= nd bind the cancel action (kill buffers, restore windows config) to a gener= ic binding like "C-c C-k". The currently suggested "C-x k RE= T" binding will of course continue the current behavior (of closing ju= st the message buffer and not the Bug Help buffer).


--
Kaushal Mo= di
--001a113dc57ead8941052bf84514--