all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Kaushal Modi <kaushal.modi@gmail.com>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: Eli Zaretskii <eliz@gnu.org>,
	emacs-devel@gnu.org, monnier@iro.umontreal.ca, oleh@oremacs.com
Subject: Re: [Emacs-diffs] emacs-26 3db388b: Speed up (format "%s" STRING) and the like
Date: Fri, 06 Oct 2017 17:49:43 +0000	[thread overview]
Message-ID: <CAFyQvY1wbKPjt9MUnMTcM2zNE37OSn9MOWx8pU+nrHqrf_VY-A@mail.gmail.com> (raw)
In-Reply-To: <f19bae81-a8c3-dad7-b1e1-e3e41e7228df@cs.ucla.edu>

[-- Attachment #1: Type: text/plain, Size: 933 bytes --]

On Fri, Oct 6, 2017 at 1:45 PM Paul Eggert <eggert@cs.ucla.edu> wrote:

>
> Thanks, that did the trick. I reproduced the problem on an RHEL 6.9
> platform. The problem was due to a significant typo in one of my earlier
> commits, a typo that was exposed by the commit that you mentioned. To
> fix it, I installed the attached patch into emacs-26 and merged emacs-26
> to master.
>

Awesome! I'll try the latest commit soon.

BTW what would be the simplest way to explain why it worked using the
Makefile in hydra pkg, but not when installed via pacakge.el? Inspite of
same (right?) .elc files?

I looked at the commit, but being C-illiterate, made no sense to me.

PS:
Also shouldn't bug reports be easier to write (and recipes easy to
reproduce) if that macro be made part of emacs core? So that people can
assimilate info about packages needing to be installed, followed by elisp
forms in a concise fashion? Eli?
-- 

Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 1415 bytes --]

  reply	other threads:[~2017-10-06 17:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20171004214511.1405.22257@vcs0.savannah.gnu.org>
     [not found] ` <20171004214513.6A40E2041C@vcs0.savannah.gnu.org>
2017-10-05  3:09   ` [Emacs-diffs] emacs-26 3db388b: Speed up (format "%s" STRING) and the like Stefan Monnier
2017-10-05  6:07     ` Paul Eggert
2017-10-05  7:30       ` Eli Zaretskii
2017-10-05 13:20         ` Stefan Monnier
2017-10-05 16:57           ` Kaushal Modi
2017-10-05 17:08             ` Kaushal Modi
2017-10-05 17:09               ` Kaushal Modi
2017-10-05 18:47               ` Eli Zaretskii
2017-10-05 20:13                 ` Kaushal Modi
2017-10-05 21:44                   ` Paul Eggert
2017-10-06  0:47                     ` Kaushal Modi
2017-10-06 17:45                       ` Paul Eggert
2017-10-06 17:49                         ` Kaushal Modi [this message]
2017-10-06 18:06                           ` Paul Eggert
2017-10-06 18:15                             ` Kaushal Modi
2017-10-06 18:21                               ` Kaushal Modi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFyQvY1wbKPjt9MUnMTcM2zNE37OSn9MOWx8pU+nrHqrf_VY-A@mail.gmail.com \
    --to=kaushal.modi@gmail.com \
    --cc=eggert@cs.ucla.edu \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=oleh@oremacs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.