From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kaushal Modi Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 098d47b: * lisp/emacs-lisp/derived.el (define-derived-mode): Revert indent change. Date: Sat, 27 Feb 2016 10:02:22 -0500 Message-ID: References: <20160227055054.15422.83807@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a1135a77cf4547a052cc1b3b5 X-Trace: ger.gmane.org 1456585356 3469 80.91.229.3 (27 Feb 2016 15:02:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 27 Feb 2016 15:02:36 +0000 (UTC) Cc: Oleh Krehel , Leo Liu , "emacs-devel@gnu.org" To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Feb 27 16:02:33 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aZgO5-0001ED-9d for ged-emacs-devel@m.gmane.org; Sat, 27 Feb 2016 16:02:29 +0100 Original-Received: from localhost ([::1]:55124 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZgO4-0006iU-7z for ged-emacs-devel@m.gmane.org; Sat, 27 Feb 2016 10:02:28 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49102) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZgO0-0006iC-RT for emacs-devel@gnu.org; Sat, 27 Feb 2016 10:02:25 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aZgO0-0006A4-3d for emacs-devel@gnu.org; Sat, 27 Feb 2016 10:02:24 -0500 Original-Received: from mail-oi0-x22c.google.com ([2607:f8b0:4003:c06::22c]:32875) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZgNz-0006A0-Uh for emacs-devel@gnu.org; Sat, 27 Feb 2016 10:02:24 -0500 Original-Received: by mail-oi0-x22c.google.com with SMTP id j125so80521769oih.0 for ; Sat, 27 Feb 2016 07:02:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=kGKvF4A59Gw/tnpypH9PoYj7MCUNM0uK/qbotSzdA+g=; b=PUAJTN1SOrPqc1fYSUccWlI5bOHkpJbS9+mvQojPiQHyVq2QTRdn7aPJWRwCuc3fq5 OsaxWbVhzM4XmKeTOgq1LzufHYgmnZYaWIoNFaCYP0mSvbaXg8K7zcgK/PVHVAnb7Occ ilUBNvtFzdWZbnMioGFy4uEmUPkZYpk/jQcxeD6N894Fz2/U/m+yfecuKjsm3idOj5Pm 7pNrBT0wyBhrGKmFwIMLP/JUyaNDcwdwjeme/AUwlW7Q9fKq5CtCBRKAvBHF9AoZRYNp RnmKBfn8AtDKXKRyVRoa79rSG8HNQ4ZSEQE/KDcjUN4SHMNb3EqU1+/QyjIy9K+tjI+o aV7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=kGKvF4A59Gw/tnpypH9PoYj7MCUNM0uK/qbotSzdA+g=; b=QyTMaH6Jr3ZDK4GkPbnwE3oGvOz6qFcM4i1hnlTyoBPzbaP/duel2NRfrNLSFvxyZ0 ic3eV0XX49Ny+O1mj62AMpPGhsm6C5YRmHVOLBdvIOmE0ADV21ZSgGnhvp6BK0jUcYpz 1P/SjoASdOGqPEN9LF1sNa3MrWbNZPR2s1xjI2zKX0+n/dnu9sedDfoeG2xx9Wb6IyWJ KpZAqsaRWoXJPjaDFrO24J4VNk1MZQ2W6FtKP9f5U9J08jeOPgXpIcVS3cE1VscOgFBm +Y6sQ53FPqyL6x2t2p8PV2J1UbYE26J5VSSxsdF+tWGJQ8aCyvuUDh9SH8Y+J9U8HRmb CyaA== X-Gm-Message-State: AD7BkJJZC0gNwt2EhfUZuUDAmyBEPnoD0OiCwb8bmGwGdkm9+OBvXpfTzXa1VQERjPE6y+dnXgxDR5O4FDGkew== X-Received: by 10.202.72.129 with SMTP id v123mr5078339oia.116.1456585342988; Sat, 27 Feb 2016 07:02:22 -0800 (PST) Original-Received: by 10.202.172.198 with HTTP; Sat, 27 Feb 2016 07:02:22 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4003:c06::22c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:200716 Archived-At: --001a1135a77cf4547a052cc1b3b5 Content-Type: text/plain; charset=UTF-8 FWIW I actually liked the indent change that was put in the first place. If you look at the explanation in that commit, it makes sense why that indent change was done. I did not understand why it was reverted in this recent commit. Kaushal On Saturday, February 27, 2016, Stefan Monnier wrote: > > * lisp/emacs-lisp/derived.el (define-derived-mode): Revert indent > change. > > One more time: please always include some kind of explanation when you > revert code. E.g. a bug# or something. > > > Stefan > > -- -- Kaushal Modi --001a1135a77cf4547a052cc1b3b5 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable FWIW I actually liked the indent change that was put in the first place. If= you look at the explanation in that commit, it makes sense why that indent= change was done.=C2=A0

I did not understand why it was = reverted in this recent commit.=C2=A0

Kaushal=C2=A0

On Saturday, February 27, 2016, Stefan Monnier <monnier@iro.umontreal.ca> = wrote:
>=C2=A0 =C2=A0 =C2=A0* lisp/ema= cs-lisp/derived.el (define-derived-mode): Revert indent change.

One more time: please always include some kind of explanation when you
revert code.=C2=A0 E.g. a bug# or something.


=C2=A0 =C2=A0 =C2=A0 =C2=A0 Stefan



--

--
Kaushal Modi
--001a1135a77cf4547a052cc1b3b5--