From: Kaushal Modi <kaushal.modi@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Oleh Krehel <ohwoeowho@gmail.com>, Leo Liu <sdl.web@gmail.com>,
"emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: Re: [Emacs-diffs] emacs-25 098d47b: * lisp/emacs-lisp/derived.el (define-derived-mode): Revert indent change.
Date: Sat, 27 Feb 2016 10:02:22 -0500 [thread overview]
Message-ID: <CAFyQvY1upAXtdZ71vhWYpOafkziCbN2TzFbc6CFyHrfSAbZ3Rg@mail.gmail.com> (raw)
In-Reply-To: <jwvsi0ecjxa.fsf-monnier+emacsdiffs@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 573 bytes --]
FWIW I actually liked the indent change that was put in the first place. If
you look at the explanation in that commit, it makes sense why that indent
change was done.
I did not understand why it was reverted in this recent commit.
Kaushal
On Saturday, February 27, 2016, Stefan Monnier <monnier@iro.umontreal.ca>
wrote:
> > * lisp/emacs-lisp/derived.el (define-derived-mode): Revert indent
> change.
>
> One more time: please always include some kind of explanation when you
> revert code. E.g. a bug# or something.
>
>
> Stefan
>
>
--
--
Kaushal Modi
[-- Attachment #2: Type: text/html, Size: 892 bytes --]
next prev parent reply other threads:[~2016-02-27 15:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160227055054.15422.83807@vcs.savannah.gnu.org>
[not found] ` <E1aZXmJ-00041n-22@vcs.savannah.gnu.org>
2016-02-27 14:23 ` [Emacs-diffs] emacs-25 098d47b: * lisp/emacs-lisp/derived.el (define-derived-mode): Revert indent change Stefan Monnier
2016-02-27 15:02 ` Kaushal Modi [this message]
2016-02-27 17:23 ` Leo Liu
2016-02-28 10:23 ` Richard Stallman
2016-02-28 16:25 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFyQvY1upAXtdZ71vhWYpOafkziCbN2TzFbc6CFyHrfSAbZ3Rg@mail.gmail.com \
--to=kaushal.modi@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=ohwoeowho@gmail.com \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.