From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kaushal Modi Newsgroups: gmane.emacs.bugs Subject: bug#23451: 25.0.93; Clarify the dependency on find/grep for platforms not having those tools Date: Wed, 04 May 2016 18:02:18 +0000 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=089e0149bff6661f2105320807e7 X-Trace: ger.gmane.org 1462385086 3390 80.91.229.3 (4 May 2016 18:04:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 4 May 2016 18:04:46 +0000 (UTC) To: 23451@debbugs.gnu.org, drew.adams@oracle.com, dgutov@yandex.ru Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 04 20:04:36 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ay1A2-0004N6-Q9 for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 May 2016 20:04:35 +0200 Original-Received: from localhost ([::1]:49546 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ay19z-0007EN-4e for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 May 2016 14:04:31 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36804) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ay19n-0006zk-Vm for bug-gnu-emacs@gnu.org; Wed, 04 May 2016 14:04:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ay19b-0004fu-8n for bug-gnu-emacs@gnu.org; Wed, 04 May 2016 14:04:14 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54033) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ay19a-0004eg-45 for bug-gnu-emacs@gnu.org; Wed, 04 May 2016 14:04:07 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ay19W-00054Y-Hj for bug-gnu-emacs@gnu.org; Wed, 04 May 2016 14:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Kaushal Modi Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 May 2016 18:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 23451 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: "bug-gnu-emacs@gnu.org" , Drew Adams , Dmitry Gutov Original-Received: via spool by submit@debbugs.gnu.org id=B.146238501419461 (code B ref -1); Wed, 04 May 2016 18:04:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 4 May 2016 18:03:34 +0000 Original-Received: from localhost ([127.0.0.1]:38137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ay194-00053p-0S for submit@debbugs.gnu.org; Wed, 04 May 2016 14:03:34 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:45541) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ay192-00053d-SE for submit@debbugs.gnu.org; Wed, 04 May 2016 14:03:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ay18n-0004Rx-6J for submit@debbugs.gnu.org; Wed, 04 May 2016 14:03:24 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:40747) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ay18m-0004QY-0i for submit@debbugs.gnu.org; Wed, 04 May 2016 14:03:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36383) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ay18Y-0005Vx-UD for bug-gnu-emacs@gnu.org; Wed, 04 May 2016 14:03:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ay18K-0004Jm-0G for bug-gnu-emacs@gnu.org; Wed, 04 May 2016 14:02:55 -0400 Original-Received: from mail-ob0-x236.google.com ([2607:f8b0:4003:c01::236]:36417) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ay18I-0004FK-QH for bug-gnu-emacs@gnu.org; Wed, 04 May 2016 14:02:47 -0400 Original-Received: by mail-ob0-x236.google.com with SMTP id aq1so19163780obc.3 for ; Wed, 04 May 2016 11:02:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to; bh=T26UevtFRJLqsTVy2G2y5DJ68PPMIUqTpwTYlVdSFt8=; b=PeJpe4jOYNGIrigcacskBXgw5C1zBc3iC0giFux66H8Ue4GT3i7jreyvbp3Gr5EQqZ PBRqFZ5m9HVNWaMp0k1cwLMkaZStLwo3FdhoqLIxx/a3ji4HrFdpc7PYFYxcjnJCbC72 uafOABuApH2X5n1z3842WdloSXB2BqUJ2W26jwhdQqCwuEYrWzxu7iVwu3EMYRQDpphN otFBq2ADYFqnqVdU+NS3DtlKhrrHFGfVmQ5MDH6nlgL6pt95NsI+MH1dqY2pkEi1d6+f +2gcejW/3EuWuQYbQZqmnmnpFl8SuE6K5nZ5Hcj86+FDYN/9XcTJAAQM49iJZJWG0xAM 8dzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=T26UevtFRJLqsTVy2G2y5DJ68PPMIUqTpwTYlVdSFt8=; b=Hft36GdgT0HSKvS+XbMqE9MTh+3UraNmq8619Upmxk0rRX9FHMydX+vOHPuVK1rcd8 8VuHYazivr6bmT9ramEqsnBbEnsmUx6s8Fdln/TUvDARCKyTmA0o2Kv0cE+PUKXqw22Z sopc4ULsO74l1FA2V1gAR999xpPnsCCq8Exc3Gg53oJSuZPNkgWMJSQEWDykth6NCOGj zvOiZ4BLW3ZA/zBh/3hqEMYsBdQtHDNkUyViySZBZ19fTY1aBu5+K/WHme0qUwdT/vrM +aPBE8nFp/79CfuZYBeYzl0PBnsN8vRjGmNW5q3jPeWAy3neekhuVIQBzcrc7itcsIx+ 8DIA== X-Gm-Message-State: AOPr4FWeON/8bPS06wrJ0oWjH4LGFgHgC+eM2G7Ic59PLVEE/UBAfKVUPU9r4QBYqj5K4nQ5ifieY/hU9Q6sxQ== X-Received: by 10.182.224.137 with SMTP id rc9mr4834287obc.39.1462384948811; Wed, 04 May 2016 11:02:28 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:117779 Archived-At: --089e0149bff6661f2105320807e7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable From: kmodi@ulcf41.cld.analog.com (Kaushal.Modi) To: bug-gnu-emacs@gnu.org Subject: --text follows this line-- The changes to the A/Q bindings in dired as discussed and confirmed are not immediately compatible on Windows Ref: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D23426#49 Even understanding that users would need to install GNU find & grep on their Windows system to use the new implementations bound to A/Q in dired, I believe that we should have the following: - NOT bind A/Q at all if the right dependencies are not found. I tried the A binding on Windows, it looked like it was grepping for the strings I entered and returned an empty *xref* window. The same search on same files worked as expected in RHEL (to be honest I love this new feature on RHEL, and I might start using the A binding). Currently the implementation on Windows gives an appearance that something was searched for and no results were found. That is misleading! Possible solution? (when (correct-version-of-find-and-grep-found-p) (define-key dired-mode-map (kbd "A") #'dired-do-find-regexp) (define-key dired-mode-map (kbd "A") #'dired-do-find-regexp-and-replace)= ) - Another alternative would be (if we want to keep A/Q bindings) that a user-error or error be thrown if the correct external dependencies are not installed. The user should be let known that they need to install the GNU find/grep executables for their platform in order to use those commands. In the current implementation, the user will just assume that they searched something and nothing got returned. - The requirement to have find/grep installed should also go to backward incompatible changes section in NEWS. (I got an idea of "incompatible change" section in NEWS from this recent commit: http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=3Demacs-25&id=3Dc68a09= 107c1f7459c626d38be5e0e991912e57ec ) I would suggest that this bug be made blocking for the release of 25.1. For Windows users, the bindings change for A/Q keys in dired is not apparent to the user. At the very least, an error should be thrown if the correct external dependencies (GNU version of find/grep) are not found on the system PATH. In GNU Emacs 25.0.93.4 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.23) of 2016-05-04 built on .. Repository revision: adc80b7e238e09b1b8c392ecf902d2b978d9016d Windowing system distributor 'The X.Org Foundation', version 11.0.60900000 System Description: Red Hat Enterprise Linux Workstation release 6.6 (Santiago) Configured using: 'configure --with-modules --prefix=3D/home/kmodi/usr_local/apps/6/emacs/emacs-25 'CPPFLAGS=3D-fgnu89-inline -I/home/kmodi/usr_local/6/include -I/usr/include/freetype2 -I/usr/include' 'CFLAGS=3D-ggdb3 -O0' 'CXXFLAGS=3D-ggdb3 -O0' 'LDFLAGS=3D-L/home/kmodi/usr_local/6/lib -L/home/kmodi/usr_local/6/lib64 -ggdb3' PKG_CONFIG_PATH=3D/home/kmodi/usr_local/6/lib/pkgconfig:/home/kmodi/usr_lo= cal/6/lib64/pkgconfig:/cad/adi/apps/gnu/linux/x86_64/6/lib/pkgconfig:/cad/a= di/apps/gnu/linux/x86_64/6/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pk= gconfig:/usr/share/pkgconfig:/lib/pkgconfig:/lib64/pkgconfig' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK2 X11 MODULES Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=3Dnone locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Making completion list... Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message dired format-spec rfc822 mml mml-sec password-cache epg epg-config gnus-util mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util help-fns help-mode easymenu cl-loaddefs pcase cl-lib mail-prsvr mail-utils time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 87685 9438) (symbols 48 19756 0) (miscs 40 40 172) (strings 32 14551 3894) (string-bytes 1 435236) (vectors 16 12373) (vector-slots 8 433753 3061) (floats 8 168 95) (intervals 56 243 0) (buffers 976 12) (heap 1024 36573 680)) --=20 --=20 Kaushal Modi --089e0149bff6661f2105320807e7 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
From: = kmodi@ulcf41.cld.analog.com (Kaushal.Modi)
Subject:
--text follows this line--

The changes to t= he A/Q bindings in dired as discussed and confirmed are not immediately com= patible on Windows


Even understa= nding that users would need to install GNU find & grep on
the= ir Windows system to use the new implementations bound to A/Q in dired,
I believe that we should have the following:

- NOT bind A/Q at all if the right dependencies are not found. I tried th= e
A binding on Windows, it looked like it was grepping for the st= rings I
entered and returned an empty *xref* window. The same sea= rch on same files
worked as expected in RHEL (to be honest I love= this new feature on RHEL,
and I might start using the A binding)= . Currently the implementation on
Windows gives an appearance tha= t something was searched for and no results
were found. That is m= isleading!

Possible solution?

=
(when (correct-version-of-find-and-grep-found-p)
=C2=A0 =C2= =A0(define-key dired-mode-map (kbd "A") #'dired-do-find-regex= p)
=C2=A0 =C2=A0(define-key dired= -mode-map (kbd "A") #'dired-do-find-regexp-and-replace))

- Another alternative would be (if we want to k= eep A/Q bindings) that a
user-error or error be thrown if the cor= rect external dependencies are not
installed. The user should be = let known that they need to install the GNU
find/grep executables= for their platform in order to use those commands. In
the curren= t implementation, the user will just assume that they searched
so= mething and nothing got returned.

- The requiremen= t to have find/grep installed should also go to backward
incompat= ible changes section in NEWS.

(I got an idea= of "incompatible change" section in NEWS from this recent commit= :=C2=A0http://git.savann= ah.gnu.org/cgit/emacs.git/commit/?h=3Demacs-25&id=3Dc68a09107c1f7459c62= 6d38be5e0e991912e57ec=C2=A0)

I would suggest t= hat this bug be made blocking for the release of 25.1.=C2=A0

=
For Windows users, the bindings change for A/Q keys in dired is = not apparent to the user. At the very least, an error should be thrown if t= he correct external dependencies (GNU version of find/grep) are not found o= n the system PATH.



I= n GNU Emacs 25.0.93.4 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.23)
=C2=A0of 2016-05-04 built on ..
Repository revision: adc80b= 7e238e09b1b8c392ecf902d2b978d9016d
Windowing system distributor &= #39;The X.Org Foundation', version 11.0.60900000
System Descr= iption: Red= Hat Enterprise Linux Workstation release 6.6 (Santiago)

Configured using:
=C2=A0'configure --with-modules
=C2=A0--prefix=3D/home/kmodi/usr_local/apps/6/emacs/emacs-25
=C2=A0'CPPFLAGS=3D-fgnu89-inline -I/home/kmodi/usr_local/6/include
=C2=A0-I/usr/include/freetype2 -I/usr/include' 'CFLAGS=3D-g= gdb3 -O0'
=C2=A0'CXXFLAGS=3D-ggdb3 -O0' 'LDFLAGS= =3D-L/home/kmodi/usr_local/6/lib
=C2=A0-L/home/kmodi/usr_local/6/= lib64 -ggdb3'
=C2=A0PKG_CONFIG_PATH=3D/home/kmodi/usr_local/6= /lib/pkgconfig:/home/kmodi/usr_local/6/lib64/pkgconfig:/cad/adi/apps/gnu/li= nux/x86_64/6/lib/pkgconfig:/cad/adi/apps/gnu/linux/x86_64/6/lib64/pkgconfig= :/usr/lib/pkgconfig:/usr/lib64/pkgconfig:/usr/share/pkgconfig:/lib/pkgconfi= g:/lib64/pkgconfig'

Configured features:
=
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS<= /div>
NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS GTK2 X11 MODULES

Import= ant settings:
=C2=A0 value of $LANG: en_US.UTF-8
=C2=A0= value of $XMODIFIERS: @im=3Dnone
=C2=A0 locale-coding-system: ut= f-8-unix

Major mode: Lisp Interaction
Minor modes in effect:
=C2=A0 tooltip-mode: t
<= div>=C2=A0 global-eldoc-mode: t
=C2=A0 electric-indent-mode: t
=C2=A0 mouse-wheel-mode: t
=C2=A0 tool-bar-mode: t
<= div>=C2=A0 menu-bar-mode: t
=C2=A0 file-name-shadow-mode: t
=
=C2=A0 global-font-lock-mode: t
=C2=A0 font-lock-mode: t
=C2=A0 blink-cursor-mode: t
=C2=A0 auto-composition-mode: = t
=C2=A0 auto-encryption-mode: t
=C2=A0 auto-compressio= n-mode: t
=C2=A0 line-number-mode: t
=C2=A0 transient-m= ark-mode: t

Recent messages:
For informa= tion about GNU Emacs and the GNU system, type C-h C-a.
Making com= pletion list...

Load-path shadows:
None = found.

Features:
(shadow sort mail-extr = emacsbug message dired format-spec rfc822 mml
mml-sec password-ca= che epg epg-config gnus-util mm-decode mm-bodies
mm-encode mail-p= arse rfc2231 mailabbrev gmm-utils mailheader sendmail
rfc2047 rfc= 2045 ietf-drums mm-util help-fns help-mode easymenu
cl-loaddefs p= case cl-lib mail-prsvr mail-utils time-date mule-util
tooltip eld= oc electric uniquify ediff-hook vc-hooks lisp-float-type
mwheel x= -win term/common-win x-dnd tool-bar dnd fontset image regexp-opt
= fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register
page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock
font-lock syntax facemenu font-core frame cl-generic cham georgian<= /div>
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean<= /div>
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech euro= pean
ethiopic indian cyrillic chinese charscript case-table epa-h= ook
jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadv= ice
loaddefs button faces cus-face macroexp files text-properties= overlay
sha1 md5 base64 format env code-pages mule custom widget=
hashtable-print-readable backquote dbusbind inotify dynamic-sett= ing
system-font-setting font-render-setting move-toolbar gtk x-to= olkit x
multi-tty make-network-process emacs)

Memory information:
((conses 16 87685 9438)
=C2= =A0(symbols 48 19756 0)
=C2=A0(miscs 40 40 172)
=C2=A0(= strings 32 14551 3894)
=C2=A0(string-bytes 1 435236)
= =C2=A0(vectors 16 12373)
=C2=A0(vector-slots 8 433753 3061)
=
=C2=A0(floats 8 168 95)
=C2=A0(intervals 56 243 0)
=C2=A0(buffers 976 12)
=C2=A0(heap 1024 36573 680))
--

--
Kaushal Modi

--089e0149bff6661f2105320807e7--