From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kaushal Newsgroups: gmane.emacs.devel Subject: Re: ASCII-folded search [was: Re: Upcoming loss of usability ...] Date: Thu, 25 Jun 2015 17:49:46 +0000 Message-ID: References: <20150615142237.GA3517@acm.fritz.box> <5580D356.4050708@cs.ucla.edu> <87si9qonxb.fsf@gnu.org> <87ioamz8if.fsf@petton.fr> <32013464-2300-46c6-ba46-4a3c36bfee5d@default> <87twu62nnt.fsf@mbork.pl> <87oakdfwim.fsf@uwakimon.sk.tsukuba.ac.jp> <83wpz1lh7c.fsf@gnu.org> <83oakdl7yj.fsf@gnu.org> <83ioall3x5.fsf@gnu.org> <87h9pzxtyi.fsf@mail.linkov.net> <87k2uudoqr.fsf@mail.linkov.net> <87616c94g4.fsf@mail.linkov.net> <87h9pw6922.fsf@mail.linkov.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a1138ee8c64b1eb05195b4005 X-Trace: ger.gmane.org 1435254641 22857 80.91.229.3 (25 Jun 2015 17:50:41 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 25 Jun 2015 17:50:41 +0000 (UTC) Cc: "Stephen J. Turnbull" , emacs-devel , Eli Zaretskii , Stefan Monnier To: bruce.connor.am@gmail.com, Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jun 25 19:50:31 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z8BI7-0007MW-Tk for ged-emacs-devel@m.gmane.org; Thu, 25 Jun 2015 19:50:24 +0200 Original-Received: from localhost ([::1]:56866 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8BI7-0000n3-1t for ged-emacs-devel@m.gmane.org; Thu, 25 Jun 2015 13:50:23 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44731) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8BHk-0000kq-7m for emacs-devel@gnu.org; Thu, 25 Jun 2015 13:50:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z8BHj-0000B0-3Z for emacs-devel@gnu.org; Thu, 25 Jun 2015 13:50:00 -0400 Original-Received: from mail-yk0-x235.google.com ([2607:f8b0:4002:c07::235]:33581) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z8BHh-00009r-7J; Thu, 25 Jun 2015 13:49:57 -0400 Original-Received: by ykdt186 with SMTP id t186so44500428ykd.0; Thu, 25 Jun 2015 10:49:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-type; bh=X5YRHB+jQrZKXMhq81tTI8fUnDxmMXJFL3x2MpabElQ=; b=wbc90+l3oEWdiimB26neFU/xOlw/j3xoUsHo6LtMrH8e6zvBzSvBpF5CqAGm8WTIOb B+aTZKZ3le93AYu8Zy0ingAZ9rjINNCJUlR75QQRR1aNVfqcFTQJA2KdUp80PAfrkGT7 VP1ZYdNtA36EhHwZSstMiPQQ3JIcVA/L0VmthCgR1fr89ZWpU5WdjUAfNK2ja63MT5sL wp5vd9s4i4LF2u24I+fVhrFdpUBcSmfb/HSbtapcmMf6vHgBqHgttd8RvYHNMa9d9Ep0 k3hRwyUaX4xWb5+qiTCvtfvaqwwbsbGUjQxEXpqUGmnA8Xt7J9HXmI7be4+qwNKRDkol wr+g== X-Received: by 10.170.221.86 with SMTP id n83mr57109616ykf.7.1435254596610; Thu, 25 Jun 2015 10:49:56 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4002:c07::235 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:187528 Archived-At: --001a1138ee8c64b1eb05195b4005 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Isearch has a couple of toggles like case-fold, isearch-invisible and now char-fold. After updating, I noticed that the prompt for the regular `C-s` is now "Char-fold Isearch: ". Should that "Char-fold" prefix be there? If so, we should also display what other isearch options are in effect (case-fold, etc). Suggestion: - The prefix be kept the same as before ("Isearch: ") for brevity. - The moment a user starts Isearch (or when user calls a command during Isearch using some binding), the effective isearch properties are flashed in the echo area. That "flashing" would look just as the case-sensitivity state is flashed on hitting `M-c` during isearch. An example of such flashed message could be [Case-fold: on Char-fold: on Search-invisible: off] - If we don't want to flash that message, the message can be displayed and be allowed to stay there till user starts/resumes typing in the minibuffer. Thoughts? On Wed, Jun 24, 2015 at 9:56 PM Artur Malabarba wrote: > > So the most important remaining problem is how to combine char-folding > > with =E2=80=98isearch-lax-whitespace=E2=80=99 and =E2=80=98search-white= space-regexp=E2=80=99. > > It seems this will require duplicating some code between these two. > > I took a shot at this on the last commit. `character-fold-to-regexp' > now takes a second argument (lax), when this is non-nil it appends a + > to the regexp generated from whitespace characters. > It doesn't take `search-whitespace-regexp' into consideration, but I > don't know if that would even make sense given that a character-folded > space is even more general (matches more characters) than what's > specified by `search-whitespace-regexp'. > > --001a1138ee8c64b1eb05195b4005 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Isearch has a couple of toggles like case-fold, isearch-in= visible and now char-fold.

After updating, I noticed tha= t the prompt for the regular `C-s` is now "Char-fold Isearch: ".<= /div>

Should that "Char-fold" prefix be there?= If so, we should also display what other isearch options are in effect (ca= se-fold, etc).

Suggestion:=C2=A0
- The prefix be kept = the same as before ("Isearch: ") for brevity.
- The moment= a user starts Isearch (or when user calls a command during Isearch using s= ome binding), the effective isearch properties are flashed in the echo area= . That "flashing" would look just as the case-sensitivity state i= s flashed on hitting `M-c` during isearch. An example of such flashed messa= ge could be

=C2=A0 =C2=A0 [Case-fold: on Char-fold: on =C2=A0Sea= rch-invisible: off]

- If we don't want to flash that message= , the message can be displayed and be allowed to stay there till user start= s/resumes typing in the minibuffer.

Thoughts?
=
On Wed, Jun 24, 2015 at 9:5= 6 PM Artur Malabarba <bruce= .connor.am@gmail.com> wrote:
> So the most important remaining problem is how to combine char-foldin= g
> with =E2=80=98isearch-lax-whitespace=E2=80=99 and =E2=80=98search-whit= espace-regexp=E2=80=99.
> It seems this will require duplicating some code between these two.
I took a shot at this on the last commit. `character-fold-to-regexp' now takes a second argument (lax), when this is non-nil it appends a +
to the regexp generated from whitespace characters.
It doesn't take `search-whitespace-regexp' into consideration, but = I
don't know if that would even make sense given that a character-folded<= br> space is even more general (matches more characters) than what's
specified by `search-whitespace-regexp'.

--001a1138ee8c64b1eb05195b4005--