all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Kaushal Modi <kaushal.modi@gmail.com>
To: Kyle Meyer <kyle@kyleam.com>, Glenn Morris <rgm@gnu.org>
Cc: Mark Oteiza <mvoteiza@udel.edu>, John Wiegley <johnw@gnu.org>,
	Emacs developers <emacs-devel@gnu.org>,
	Bastien Guerry <bzg@gnu.org>,
	Nicolas Goaziou <mail@nicolasgoaziou.fr>,
	Eli Zaretskii <eliz@gnu.org>
Subject: Org contribution flow (Was: Commit 49c0ff2 "Don't bind org-agenda ..")
Date: Tue, 20 Jun 2017 16:30:31 +0000	[thread overview]
Message-ID: <CAFyQvY1YcEeWyDAHy=6FDhHEO_wzhMFatHuFHf=1Ho2Hg8ZFuA@mail.gmail.com> (raw)
In-Reply-To: <87y3snbmaj.fsf@kyleam.com>


[-- Attachment #1.1: Type: text/plain, Size: 2188 bytes --]

Hello all,

I thought it would be better to spawn off a different thread to discuss
this.

Based on my observation, the Org contribution flow is something like this:

[image: image.png]


On Mon, Jun 19, 2017 at 7:16 PM Kyle Meyer <kyle@kyleam.com> wrote:

> Glenn Morris <rgm@gnu.org> writes:
>
> > Kyle Meyer wrote:
> >
> >> The issue is that, if we backport to Org's master branch, the changes in
> >> Emacs's master branch will be reverted when synced with the release from
> >> Org's maint branch.
>

I believe that that reverting is OK as long as that is a new-feature
commit. That revert will be "reverted" the next time Org major release (cut
from org master) is merged into emacs master. I made the above diagram to
clarify this.

> That's only true if an Org "sync" is yet again going to be just a dump
> > of the files from Org on top of the ones in Emacs. As has been explained
> > before, this is not how to do it. In relevant branch of the Org repo,
> > construct the diff between the current revision and the last revision
> > that was synced with Emacs. Then apply that diff to Emacs.
>
> No, you face the same problem either way.  You have commit X in Emacs's
> master branch and in Org's master branch, but not Org's maint branch.
> Because the goal is to update Emacs to the latest Org release from Org's
> maint [*], commit X would be reverted in the sync.  Sure, you could
> selectively ignore the hunk that reverts back to maint's state
> (i.e. keep the changes from commit X),




> but then you create a situation
> where Emacs's Org files are a weird mix between the released version of
> Org (maint) and the developmental version (Org's master).
>

And thus to prevent this mix, Org related commits should not happen
directly to emacs master. They must go to either org maint or org master.
If they go to org maint (bug/doc fix), emacs master will see those commits
merged sooner. If they go to org master (new feature), emacs master will
eventually see them but only when an org major release is cut out.

Nutshell: Use org master to get bug/doc fixes + new org features at the
soonest.

PS: Please point out any error with the above diagram.
-- 

Kaushal Modi

[-- Attachment #1.2: Type: text/html, Size: 3259 bytes --]

[-- Attachment #2: image.png --]
[-- Type: image/png, Size: 83305 bytes --]

  reply	other threads:[~2017-06-20 16:30 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-17 18:17 Commit 49c0ff2 "Don't bind org-agenda .." Kaushal Modi
2017-06-18  8:45 ` Bastien Guerry
2017-06-19 19:12   ` Kyle Meyer
2017-06-19 19:36     ` Kaushal Modi
2017-06-19 19:49       ` Eli Zaretskii
2017-06-19 19:55         ` Kaushal Modi
2017-06-19 20:41           ` Bastien Guerry
2017-06-19 21:41             ` Kaushal Modi
2017-06-19 21:57               ` Bastien Guerry
2017-06-19 20:38         ` Bastien Guerry
2017-06-19 21:45       ` Kyle Meyer
2017-06-19 22:00         ` Bastien Guerry
2017-06-19 22:00         ` Glenn Morris
2017-06-19 22:34           ` Bastien Guerry
2017-06-19 23:16           ` Kyle Meyer
2017-06-20 16:30             ` Kaushal Modi [this message]
2017-06-21  6:57               ` Org contribution flow Bastien Guerry
2017-06-21 10:42                 ` Mark Oteiza
2017-06-21 12:23                   ` Bastien Guerry
2017-06-21 13:33                 ` Kyle Meyer
2017-06-19 21:47       ` Commit 49c0ff2 "Don't bind org-agenda .." Kyle Meyer
2017-06-19 22:02         ` Bastien Guerry
2017-06-21  8:36           ` Rasmus Pank Roulund
2017-06-21  8:57             ` Michael Albinus
2017-06-21  9:58               ` Bastien Guerry
2017-06-21 10:22                 ` Rasmus
2017-06-21 12:22                   ` Bastien Guerry
2017-06-21 12:32                     ` Michael Albinus
2017-06-21 15:16                     ` Rasmus
2017-06-21 18:00                 ` Eli Zaretskii
2017-06-22  8:34                   ` Bastien Guerry
2017-06-19 20:33     ` Bastien Guerry
2017-06-19 21:44       ` Kyle Meyer
2017-06-20  2:14         ` Mark Oteiza
2017-06-20  6:10           ` Bastien Guerry
2017-06-20 15:09       ` Eli Zaretskii
2017-06-20 15:59         ` Bastien Guerry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFyQvY1YcEeWyDAHy=6FDhHEO_wzhMFatHuFHf=1Ho2Hg8ZFuA@mail.gmail.com' \
    --to=kaushal.modi@gmail.com \
    --cc=bzg@gnu.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=johnw@gnu.org \
    --cc=kyle@kyleam.com \
    --cc=mail@nicolasgoaziou.fr \
    --cc=mvoteiza@udel.edu \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.