From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kaushal Newsgroups: gmane.emacs.devel Subject: Re: Suggestion to have highlight related bindings consistent between search-map and hi-lock-map Date: Tue, 18 Aug 2015 16:22:05 +0000 Message-ID: References: <874mlaearx.fsf@mail.linkov.net> <55A21229.6080903@gmail.com> <55A27E53.7020605@gmail.com> <834ml99zkp.fsf@gnu.org> <831tgd9wcm.fsf@gnu.org> <55AB58FB.8000501@gmail.com> <87r3nqk34p.fsf@mail.linkov.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a11c183d839388b051d9852dc X-Trace: ger.gmane.org 1439914973 18881 80.91.229.3 (18 Aug 2015 16:22:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 18 Aug 2015 16:22:53 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Stefan Monnier , Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 18 18:22:42 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZRjer-00071H-PW for ged-emacs-devel@m.gmane.org; Tue, 18 Aug 2015 18:22:42 +0200 Original-Received: from localhost ([::1]:58363 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZRjer-0000jK-6n for ged-emacs-devel@m.gmane.org; Tue, 18 Aug 2015 12:22:41 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59382) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZRjeY-0000cN-CA for emacs-devel@gnu.org; Tue, 18 Aug 2015 12:22:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZRjeU-0003fL-2I for emacs-devel@gnu.org; Tue, 18 Aug 2015 12:22:22 -0400 Original-Received: from mail-oi0-x229.google.com ([2607:f8b0:4003:c06::229]:34801) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZRjeS-0003dY-9f; Tue, 18 Aug 2015 12:22:16 -0400 Original-Received: by oip136 with SMTP id 136so103424901oip.1; Tue, 18 Aug 2015 09:22:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-type; bh=qA2vMw8IDV4YvbYcUfVmDom4OAU/8l9oXLMclAptkYY=; b=DVCDrzNfxdKYQ7kDoF2q4Ku2XWYWWlnDHAzrZtZurPmWQDaqfVg8JEJx3vMmoP00kX vIGaOv8mQ4ZmnuNLIS3h4kntn+EXu1yJaA4huZ9spKIzPiGg5uhmbp28WT/cxIgG5886 FXo2JRy1hsWJQmcK5bB/a2Z/3WbrMivN9/C41P6t5asrjZKyEnzngsZb8DJ5aqonua9J BG+Ofd51dO1J1DzhKEIKOYAsfTXIKXKBPukRMaginBdDt9v5WMN+D4Re6pUSoJOJwe+9 Z4Y6acnKyZUI3nfSuhxn+2QyJLz9e/IORfsLUGSL9uV1hD4aGtN02qmbOQDiOh0G3S+v sq/g== X-Received: by 10.202.201.146 with SMTP id z140mr6318128oif.134.1439914935267; Tue, 18 Aug 2015 09:22:15 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4003:c06::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:188895 Archived-At: --001a11c183d839388b051d9852dc Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable @Juri So what did you think? On Thu, Jul 30, 2015 at 9:32 PM Kaushal wrote: > Juri, > > I thought quite some bit on how we can add in a warning for key binding > change. But as Stefan says, it is probably not worth it. > > First of, we would need to create a wrapper function or a wrapper macro t= o > create wrapper functions for all the commands that we want to phase out > from being bound with the "C-x w" prefix map. The wrapper function will > call the wrapped function and then issue a warning/message in the echo ar= ea > saying that that function is already bound to "M-s h" prefix and will no > longer be bound to "C-x w" prefix in future. After that, in a future emac= s > version, the final step to unbind those "C-x w" bindings will remain. > > On Thu, Jul 30, 2015 at 6:48 PM Stefan Monnier > wrote: > >> > Do we have a 2-step deprecation process where the first step >> > is to warn the users about the planned changes by issuing >> > a message like =E2=80=9Cuse the new key instead=E2=80=9D like we do wi= th >> > =E2=80=98define-obsolete-function-alias=E2=80=99 and =E2=80=98make-obs= olete-variable=E2=80=99? >> >> No, for key-bindings we just make the change, since we don't pay nearly >> as much attention to breaking "user compatibility" (which can be fixed >> with a define-key in ~/.emacs). >> OTOH if the change ends up breaking third-party packages it might be >> more problematic. >> >> >> Stefan >> > --001a11c183d839388b051d9852dc Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
@Juri So what did you think?

On Thu, Jul 30, 2015 at 9:32 PM Kaushal <kaushal.modi@gmail.com> wrote:
Juri,

=
I thought quite some bit on how we can add in a warning for key bindin= g change. But as Stefan says, it is probably not worth it.

First of, we would need to create a wrapper function or a wrapper = macro to create wrapper functions for all the commands that we want to phas= e out from being bound with the "C-x w" prefix map. The wrapper f= unction will call the wrapped function and then issue a warning/message in = the echo area saying that that function is already bound to "M-s h&quo= t; prefix and will no longer be bound to "C-x w" prefix in future= . After that, in a future emacs version, the final step to unbind those &qu= ot;C-x w" bindings will remain.

On Thu, Jul 30, 2015 at 6:48 PM Stefan Monnier <monnier@iro.umon= treal.ca> wrote:
> Do we = have a 2-step deprecation process where the first step
> is to warn the users about the planned changes by issuing
> a message like =E2=80=9Cuse the new key instead=E2=80=9D like we do wi= th
> =E2=80=98define-obsolete-function-alias=E2=80=99 and =E2=80=98make-obs= olete-variable=E2=80=99?

No, for key-bindings we just make the change, since we don't pay nearly=
as much attention to breaking "user compatibility" (which can be = fixed
with a define-key in ~/.emacs).
OTOH if the change ends up breaking third-party packages it might be
more problematic.


=C2=A0 =C2=A0 =C2=A0 =C2=A0 Stefan
--001a11c183d839388b051d9852dc--