From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Kaushal Modi Newsgroups: gmane.emacs.devel Subject: Breaking change with auto-filling in Org mode with recent commit Date: Wed, 09 Aug 2017 14:43:13 +0000 Message-ID: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a11c03dea226c070556531a5a" X-Trace: blaine.gmane.org 1502289820 24957 195.159.176.226 (9 Aug 2017 14:43:40 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 9 Aug 2017 14:43:40 +0000 (UTC) To: Tom Tromey , Emacs developers Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 09 16:43:35 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dfSCp-0005my-09 for ged-emacs-devel@m.gmane.org; Wed, 09 Aug 2017 16:43:31 +0200 Original-Received: from localhost ([::1]:47843 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dfSCs-0004Sy-2L for ged-emacs-devel@m.gmane.org; Wed, 09 Aug 2017 10:43:34 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40054) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dfSCl-0004Sf-B1 for emacs-devel@gnu.org; Wed, 09 Aug 2017 10:43:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dfSCj-0002Cr-TP for emacs-devel@gnu.org; Wed, 09 Aug 2017 10:43:27 -0400 Original-Received: from mail-yw0-x235.google.com ([2607:f8b0:4002:c05::235]:34353) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dfSCj-0002C0-M5 for emacs-devel@gnu.org; Wed, 09 Aug 2017 10:43:25 -0400 Original-Received: by mail-yw0-x235.google.com with SMTP id s143so41177256ywg.1 for ; Wed, 09 Aug 2017 07:43:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=3P5j31P94PSUh79irQ+nT8Q9bgP17MsGxXqiiEu5vmw=; b=HcGdHy6qFZW49FnqGaBQV9y3ttsmXNp7YCiDluY8Rpr0K11xXLn3QNfsqp4KSVc5TF GfRNTc93Gu2wRGvRBv9E5VdBibU6NhMoi0hIy5QC9jv7HufybDzNUoy43U0oEw+UHWUf coChvoYo6xbNIqbTHD9fM7PEKjnzMiSzFA3KMbxC8yFAkfd39jW0bzbnKzuuwyd2ZkSY 11ogWJpXpVE3QtBydShj8AR48D8D9lV1e/QovCSTZP9JO9eAd8Lelc5+87aCbHmQCA0N BbiFlXzcZhVBaH7jUmQo0SN1+wkJJgVVNlwboOXEd1HfBmYfzcl3YK/sNvdSymd0S6PC EwBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=3P5j31P94PSUh79irQ+nT8Q9bgP17MsGxXqiiEu5vmw=; b=tIBdBPc6MqSbiIAgUGZn7jhhkiobjWYkG5ey7GvWVmGyslqLZfcppMZBYf2qBlR8xM e+N5OR/46Ci/MTDm7NFY7XKxqtEdljc1VdbEKPKkm/s6pxH22HicBQNYNm6Ve8bnw0ph 6VR376r4r1uMxqQ7XO0im3NFPyYC4IxNTxYWLxJ1Klr0WdLPkrW678eEYfcm9oh9W2nh 3LcWukuNyjsSIqK19JbQXUHZ0r9DS4AHZXqO1IE1mpr4/YwGphJzioUAchpPl0ds/1qh 1+5xbT26CZqtUq+z4Us0Ne6BKiT3+9gCdbMAj9fAzBFjwDRRq3xeMwv3KQFI9+/CdjxR DqxQ== X-Gm-Message-State: AHYfb5iakrHc2YSIkrI1cYa91pXUOu0xxoHfS3hIqGg2EYV4ftZxaxRp ycH6qWhIPByG6rbyGE6rKcCrJB/Ipw== X-Received: by 10.37.64.79 with SMTP id n76mr6595577yba.225.1502289804288; Wed, 09 Aug 2017 07:43:24 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4002:c05::235 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217381 Archived-At: --001a11c03dea226c070556531a5a Content-Type: text/plain; charset="UTF-8" Hello, I have noticed auto-filling to stop doing the right thing after commit http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=9b463fa8648b7baed95a44f4317cb7402fd8bf1c I have verified that reverting just that commit brings things back to stable state. Examples in Org mode *with auto-fill-mode enabled*: ===== #+BEGIN_SRC nim # echo @["a", "b", "c"].join(' ') # Error: type mismatch: got (seq[string], char) #+END_SRC ===== Before commit 9b463fa8: - With point at the end of that comment line starting with "echo", if I hit Enter, filling will *not* happen on that line. After commit 9b463fa8: - With point at the end of that comment line starting with "echo", if I hit Enter, filling will happen, resulting in invalid code: ===== #+BEGIN_SRC nim # echo @["a", "b", "c"].join(' ') # Error: type mismatch: got (seq[string], char) #+END_SRC ===== Another example: ===== * Heading 1. =["a", "b", "c"].join(" ")= does not work, but =join(["a", "b", "c"], " ")= works. ===== Before commit 9b463fa8: - With point at the end of that Org list item, if I hit Enter, I will get: ===== * Heading 1. =["a", "b", "c"].join(" ")= does not work, but =join(["a", "b", "c"], " ")= works. ===== - Then if I hit M-RET, I get: ===== * Heading 1. =["a", "b", "c"].join(" ")= does not work, but =join(["a", "b", "c"], " ")= works. 2. ===== Notice that space inserted at the beginning of " "c"], " ")= works." line is important! After commit 9b463fa8: - With point at the end of that Org list item, if I hit Enter, I will get: ===== * Heading 1. =["a", "b", "c"].join(" ")= does not work, but =join(["a", "b", "c"], " ")= works. ===== - Then if I hit M-RET, I get: ===== * Heading 1. =["a", "b", "c"].join(" ")= does not work, but =join(["a", "b", "c"], " ")= works. * ===== As that extra space now not inserted, Org does not detect that I am trying to continue in the same list and starts a new Org heading. I have just given an example using Org. The change in Emacs core though seems to have broken the fundamental operation of auto-filling in comments. -- Kaushal Modi --001a11c03dea226c070556531a5a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,

I have noticed auto-filling to s= top doing the right thing after commit=C2=A0http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3D9b463fa8648b7bae= d95a44f4317cb7402fd8bf1c

I have verified that = reverting just that commit brings things back to stable state.
Examples in Org mode *with auto-fill-mode enabled*:
=
=3D=3D=3D=3D=3D
#+BEGIN_SRC nim
# e= cho @["a", "b", "c"].join(' ') # Erro= r: type mismatch: got (seq[string], char)
#+END_SRC
=3D=3D=3D=3D=3D

Before commit 9b463fa8:
- With point at the end of that comment line starting with "ech= o", if I hit Enter, filling will *not* happen on that line.
=
After commit 9b463fa8:
- With point at the en= d of that comment line starting with "echo", if I hit Enter, fill= ing will happen, resulting in invalid code:
=3D=3D=3D= =3D=3D
#+BEGIN_SRC nim
# echo @["a", &qu= ot;b", "c"].join(' ') # Error: type=C2=A0
= mismatch: got (seq[string], char)
#+END_SRC
= =3D=3D=3D=3D=3D

Another example:

=3D=3D=3D=3D=3D
* Heading
1. =3D["a",= "b", "c"].join(" ")=3D does not work, but = =3Djoin(["a", "b", "c"], " ")=3D wo= rks.
=3D=3D=3D=3D=3D

Before commit 9= b463fa8:
- With point at the end of that Org list item, if I hit = Enter, I will get:
=3D=3D=3D=3D=3D
* Heading
=
1. =3D["a", "b", "c"].join(" "= )=3D does not work, but =3Djoin(["a", "b",
= =C2=A0 =C2=A0"c"], " ")=3D works.
=3D= =3D=3D=3D=3D
- Then if I hit M-RET, I get:
=3D=3D= =3D=3D=3D
* Heading
1. =3D["a", "b&= quot;, "c"].join(" ")=3D does not work, but =3Djoin([&q= uot;a", "b",
=C2=A0 =C2=A0"c"], " &= quot;)=3D works.
2.
=3D=3D=3D=3D=3D
Notice t= hat space inserted at the beginning of " =C2=A0 "c"], "= ")=3D works." line is important!

A= fter commit 9b463fa8:
- With point at the end of that Org list it= em, if I hit Enter, I will get:
=3D=3D=3D=3D=3D
* Headi= ng
1. =3D["a", "b", "c"].join(= " ")=3D does not work, but =3Djoin(["a", "b",=
"c"], " ")=3D works.
=3D=3D= =3D=3D=3D
- Then if I hit M-RET, I get:
=3D=3D=3D= =3D=3D
* Heading
1. =3D["a", "b&quo= t;, "c"].join(" ")=3D does not work, but =3Djoin(["= ;a", "b",
"c"], " ")=3D works.=
*=C2=A0
=3D=3D=3D=3D=3D
As that extra= space now not inserted, Org does not detect that I am trying to continue i= n the same list and starts a new Org heading.

I have just given an example using Or= g. The change in Emacs core though seems to have broken the fundamental ope= ration of auto-filling in comments.
--

Kaushal Modi

--001a11c03dea226c070556531a5a--