all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Kaushal Modi <kaushal.modi@gmail.com>
To: Tom Tromey <tom@tromey.com>, Emacs developers <emacs-devel@gnu.org>
Subject: Breaking change with auto-filling in Org mode with recent commit
Date: Wed, 09 Aug 2017 14:43:13 +0000	[thread overview]
Message-ID: <CAFyQvY1EiNUHf_XzoB9+e0Ei7hd6mjiNGgY1+5pQz3Hr3P70JA@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 2076 bytes --]

Hello,

I have noticed auto-filling to stop doing the right thing after commit
http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=9b463fa8648b7baed95a44f4317cb7402fd8bf1c

I have verified that reverting just that commit brings things back to
stable state.

Examples in Org mode *with auto-fill-mode enabled*:

=====
#+BEGIN_SRC nim
# echo @["a", "b", "c"].join(' ') # Error: type mismatch: got (seq[string],
char)
#+END_SRC
=====

Before commit 9b463fa8:
- With point at the end of that comment line starting with "echo", if I hit
Enter, filling will *not* happen on that line.

After commit 9b463fa8:
- With point at the end of that comment line starting with "echo", if I hit
Enter, filling will happen, resulting in invalid code:
=====
#+BEGIN_SRC nim
# echo @["a", "b", "c"].join(' ') # Error: type
mismatch: got (seq[string], char)
#+END_SRC
=====

Another example:

=====
* Heading
1. =["a", "b", "c"].join(" ")= does not work, but =join(["a", "b", "c"], "
")= works.
=====

Before commit 9b463fa8:
- With point at the end of that Org list item, if I hit Enter, I will get:
=====
* Heading
1. =["a", "b", "c"].join(" ")= does not work, but =join(["a", "b",
   "c"], " ")= works.
=====
- Then if I hit M-RET, I get:
=====
* Heading
1. =["a", "b", "c"].join(" ")= does not work, but =join(["a", "b",
   "c"], " ")= works.
2.
=====
Notice that space inserted at the beginning of "   "c"], " ")= works." line
is important!

After commit 9b463fa8:
- With point at the end of that Org list item, if I hit Enter, I will get:
=====
* Heading
1. =["a", "b", "c"].join(" ")= does not work, but =join(["a", "b",
"c"], " ")= works.
=====
- Then if I hit M-RET, I get:
=====
* Heading
1. =["a", "b", "c"].join(" ")= does not work, but =join(["a", "b",
"c"], " ")= works.
*
=====
As that extra space now not inserted, Org does not detect that I am trying
to continue in the same list and starts a new Org heading.

I have just given an example using Org. The change in Emacs core though
seems to have broken the fundamental operation of auto-filling in comments.
-- 

Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 3703 bytes --]

             reply	other threads:[~2017-08-09 14:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-09 14:43 Kaushal Modi [this message]
2017-08-09 16:07 ` Breaking change with auto-filling in Org mode with recent commit Eric Abrahamsen
2017-08-09 16:12 ` Tom Tromey
2017-08-10 17:54   ` Kaushal Modi
2017-08-10 21:34     ` Kaushal Modi
2017-08-10 22:00       ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFyQvY1EiNUHf_XzoB9+e0Ei7hd6mjiNGgY1+5pQz3Hr3P70JA@mail.gmail.com \
    --to=kaushal.modi@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.