From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kaushal Modi Newsgroups: gmane.emacs.bugs Subject: bug#22714: 25.0.91; Minibuffer quirk in C-x r SPC Date: Wed, 17 Feb 2016 09:07:55 -0500 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a113ce1641d9ce6052bf7c936 X-Trace: ger.gmane.org 1455718163 15664 80.91.229.3 (17 Feb 2016 14:09:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 17 Feb 2016 14:09:23 +0000 (UTC) To: 22714@debbugs.gnu.org, Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 17 15:09:12 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aW2n1-0001Wu-Jc for geb-bug-gnu-emacs@m.gmane.org; Wed, 17 Feb 2016 15:09:11 +0100 Original-Received: from localhost ([::1]:57814 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aW2n0-0000VT-RY for geb-bug-gnu-emacs@m.gmane.org; Wed, 17 Feb 2016 09:09:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35518) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aW2mw-0000VH-U8 for bug-gnu-emacs@gnu.org; Wed, 17 Feb 2016 09:09:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aW2ms-0002vx-IY for bug-gnu-emacs@gnu.org; Wed, 17 Feb 2016 09:09:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40291) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aW2ms-0002vt-EQ for bug-gnu-emacs@gnu.org; Wed, 17 Feb 2016 09:09:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aW2ms-0007QI-Bd for bug-gnu-emacs@gnu.org; Wed, 17 Feb 2016 09:09:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Kaushal Modi Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 Feb 2016 14:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22714 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22714-submit@debbugs.gnu.org id=B22714.145571812228506 (code B ref 22714); Wed, 17 Feb 2016 14:09:02 +0000 Original-Received: (at 22714) by debbugs.gnu.org; 17 Feb 2016 14:08:42 +0000 Original-Received: from localhost ([127.0.0.1]:38965 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aW2mX-0007Ph-O7 for submit@debbugs.gnu.org; Wed, 17 Feb 2016 09:08:41 -0500 Original-Received: from mail-ob0-f180.google.com ([209.85.214.180]:35711) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aW2mW-0007PV-5A for 22714@debbugs.gnu.org; Wed, 17 Feb 2016 09:08:40 -0500 Original-Received: by mail-ob0-f180.google.com with SMTP id xk3so15194598obc.2 for <22714@debbugs.gnu.org>; Wed, 17 Feb 2016 06:08:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=mbwcyJmrEM9uaeXdF5iJriW4Adljs7N5lqPGfQVFXDo=; b=o7XDTIm7hVUV5znEUt3LKyMfgU2KzwjyR3y/eHosyiYe78mAv24ogGApWTXtqGB7zu k/RtObds/D0dJ9XD26Yeae02QdXCie1jb4wWAuXDjg0MyfE66xhn4h3GZJoINlcnogX9 oxu41a3XZYU+nU1ix/NMgoGi0HcQRNUd0s8B/zqBNpoYO5wUk7PXKLrOlPdSBz/Jjoa9 PdtVCT8SlJAlHdTOY/iVyJDaxaGawwElpL62GeE618iznNs44YgzKPYIdWOuB4p5NRCN Fr+JN/O8m9bvlsokNqAwwy4iqFY8ohaCmup90OpSh+BaLfWytW2lfMfWuzKCZpJgf90g 9IAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:content-type; bh=mbwcyJmrEM9uaeXdF5iJriW4Adljs7N5lqPGfQVFXDo=; b=T1t7Q+Nw6qg92vwthAfh4CXrUq17cMoUNCiK/s3leOvHo/BYGHQeQhNYwp1nhAFUaI VLxZS9h643TIsXyIKsWSkxNTPZo39RngX+EObIQEDjY9vr7nvfkpBRYV9AqUm1PsqvAR faUFKtLnE1LJVw+tGg+k4q0li7XvQideQK1zFPSkEx4tnNtf6S43+7O+E8ARQXIBzb10 24TGoQYFLQP6YTGveGmEPui4EOUq+DGGIQ0QP4D4iCxS8AIHuvhGI7fHjVx/op9z+H48 CdoYqbXQ7ELv5SkLy2UgJrdku6pQur1tXY3KAicglWPYLEtawn0ak1BD0Vkzw7G1fSQx qdEw== X-Gm-Message-State: AG10YORO+M0FbZDVFXP1/EiByFZ/EvrR6CSO6BrUFiPlRUcbUZwlDP6G9wWGRPVenoijinnhvMZHGaznBmOdMQ== X-Received: by 10.202.177.215 with SMTP id a206mr1303695oif.2.1455718114628; Wed, 17 Feb 2016 06:08:34 -0800 (PST) Original-Received: by 10.202.201.73 with HTTP; Wed, 17 Feb 2016 06:07:55 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:113182 Archived-At: --001a113ce1641d9ce6052bf7c936 Content-Type: text/plain; charset=UTF-8 OK, I found the change that caused this. http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=emacs-25&id=0da7d35c6754b44d1ef4383e4a8ba9b98afc3a4c diff --git a/lisp/register.el b/lisp/register.el index 1c64a9a..6a5792c 100644 --- a/lisp/register.el +++ b/lisp/register.el @@ -161,7 +161,7 @@ display such a window regardless." collect c))) (unwind-protect (progn - (while (memq (read-event (propertize prompt 'face 'minibuffer-prompt)) + (while (memq (read-key (propertize prompt 'face 'minibuffer-prompt)) help-chars) (unless (get-buffer-window buffer) (register-preview buffer 'show-empty))) It's the use of read-key instead of read-event that's causing this. Stefan should be able to comment more on why that changes the behavior of the prompt staying vs disappearing. -- Kaushal Modi On Wed, Feb 17, 2016 at 8:56 AM, Kaushal Modi wrote: > > I don't have a solution but I can confirm this behavior. > > In emacs 24.5, the "Point to Register" prompt disappears after pressing > "1". > In emacs 25.x, the prompt stays there after pressing "1". > > I tried edebugging in both 24.5 and 25.x but the behavior looks the same > when doing edebug (the prompt disappears). > > I briefly looked at the register.el, but couldn't spot any change there > that could be causing this. So the change is probably in some common > library in elisp/C. > > -- > Kaushal Modi > --001a113ce1641d9ce6052bf7c936 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Stefan should be= able to comment more on why that changes the behavior of the prompt stayin= g vs disappearing.

<= div class=3D"gmail_signature">

--
Kaushal Modi
=

On Wed, Feb 17, 2016 at 8:56 AM, Kaushal Mod= i <kaushal.modi@gmail.com> wrote:
=

I don't have a solution but I can confirm this beh= avior.=C2=A0

In emacs 24.5, the "Point to Register&= quot; prompt disappears after pressing "1".
In emacs 25= .x, the prompt stays there after pressing "1".

I tried edebugging in both 24.5 and 25.x but the behavior looks the = same when doing edebug (the prompt disappears).

I = briefly looked at the register.el, but couldn't spot any change there t= hat could be causing this. So the change is probably in some common library= in elisp/C.

--
Kaushal Modi

--001a113ce1641d9ce6052bf7c936--