* Re: [elpa] master e2ceef9 57/79: Prepend function symbols with octothorpes.
[not found] ` <E1Z3vQj-0005Je-79@vcs.savannah.gnu.org>
@ 2015-06-14 2:59 ` Stefan Monnier
2015-06-18 8:59 ` Jackson Hamilton
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2015-06-14 2:59 UTC (permalink / raw)
To: emacs-devel; +Cc: Jackson Ray Hamilton
> - (advice-remove 'context-coloring-colorize advice)
> + (advice-remove #'context-coloring-colorize advice)
Actually, the first argument of `advice-remove' has to be a *symbol*
(bound to a function value) rather than a function, so I think it's
better to write
(advice-remove 'context-coloring-colorize advice)
rather than
(advice-remove #'context-coloring-colorize advice)
IOW, I think #' only makes sense at those places where one could also
use a (lambda ...). It's largely philosophical, admittedly.
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [elpa] master e2ceef9 57/79: Prepend function symbols with octothorpes.
2015-06-14 2:59 ` [elpa] master e2ceef9 57/79: Prepend function symbols with octothorpes Stefan Monnier
@ 2015-06-18 8:59 ` Jackson Hamilton
2015-06-18 14:33 ` Kaushal
0 siblings, 1 reply; 4+ messages in thread
From: Jackson Hamilton @ 2015-06-18 8:59 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
[-- Attachment #1: Type: text/plain, Size: 879 bytes --]
I figured I could generate more spelling error related compiler errors if I
added the hash. By that motivation, I'd prefer to add them in as many
places as possible.
On Sat, Jun 13, 2015 at 7:59 PM, Stefan Monnier <monnier@iro.umontreal.ca>
wrote:
> > - (advice-remove 'context-coloring-colorize advice)
> > + (advice-remove #'context-coloring-colorize advice)
>
> Actually, the first argument of `advice-remove' has to be a *symbol*
> (bound to a function value) rather than a function, so I think it's
> better to write
>
> (advice-remove 'context-coloring-colorize advice)
> rather than
> (advice-remove #'context-coloring-colorize advice)
>
> IOW, I think #' only makes sense at those places where one could also
> use a (lambda ...). It's largely philosophical, admittedly.
>
>
> Stefan
>
[-- Attachment #2: Type: text/html, Size: 1373 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [elpa] master e2ceef9 57/79: Prepend function symbols with octothorpes.
2015-06-18 8:59 ` Jackson Hamilton
@ 2015-06-18 14:33 ` Kaushal
2015-06-19 3:18 ` Stefan Monnier
0 siblings, 1 reply; 4+ messages in thread
From: Kaushal @ 2015-06-18 14:33 UTC (permalink / raw)
To: Jackson Hamilton, Stefan Monnier; +Cc: emacs-devel
[-- Attachment #1: Type: text/plain, Size: 1133 bytes --]
Does that apply to advice-add too?
I use something like
(advice-add #'kill-word :after (lambda (arg) (modi/space-as-i-mean)))
On Thu, Jun 18, 2015 at 5:00 AM Jackson Hamilton <
jackson@jacksonrayhamilton.com> wrote:
> I figured I could generate more spelling error related compiler errors if
> I added the hash. By that motivation, I'd prefer to add them in as many
> places as possible.
>
> On Sat, Jun 13, 2015 at 7:59 PM, Stefan Monnier <monnier@iro.umontreal.ca>
> wrote:
>
>> > - (advice-remove 'context-coloring-colorize advice)
>> > + (advice-remove #'context-coloring-colorize advice)
>>
>> Actually, the first argument of `advice-remove' has to be a *symbol*
>> (bound to a function value) rather than a function, so I think it's
>> better to write
>>
>> (advice-remove 'context-coloring-colorize advice)
>> rather than
>> (advice-remove #'context-coloring-colorize advice)
>>
>> IOW, I think #' only makes sense at those places where one could also
>> use a (lambda ...). It's largely philosophical, admittedly.
>>
>>
>> Stefan
>>
>
>
[-- Attachment #2: Type: text/html, Size: 1908 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [elpa] master e2ceef9 57/79: Prepend function symbols with octothorpes.
2015-06-18 14:33 ` Kaushal
@ 2015-06-19 3:18 ` Stefan Monnier
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Monnier @ 2015-06-19 3:18 UTC (permalink / raw)
To: Kaushal; +Cc: emacs-devel, Jackson Hamilton
> Does that apply to advice-add too?
Yes. And to symbol-function, fset, defalias, fboundp,
indirect-function, ...
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-06-19 3:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20150614000510.19796.66727@vcs.savannah.gnu.org>
[not found] ` <E1Z3vQj-0005Je-79@vcs.savannah.gnu.org>
2015-06-14 2:59 ` [elpa] master e2ceef9 57/79: Prepend function symbols with octothorpes Stefan Monnier
2015-06-18 8:59 ` Jackson Hamilton
2015-06-18 14:33 ` Kaushal
2015-06-19 3:18 ` Stefan Monnier
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.