From: Kaushal Modi <kaushal.modi@gmail.com>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-org list <emacs-orgmode@gnu.org>
Subject: Re: Regression in #+include behavior [master]
Date: Wed, 21 Mar 2018 21:45:28 +0000 [thread overview]
Message-ID: <CAFyQvY0gUJ5Hd6ZvEHCNOizynQH9nU=P=whLi5Q8V8-DQpQDfw@mail.gmail.com> (raw)
In-Reply-To: <87sh8vb2tq.fsf@nicolasgoaziou.fr>
[-- Attachment #1: Type: text/plain, Size: 887 bytes --]
On Tue, Mar 20, 2018 at 3:53 AM Nicolas Goaziou <mail@nicolasgoaziou.fr>
wrote:
>
> The code was fixing links in the whole document, not only in the subtree
> you were including.
>
> The problem lay somewhere else in the file, in the "* Hey! I have a link
> [[https://example.org][here]] (Awesome!)" headline.
That was a pathological test case for ox-hugo :)
> There, `org-element-context' needed to check the headline, by (looking-at
> org-complex-heading-regexp). However, since the changes were happening in
> Fundamental mode, the regexp was not set. Hence the error.
>
Thanks! It makes sense now.
> So, the fix implements the following changes:
> - only modify links withing the included part of the document,
> - do not modify anything if includer and includee both live in the same
> directory,
> - switch to Org mode before proceeding with changes.
>
--
Kaushal Modi
[-- Attachment #2: Type: text/html, Size: 1642 bytes --]
prev parent reply other threads:[~2018-03-21 21:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-19 20:00 Regression in #+include behavior [master] Kaushal Modi
2018-03-19 20:03 ` Kaushal Modi
2018-03-19 22:52 ` Nicolas Goaziou
2018-03-20 3:27 ` Kaushal Modi
2018-03-20 7:53 ` Nicolas Goaziou
2018-03-21 21:45 ` Kaushal Modi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFyQvY0gUJ5Hd6ZvEHCNOizynQH9nU=P=whLi5Q8V8-DQpQDfw@mail.gmail.com' \
--to=kaushal.modi@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.