all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Kaushal Modi <kaushal.modi@gmail.com>
To: Dmitry Gutov <dgutov@yandex.ru>, Eli Zaretskii <eliz@gnu.org>
Cc: 27644@debbugs.gnu.org, John Wiegley <johnw@gnu.org>,
	Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#27644: 26.0.50; [PATCH] Add binding for vc-region-history
Date: Fri, 29 Sep 2017 16:43:02 +0000	[thread overview]
Message-ID: <CAFyQvY0_-s+-DEpdSAKcOgJtoyCTc8mE7FfdFWyOxzgLp4oA-w@mail.gmail.com> (raw)
In-Reply-To: <CAFyQvY04NJM3LCcuRyrp5NLsoQqWkbe5R5ECu26sJYJUB63rDg@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 277 bytes --]

On Fri, Sep 29, 2017 at 7:59 AM Kaushal Modi <kaushal.modi@gmail.com> wrote:

> I am of course fine with that. I'll send another patch with that change
> later today.
>

New patch attached that binds vc-region-history instead of
vc-insert-headers to C-x v h.
-- 

Kaushal Modi

[-- Attachment #1.2: Type: text/html, Size: 728 bytes --]

[-- Attachment #2: 0001-Bind-vc-region-history.patch --]
[-- Type: application/octet-stream, Size: 4438 bytes --]

From f857348ae5f9962924aa4d848ac0d9c65fc52140 Mon Sep 17 00:00:00 2001
From: Kaushal Modi <kaushal.modi@gmail.com>
Date: Fri, 29 Sep 2017 12:38:56 -0400
Subject: [PATCH] Bind vc-region-history

* lisp/vc/vc-hooks.el (vc-prefix-map): Bind `vc-region-history' to
  'C-x v h', which was earlier bound to
  `vc-insert-headers' (Bug#27644).
* doc/emacs/maintaining.texi (VC Change Log): Mention the new binding.
* doc/emacs/vc1-xtra.texi (Version Headers): Remove the association of
  'C-x v h' with `vc-insert-headers'.

<http://lists.gnu.org/archive/html/emacs-devel/2017-09/msg00957.html>
---
 doc/emacs/maintaining.texi | 11 ++++++-----
 doc/emacs/vc1-xtra.texi    | 11 +++++------
 etc/NEWS                   |  4 ++++
 lisp/vc/vc-hooks.el        |  2 +-
 4 files changed, 16 insertions(+), 12 deletions(-)

diff --git a/doc/emacs/maintaining.texi b/doc/emacs/maintaining.texi
index 39b7144594..af852203d7 100644
--- a/doc/emacs/maintaining.texi
+++ b/doc/emacs/maintaining.texi
@@ -1050,13 +1050,14 @@ VC Change Log
 entries} or @samp{Show unlimited entries} buttons at the end of the
 buffer.  However, RCS, SCCS, and CVS do not support this feature.
 
+@kindex C-x v h
 @findex vc-region-history
 A useful variant of examining changes is provided by the command
-@kbd{vc-region-history}, which shows a @file{*VC-history*} buffer with
-the history of changes to the region of the current file between point
-and the mark (@pxref{Mark}).  The history of changes includes the
-commit log messages and also the changes themselves in the Diff
-format.
+@kbd{vc-region-history} (by default bound to @kbd{C-x v h}), which shows
+a @file{*VC-history*} buffer with the history of changes to the region
+of the current file between point and the mark (@pxref{Mark}).  The
+history of changes includes the commit log messages and also the
+changes themselves in the Diff format.
 
 Invoke this command after marking the region of the current file in
 whose changes you are interested.  In the @file{*VC-history*} buffer
diff --git a/doc/emacs/vc1-xtra.texi b/doc/emacs/vc1-xtra.texi
index 58e4de027c..00498399c7 100644
--- a/doc/emacs/vc1-xtra.texi
+++ b/doc/emacs/vc1-xtra.texi
@@ -238,20 +238,19 @@ Version Headers
 than the RCS master file.  To inhibit using the version header this
 way, change the variable @code{vc-consult-headers} to @code{nil}.
 
-@kindex C-x v h
 @findex vc-insert-headers
 @vindex vc-@var{backend}-header
-  To insert a suitable header string into the current buffer, type
-@kbd{C-x v h} (@code{vc-insert-headers}).  This command works only on
+  To insert a suitable header string into the current buffer, use the
+command @kbd{M-x vc-insert-headers}.  This command works only on
 Subversion, CVS, RCS, and SCCS@.  The variable
 @code{vc-@var{backend}-header} contains the list of keywords to insert
 into the version header; for instance, CVS uses @code{vc-cvs-header},
 whose default value is @code{'("\$Id\$")}.  (The extra backslashes
 prevent the string constant from being interpreted as a header, if the
 Emacs Lisp file defining it is maintained with version control.)  The
-@kbd{C-x v h} command inserts each keyword in the list on a new line
-at point, surrounded by tabs, and inside comment delimiters if
-necessary.
+@code{vc-insert-headers} command inserts each keyword in the list on a
+new line at point, surrounded by tabs, and inside comment delimiters
+if necessary.
 
 @vindex vc-static-header-alist
   The variable @code{vc-static-header-alist} specifies further strings
diff --git a/etc/NEWS b/etc/NEWS
index 922dfbdc24..47904af7a4 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -1109,6 +1109,10 @@ See the 'vc-faces' customization group.
 *** 'vc-dir-mode' now binds 'vc-log-outgoing' to 'O'; and has various
 branch-related commands on a keymap bound to 'B'.
 
+---
+*** 'vc-region-history' is now bound to 'C-x v h', replacing the older
+'vc-insert-headers' binding.
+
 ** CC mode
 
 ---
diff --git a/lisp/vc/vc-hooks.el b/lisp/vc/vc-hooks.el
index 4c94280faf..99c8211ad5 100644
--- a/lisp/vc/vc-hooks.el
+++ b/lisp/vc/vc-hooks.el
@@ -882,7 +882,7 @@ vc-prefix-map
     (define-key map "d" 'vc-dir)
     (define-key map "g" 'vc-annotate)
     (define-key map "G" 'vc-ignore)
-    (define-key map "h" 'vc-insert-headers)
+    (define-key map "h" 'vc-region-history)
     (define-key map "i" 'vc-register)
     (define-key map "l" 'vc-print-log)
     (define-key map "L" 'vc-print-root-log)
-- 
2.14.1


  reply	other threads:[~2017-09-29 16:43 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-10 18:43 bug#27644: 26.0.50; [PATCH] Add binding for vc-region-history Kaushal Modi
2017-09-20 14:03 ` Kaushal Modi
2017-09-20 14:15   ` Eli Zaretskii
2017-09-21  3:01     ` Kaushal Modi
2017-09-28 18:23       ` Kaushal Modi
2017-09-29 11:54         ` Dmitry Gutov
2017-09-29 11:59           ` Kaushal Modi
2017-09-29 16:43             ` Kaushal Modi [this message]
2017-09-29 17:31             ` John Wiegley
2017-09-29 17:22           ` Eli Zaretskii
2017-09-29 17:39             ` Stefan Monnier
2017-09-29 18:16               ` Eli Zaretskii
2017-09-29 18:32                 ` Kaushal Modi
2017-09-30 14:03                   ` Dmitry Gutov
2017-09-30 14:12                     ` Kaushal Modi
2017-09-21 14:22     ` Dmitry Gutov
2017-09-21 14:41       ` Eli Zaretskii
2017-09-21 15:29         ` Dmitry Gutov
2017-09-21 20:39           ` Kaushal Modi
2017-09-22  3:15             ` Stefan Monnier
2017-09-22 13:51               ` Dmitry Gutov
2017-09-22 14:06                 ` Kaushal Modi
2017-09-22 14:03               ` Kaushal Modi
2017-09-23  8:06               ` Clément Pit-Claudel
2017-09-28 11:11                 ` Jostein Kjønigsen
2017-09-28 11:19                   ` Kaushal Modi
2017-09-28 16:59                     ` John Wiegley
2017-09-28 17:22                       ` Kaushal Modi
2017-09-28 17:24                         ` John Wiegley
2017-09-28 18:26                           ` Kaushal Modi
2017-09-28 19:59                           ` Stefan Monnier
2017-09-28 19:55                       ` Stefan Monnier
2017-09-29  9:37                         ` Robert Pluim
2017-09-29 19:50                           ` Paul Eggert
2017-09-29 19:55                             ` Kaushal Modi
2017-09-28 21:11                   ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFyQvY0_-s+-DEpdSAKcOgJtoyCTc8mE7FfdFWyOxzgLp4oA-w@mail.gmail.com \
    --to=kaushal.modi@gmail.com \
    --cc=27644@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    --cc=eliz@gnu.org \
    --cc=johnw@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.