all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Kaushal Modi <kaushal.modi@gmail.com>
To: Marcin Borkowski <mbork@amu.edu.pl>
Cc: vmon@riseup.net, alex@gnu.org, 18617@debbugs.gnu.org,
	david.hansen@physik.fu-berlin.de
Subject: bug#18617: [O] bug#18617: 24.3; loading simple-wiki-mode breaks org-mode
Date: Sun, 21 Feb 2016 09:26:58 -0500	[thread overview]
Message-ID: <CAFyQvY0Xg5pLrz+K0cS5E3XYGmjipq-wWo5Q3UDj_5xEcGG9Yw__6462.66183252937$1456064948$gmane$org@mail.gmail.com> (raw)
In-Reply-To: <CAFyQvY2a70uAuGNXUvOkhTn1eXYDhB_PkqsT=uCL9RARgqacOA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 759 bytes --]

A quick look at the code shows that it pollutes the namespace with
undeclared and un-let-bound variables like "tag" (and there could be more
like that).

If we investigate further, we might find a culprit like that that's causing
this problem.

(defun simple-wiki-get-tag ()
  (let (prompt)
    (if (and simple-wiki-tag-history (car simple-wiki-tag-history))
        (setq prompt (concat "Tag (" (car simple-wiki-tag-history) "): "))
      (setq prompt "Tag: "))
    (setq tag (completing-read prompt simple-wiki-tag-list nil nil ""
                               'simple-wiki-tag-history
                               (car simple-wiki-tag-history))))
  (unless (assoc tag simple-wiki-tag-list)
    (add-to-list 'simple-wiki-tag-list (cons tag nil)))
  tag)

[-- Attachment #2: Type: text/html, Size: 1396 bytes --]

  reply	other threads:[~2016-02-21 14:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-02 23:27 bug#18617: 24.3; loading simple-wiki-mode breaks org-mode vmon
2016-02-21 11:57 ` Marcin Borkowski
2016-02-21 11:57 ` Marcin Borkowski
2016-02-21 14:22   ` Kaushal Modi
2016-02-21 14:26     ` Kaushal Modi [this message]
2016-02-21 14:26     ` Kaushal Modi
2017-11-29  1:56       ` bug#18617: " Noam Postavsky
2017-11-29  1:56       ` bug#18617: [O] " Noam Postavsky
2016-02-21 14:22   ` Kaushal Modi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFyQvY0Xg5pLrz+K0cS5E3XYGmjipq-wWo5Q3UDj_5xEcGG9Yw__6462.66183252937$1456064948$gmane$org@mail.gmail.com' \
    --to=kaushal.modi@gmail.com \
    --cc=18617@debbugs.gnu.org \
    --cc=alex@gnu.org \
    --cc=david.hansen@physik.fu-berlin.de \
    --cc=mbork@amu.edu.pl \
    --cc=vmon@riseup.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.