From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Kaushal Modi Newsgroups: gmane.emacs.bugs Subject: bug#36157: 27.0.50; ediff-files does not work after lexical-binding was enabled for ediff Date: Mon, 10 Jun 2019 09:45:57 -0400 Message-ID: References: <878su9tv4x.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000008dcc4a058af8680d" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="190266"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36157@debbugs.gnu.org, Stefan Monnier To: Alex Branham Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 10 15:47:23 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1haKdu-000nM9-Mi for geb-bug-gnu-emacs@m.gmane.org; Mon, 10 Jun 2019 15:47:22 +0200 Original-Received: from localhost ([::1]:46670 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1haKdt-0006Tp-Bv for geb-bug-gnu-emacs@m.gmane.org; Mon, 10 Jun 2019 09:47:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50196) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1haKde-0006SL-JZ for bug-gnu-emacs@gnu.org; Mon, 10 Jun 2019 09:47:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1haKdc-0007V2-5w for bug-gnu-emacs@gnu.org; Mon, 10 Jun 2019 09:47:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42638) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1haKda-0007Tf-EP for bug-gnu-emacs@gnu.org; Mon, 10 Jun 2019 09:47:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1haKda-0002SQ-9y for bug-gnu-emacs@gnu.org; Mon, 10 Jun 2019 09:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Kaushal Modi Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Jun 2019 13:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36157 X-GNU-PR-Package: emacs Original-Received: via spool by 36157-submit@debbugs.gnu.org id=B36157.15601744059423 (code B ref 36157); Mon, 10 Jun 2019 13:47:02 +0000 Original-Received: (at 36157) by debbugs.gnu.org; 10 Jun 2019 13:46:45 +0000 Original-Received: from localhost ([127.0.0.1]:56182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1haKdI-0002Ru-UA for submit@debbugs.gnu.org; Mon, 10 Jun 2019 09:46:45 -0400 Original-Received: from mail-lj1-f172.google.com ([209.85.208.172]:44832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1haKdE-0002Rf-HJ for 36157@debbugs.gnu.org; Mon, 10 Jun 2019 09:46:43 -0400 Original-Received: by mail-lj1-f172.google.com with SMTP id k18so7983652ljc.11 for <36157@debbugs.gnu.org>; Mon, 10 Jun 2019 06:46:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mF7LG755Kzq1HmKbDzTYvdECqcoB0leASc0ur53jQpo=; b=I6vzAZnIUqIf76Mdiy3RpsVrvsqIcMfZ9yqPWKAn0/0UmHVeXK7coo9VEhQKjldt9R FggCxMEKdSZigZD1VbOljR+f0xKWkoHkeoB7ioPsEtU9gJyqAkqtgLaHx13yhDEDTC6i PC2T9BSXZ5aSF0IqOXfMn2fEpgnD3fPEgOoTsdUbFWoK2zr9/93IDM++BzmBGJnnyzQZ mMLXQxLCiOJ120+i7lhf+S0wOOIlx17cQPTPYLpAo4M28RVEZA1m3JxXSWjzoA32xCd4 7vylvVfjJUDV/EjhptVFTqAVlT/3KpWxnOxWp/f6Dh2J9dvf54jAJBXcXPwlIX45F5Ex mQzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mF7LG755Kzq1HmKbDzTYvdECqcoB0leASc0ur53jQpo=; b=npPj90DObkZ7h9QXsGCfY/W8HPmXwsIjcKNlhDw7lLvstWuTuQ0pWmdYLc0sV12O38 B4QxDE/N9/MPB3K0W3mpw0sd5p+Bq4dEVP/M2KazFZGk2EKoGQEbbKN/3S3a+rro5Gfj 93U85WhuTYmQA4/vyTRtq+ru+RojbZTjpy6uAQjcKapvyn6Q3JvXB73V6xbiIf7oXpPn dIm2E2C0nZnegfpc2eEM7Quc7jkunvwZsIN4v4hBEjJ2Mssv/eGaO7WTdWjWZeefDSRg jQ+nUt82Dor4XCvbv4KedzS44oxl2+EwkgWIQ5ahG7Y0H1X3WkuqUr1ffOusaiT8dm5I 3FgA== X-Gm-Message-State: APjAAAXpzvqdjcWaeTEhxDlsumivm1xK68h2zMNpI82oFirJ8VHAJTo0 d0zocCbM8eFRtaicb0pkLS5Gdl5KVLAo4PRk34M= X-Google-Smtp-Source: APXvYqzBRT+/yqwZ08eY4MJ3ZrKlvgW4SNy82DfVA7V91KXbH6bFu8j8UWacmGxC251QqMYmIqjkRyfYUOo27X/obHo= X-Received: by 2002:a2e:9dc1:: with SMTP id x1mr10994424ljj.0.1560174394197; Mon, 10 Jun 2019 06:46:34 -0700 (PDT) In-Reply-To: <878su9tv4x.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160327 Archived-At: --0000000000008dcc4a058af8680d Content-Type: text/plain; charset="UTF-8" Hi Alex, I have reverted that patch in my local emacs build. But I am copying Stefan and Eli here for ideas so that it doesn't need to be reverted on master. -- Kaushal Modi On Mon, Jun 10, 2019 at 9:41 AM Alex Branham wrote: > > On Sun 09 Jun 2019 at 22:21, Kaushal Modi wrote: > > > It seems like properly enabling lexical binding in ediff will be a bit > > tricky. > > > > If you look at the code of ediff-find-file, you will see the use of > > `symbol-value' everywhere. > > Indeed, it looks like portions of ediff expect symbols like file-A and > file-B to be dynamically bound, but also passes them through as > arguments to functions. I'm not sure what the best way to deal with this > is, since if we just mark them as special the lexical binding will > shadow the global binding anyway. > > In the meantime, feel free to revert that patch if its causing issues. > > Alex > --0000000000008dcc4a058af8680d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Alex,

I have reverted tha= t patch in my local emacs build.

But I am copying = Stefan and Eli here for ideas so that it doesn't need to be reverted on= master.
<= br>--
Kaushal Modi


On Mon, Jun 10, 2019 at 9:41 AM = Alex Branham <alex.branham@gma= il.com> wrote:

On Sun 09 Jun 2019 at 22:21, Kaushal Modi <kaushal.modi@gmail.com> wrote:

> It seems like properly enabling lexical binding in ediff will be a bit=
> tricky.
>
> If you look at the code of ediff-find-file, you will see the use of > `symbol-value' everywhere.

Indeed, it looks like portions of ediff expect symbols like file-A and
file-B to be dynamically bound, but also passes them through as
arguments to functions. I'm not sure what the best way to deal with thi= s
is, since if we just mark them as special the lexical binding will
shadow the global binding anyway.

In the meantime, feel free to revert that patch if its causing issues.

Alex
--0000000000008dcc4a058af8680d--