From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Matthias Clasen Newsgroups: gmane.emacs.bugs Subject: bug#23144: shrinking windows with gtk 3.20 Date: Sat, 2 Apr 2016 13:27:25 -0400 Message-ID: References: <56FF0C5B.1020201@cs.ucla.edu> <83r3eosdde.fsf@gnu.org> <8360w0rp10.fsf@gnu.org> <56FFEDF8.5030704@gmx.at> <834mbkrn4o.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1459618099 1065 80.91.229.3 (2 Apr 2016 17:28:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 2 Apr 2016 17:28:19 +0000 (UTC) Cc: Paul Eggert , 23144@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 02 19:28:10 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1amPLG-0001Mx-8e for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Apr 2016 19:28:10 +0200 Original-Received: from localhost ([::1]:50392 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amPLF-0007iK-IH for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Apr 2016 13:28:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34231) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amPLB-0007i7-O5 for bug-gnu-emacs@gnu.org; Sat, 02 Apr 2016 13:28:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1amPL8-0007b5-IK for bug-gnu-emacs@gnu.org; Sat, 02 Apr 2016 13:28:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51921) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amPL8-0007b1-En for bug-gnu-emacs@gnu.org; Sat, 02 Apr 2016 13:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1amPL8-0004eM-Am for bug-gnu-emacs@gnu.org; Sat, 02 Apr 2016 13:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Matthias Clasen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Apr 2016 17:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23144 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23144-submit@debbugs.gnu.org id=B23144.145961805317835 (code B ref 23144); Sat, 02 Apr 2016 17:28:02 +0000 Original-Received: (at 23144) by debbugs.gnu.org; 2 Apr 2016 17:27:33 +0000 Original-Received: from localhost ([127.0.0.1]:49048 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1amPKe-0004db-NG for submit@debbugs.gnu.org; Sat, 02 Apr 2016 13:27:32 -0400 Original-Received: from mail-oi0-f51.google.com ([209.85.218.51]:35817) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1amPKc-0004dN-OB for 23144@debbugs.gnu.org; Sat, 02 Apr 2016 13:27:31 -0400 Original-Received: by mail-oi0-f51.google.com with SMTP id p188so114420696oih.2 for <23144@debbugs.gnu.org>; Sat, 02 Apr 2016 10:27:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=FQDHoJgvEAAP3K2gVxtWTm50KYvnsWpxeqTy+AIwbKs=; b=BBdhrc1omDTVoPenobHZ/q/+uKk2S7tZc8eC/DZYpHLjSuCBLVDS0mNdB+nKMNK6dr mqaB9UXJO1KKAO8/EDq3i1Oqj/3kcTTIQAHXpi+QNcgGO8LzgSH8xwIHFEBbYuxWUISK +o+ejPDbAOLPWS3UHyUHGnRcAlC4RKnduF9XGI6mtaJ1JiFnA6CyjGjTDwBLYOn2WjYL zi78cze/JR2TV+EfZsF3A3NY8srGdWZQLOPwmROKXNt7r7gEHMGJxz+nHBBK5nZw//EK 8dPspQrd6cZDnhUbyji0JXrjXa0C+mum8ZSvfAx4oEElwduIlbfjnlFrOF0R2kvohvDJ wAzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=FQDHoJgvEAAP3K2gVxtWTm50KYvnsWpxeqTy+AIwbKs=; b=e1g/uEOR8gB91N1lF4+GSO8i/8a7D/yEVUrTtzg47x+bheLIVq/v92CjIFCXFAcMgg ZFpF402OiU05j/TvkPNUY5HlCIhsi4JWMFPMQH+tLF2htbPYbCqPILeL+5u3Ydy9o3eI 1+hiAqeD1t5+4MziKPoZeDR4Kp6bJNGSgao442EYkP5hvOpPz4pbrcKcXsz2tci48IFf ZZBEu/CRwQoK5GKVxlA042nIYcNQl5CmNkETPxkZw7JdI7GQeGs7jc4w6yq+d1+HeLYU xOZ0Kl+zXYTsskVxPoSBuT+asGMyGxgFv5ijzGtdtu3fC5aOp6LJHKafqt7hNEteaXGh zpsw== X-Gm-Message-State: AD7BkJIu7acFdOhimztJlUdz3jipDReWijU3nza1IQ4LWWnYa7QF4UUG6RR7xYmmWBXwSrqS5A7Qf5j0+G964Q== X-Received: by 10.202.83.75 with SMTP id h72mr3959555oib.121.1459618045296; Sat, 02 Apr 2016 10:27:25 -0700 (PDT) Original-Received: by 10.157.18.203 with HTTP; Sat, 2 Apr 2016 10:27:25 -0700 (PDT) In-Reply-To: <834mbkrn4o.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115878 Archived-At: On Sat, Apr 2, 2016 at 12:28 PM, Eli Zaretskii wrote: >> Date: Sat, 02 Apr 2016 18:06:16 +0200 >> From: martin rudalics >> CC: 23144@debbugs.gnu.org, eggert@cs.ucla.edu >> >> In emacs-25 either use something like >> >> #if !GTK_CHECK_VERSION (3, 20, 0)) >> xg_frame_resized (f, -1, -1); >> #endif > > I hope we do that on master. If not, we should. There's no reason > not to continue calling xg_frame_resized with older versions of GTK, > as it works there. > > I'm wary of doing this in Emacs 25.1. > >> or, as Matthias proposed, in xg_frame_resized write >> >> if (pixelwidth == -1 && pixelheight == -1) >> { >> if (FRAME_GTK_WIDGET (f) && gtk_widget_get_mapped (FRAME_GTK_WIDGET (f))) >> { >> gdk_window_get_geometry (gtk_widget_get_window (FRAME_GTK_WIDGET (f)), >> 0, 0, &pixelwidth, &pixelheight); >> if (pixelwidth <= 1 || pixelheight <= 1) >> return; >> } >> else >> return; >> } > > Do we understand the effect of this? It effectively makes the > xg_frame_resized call a no-op, but I very much doubt that this call > was added there with no good reason. Does the history of this > addition, including any related discussions, teach us something about > the reason? Yes, this is what I would have suggested as alternative patch for emacs 25. It only disregards the return value of gdk_window_get_geometry if it is still the initial value of 1,1 - thats clearly not a useful size for an emacs window...