all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Matthias Clasen <matthias.clasen@gmail.com>
To: 23144@debbugs.gnu.org
Subject: bug#23144: shrinking windows with gtk 3.20
Date: Mon, 28 Mar 2016 16:52:47 -0400	[thread overview]
Message-ID: <CAFwd_vAFscqBnhg9Bbgi7XuaXUuv=p3c=GXz33ENftKDBFCmVA@mail.gmail.com> (raw)

We've observed that after

https://git.gnome.org/browse/gtk+/commit/?id=67ab00e01ec06d7b05a82c3d80b235ac6c4abfd2

emacs windows shrink to a small height, after initially appearing with
the expected size. For that reason, I have reverted to commit in the
stable gtk 3.20 branch.

But after looking a bit closer, I find that what emacs does is really
unsupportable: It handles X events behind GTK+'s back, and upon seeing
a map notify, it calls xg_frame_resized with -1, -1 for width and
height, which makes it call gdk_window_get_geometry to obtain the
current size. But at that point (before GTK+ has handled the map
notify), the function still returns the initial values of 1, 1, which
then leads eventually to a call of gtk_window_resize() with the small
height that we're seeing the window shrink to.

Therefore, I will bring back the reverted change in GTK+ master.

Possible workarounds/fixes in the emacs code:

1) Recognize when gdk_window_get_geometry returns the initial size
(1,1) and silently return as if the window was unmapped.

2) Just drop the xg_frame_resized call on MapNotify. Omitting it
doesn't have any noticeable negative consequences.





             reply	other threads:[~2016-03-28 20:52 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-28 20:52 Matthias Clasen [this message]
2016-03-29 15:18 ` bug#23144: shrinking windows with gtk 3.20 martin rudalics
2016-03-29 16:02   ` Eli Zaretskii
2016-03-29 17:20     ` martin rudalics
2016-03-31 16:09   ` John Wiegley
2016-04-01  7:48     ` martin rudalics
2016-04-01  9:46       ` Eli Zaretskii
2016-04-02  0:03 ` Paul Eggert
2016-04-02  7:01   ` Eli Zaretskii
2016-04-02 15:19     ` Matthias Clasen
2016-04-02 15:47       ` Eli Zaretskii
2016-04-02 16:06         ` martin rudalics
2016-04-02 16:28           ` Eli Zaretskii
2016-04-02 17:27             ` Matthias Clasen
2016-04-02 17:32               ` Eli Zaretskii
2016-04-02 23:20                 ` Matthias Clasen
2016-04-03  2:36                   ` Eli Zaretskii
2016-05-16  6:53 ` Paul Eggert
2016-05-16  8:21   ` martin rudalics
2016-05-16 15:53   ` Eli Zaretskii
2016-05-16 17:11     ` Paul Eggert
2017-03-24 13:01 ` Ken Brown
2017-03-24 13:24   ` martin rudalics
2017-03-24 13:38     ` Ken Brown
2017-03-24 18:52       ` martin rudalics
2017-03-24 13:35   ` Eli Zaretskii
2017-03-24 14:08     ` Ken Brown
2017-03-24 14:27       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFwd_vAFscqBnhg9Bbgi7XuaXUuv=p3c=GXz33ENftKDBFCmVA@mail.gmail.com' \
    --to=matthias.clasen@gmail.com \
    --cc=23144@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.