From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Aaron S. Hawley" Newsgroups: gmane.emacs.devel Subject: Re: bug: "C-x z" ("repeat") no longer works correctly with M-x Date: Tue, 29 May 2012 14:45:48 -0400 Message-ID: References: <87396ylx5m.fsf@catnip.gol.com> <87pq9ndq0n.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 X-Trace: dough.gmane.org 1338317169 25896 80.91.229.3 (29 May 2012 18:46:09 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 29 May 2012 18:46:09 +0000 (UTC) Cc: emacs-devel@gnu.org, Miles Bader To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 29 20:46:08 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SZRQl-0005Wj-WF for ged-emacs-devel@m.gmane.org; Tue, 29 May 2012 20:46:08 +0200 Original-Received: from localhost ([::1]:46182 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZRQl-0005hY-R5 for ged-emacs-devel@m.gmane.org; Tue, 29 May 2012 14:46:07 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:56650) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZRQj-0005hA-9k for emacs-devel@gnu.org; Tue, 29 May 2012 14:46:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SZRQh-00031w-Ka for emacs-devel@gnu.org; Tue, 29 May 2012 14:46:04 -0400 Original-Received: from mail-bk0-f41.google.com ([209.85.214.41]:56279) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZRQX-0002sm-6w; Tue, 29 May 2012 14:45:53 -0400 Original-Received: by bkcjm19 with SMTP id jm19so4127439bkc.0 for ; Tue, 29 May 2012 11:45:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=QiBwXJvusWHZ42EH8B38S1scQ6XxrdKc1t+WqfvhPvk=; b=nHcpR/diUfYViuumyyCOrT+in5tgjC785TTrmyOGYIL1DOhQfdJBS6kGDy7XZDxncx QAPnzSzXJYTGELp1gVEiz8+zeuMMqWydE9eaefyNv0WITxqFvqlufiEnL7EBjMooncU4 HxjYz6aXIWVLzTpREFsTmJC7pBv0cL20chc/Dso+AYL42fvmKr8dJMPK2w+nFIlKw5q/ e699ttht0+pBRiQUsLovuHDlq41oDiK7354hnROZbs6ZguHRttAB22HZ902ioJIkDJx8 THRv9O4MIKgn0Gh1RI7TiW41TpRgQxxvFBBcxOliw9yM/tQM3MTeXzxw7JCwibzabjhe FlVQ== Original-Received: by 10.204.152.22 with SMTP id e22mr7115784bkw.8.1338317148438; Tue, 29 May 2012 11:45:48 -0700 (PDT) Original-Received: by 10.204.35.145 with HTTP; Tue, 29 May 2012 11:45:48 -0700 (PDT) In-Reply-To: <87pq9ndq0n.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.214.41 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:150682 Archived-At: On 5/29/12, Chong Yidong wrote: > Miles Bader writes: > >> It used to be (up until fairly recently, dunno the exact point at >> which it changed) that "C-x z" would correctly repeat the previous >> extended command; e.g. if you entered "M-x pwd RET", and then "C-x z", >> the latter would re-invoke "pwd". This was very useful. >> >> Now it no longer does this -- instead it just repeats "M-x", prompting >> for a command. This is obviously far less useful behavior... > > This is due to the reimplementation of execute-extended-command in > r108080. Aaron, could you please look into a fix? Thanks. I had given a more literal translation of the C command to the gnu-emacs-sources mailing list back in March. Stefan and I discussed it but hadn't run across this issue with repeat. He later made some modifications to my submission and committed it in May. I have only now run it and can confirm this bug with repeat. I'm not sure what's causing it though, but found the following fixes it. Again, I'm not sure why. Nor am I sure if it's a wholly appropriate fix. --- simple.el 2012-05-29 07:21:45.000000000 -0400 +++ simple.el 2012-05-29 14:30:41.942777900 -0400 @@ -1373,7 +1373,7 @@ Noninteractively, the argument PREFIXARG is the prefix argument to give to the command you invoke, if it asks for an argument." - (interactive (list current-prefix-arg (read-extended-command))) + (interactive "P") ;; Emacs<24 calling-convention was with a single `prefixarg' argument. (if (null command-name) (setq command-name (read-extended-command))) (let* ((function (and (stringp command-name) (intern-soft command-name)))