From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Aaron S. Hawley" Newsgroups: gmane.emacs.bugs Subject: bug#14824: 24.3.50; Regression: problem with undo in Mail mode Date: Tue, 9 Jul 2013 10:20:48 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 X-Trace: ger.gmane.org 1373382404 24818 80.91.229.3 (9 Jul 2013 15:06:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 9 Jul 2013 15:06:44 +0000 (UTC) Cc: 14824@debbugs.gnu.org, rms@gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 09 17:06:44 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UwZV1-0000Pd-Cc for geb-bug-gnu-emacs@m.gmane.org; Tue, 09 Jul 2013 17:06:39 +0200 Original-Received: from localhost ([::1]:48153 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwZV0-0006Yx-Od for geb-bug-gnu-emacs@m.gmane.org; Tue, 09 Jul 2013 11:06:38 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37874) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwYmw-0007Em-7V for bug-gnu-emacs@gnu.org; Tue, 09 Jul 2013 10:21:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UwYmt-0003Q8-4O for bug-gnu-emacs@gnu.org; Tue, 09 Jul 2013 10:21:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:48340) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwYmt-0003Q3-10 for bug-gnu-emacs@gnu.org; Tue, 09 Jul 2013 10:21:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1UwYms-0000qG-Ho for bug-gnu-emacs@gnu.org; Tue, 09 Jul 2013 10:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Aaron S. Hawley" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jul 2013 14:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14824 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14824-submit@debbugs.gnu.org id=B14824.13733796573220 (code B ref 14824); Tue, 09 Jul 2013 14:21:02 +0000 Original-Received: (at 14824) by debbugs.gnu.org; 9 Jul 2013 14:20:57 +0000 Original-Received: from localhost ([127.0.0.1]:42656 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwYmn-0000pn-1W for submit@debbugs.gnu.org; Tue, 09 Jul 2013 10:20:57 -0400 Original-Received: from mail-pb0-f49.google.com ([209.85.160.49]:61333) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UwYmk-0000pX-OS for 14824@debbugs.gnu.org; Tue, 09 Jul 2013 10:20:55 -0400 Original-Received: by mail-pb0-f49.google.com with SMTP id jt11so5528802pbb.36 for <14824@debbugs.gnu.org>; Tue, 09 Jul 2013 07:20:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Z7c/voKCVMat4PhRXFiNwoxkC76eOjx329pLudp+Tww=; b=gyWXqwA3TesbNzV/SDFDQsvH3J/WVlKuE/9MAPnHHgY9r5lHKR4opUS/unj/uXXWn6 ARlZnmP56Du2QJ+Jxo+JwSpCjo5rau5ylgGD6UpbnylEuIXb1qloidjPyycFXUGFEKFc c59Nqm4gs1vSxs0LzmNKr31KFY92JAFYC5/4/rqxFLos4MGuVafJCW6Vf4OCoVnjv+ey Du6bRuEZBwTG38xJlrTPuSkkKGotMClxmemEYBE+K5QCbTqVdmy5UKMo2rIX66zRi0m2 ReYh2Z7wjy+27maWojxNfKdf7PWfXp/aquF6KcYTwsklyT4lyEY6uxOQXH4EigyrVrxC wEsQ== X-Received: by 10.68.138.131 with SMTP id qq3mr26835159pbb.10.1373379648896; Tue, 09 Jul 2013 07:20:48 -0700 (PDT) Original-Received: by 10.70.98.235 with HTTP; Tue, 9 Jul 2013 07:20:48 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:76142 Archived-At: > A shot in the dark: it might be due to the finer timestamps (since > these were introduced fairly recently, whereas Aaron's code is actually > pretty old (even tho it was installed only recently)). That is a good theory. I remember studying the time precision changes by Paul Eggert from last year. I think these were them: http://bzr.savannah.gnu.org/lh/emacs/trunk/revision/108687 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9000 The changes to time values in Emacs were a concern of mine when the new Lisp version of undo was finally merged to trunk. I don't have an Emacs trunk build at the moment, so I can't confirm. It would be this section of the new undo code, though: http://bzr.savannah.gnu.org/lh/emacs/trunk/annotate/113327/lisp/simple.el#L2132 I am a little surprised this was broken in trunk for the last 6 months, and nobody had noticed. The automated test suite could catch this by adding a line containing (should (not (buffer-modified-p))) to one of the unit tests.