all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Aaron S. Hawley" <aaron.s.hawley@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 14824@debbugs.gnu.org, rms@gnu.org
Subject: bug#14824: 24.3.50; Regression: problem with undo in Mail mode
Date: Tue, 9 Jul 2013 10:20:48 -0400	[thread overview]
Message-ID: <CAFw1JJ4peW14S4iJ5KNZgnbnQRCO_5EP_WACRkdCf9_Mhy_b+g@mail.gmail.com> (raw)
In-Reply-To: <jwvfvvokta4.fsf-monnier+emacs@gnu.org>

> A shot in the dark: it might be due to the finer timestamps (since
> these were introduced fairly recently, whereas Aaron's code is actually
> pretty old (even tho it was installed only recently)).

That is a good theory.  I remember studying the time precision changes
by Paul Eggert from last year.  I think these were them:

http://bzr.savannah.gnu.org/lh/emacs/trunk/revision/108687
http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9000

The changes to time values in Emacs were a concern of mine when the
new Lisp version of undo was finally merged to trunk.  I don't have an
Emacs trunk build at the moment, so I can't confirm.  It would be this
section of the new undo code, though:

http://bzr.savannah.gnu.org/lh/emacs/trunk/annotate/113327/lisp/simple.el#L2132

I am a little surprised this was broken in trunk for the last 6
months, and nobody had noticed.  The automated test suite could catch
this by adding a line containing (should (not (buffer-modified-p))) to
one of the unit tests.





  reply	other threads:[~2013-07-09 14:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-08 17:29 bug#14824: 24.3.50; Regression: problem with undo in Mail mode Richard Stallman
2013-07-08 17:47 ` Glenn Morris
2013-07-09  0:46   ` Glenn Morris
2013-07-09  8:56     ` Stefan Monnier
2013-07-09 14:20       ` Aaron S. Hawley [this message]
2013-07-09 15:59         ` Glenn Morris
2013-07-09 17:58           ` Glenn Morris
2013-07-09 18:20             ` Glenn Morris
2013-07-09 18:26               ` Glenn Morris
2013-07-10  6:29                 ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFw1JJ4peW14S4iJ5KNZgnbnQRCO_5EP_WACRkdCf9_Mhy_b+g@mail.gmail.com \
    --to=aaron.s.hawley@gmail.com \
    --cc=14824@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.