From: "Aaron S. Hawley" <aaron.s.hawley@gmail.com>
To: 22822@debbugs.gnu.org
Subject: bug#22822: Use MKDIR_P instead of mkdir --parents in test/Makefile.in
Date: Fri, 26 Feb 2016 11:55:54 -0500 [thread overview]
Message-ID: <CAFw1JJ4WVduuVTfz5EBEgkWCuji74_3AE=Kjv58XXUQ5hFcWMA@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 800 bytes --]
Some platforms don't support the long options for mkdir. Seems there
is a variable, MKDIR_P, set by Autoconf that is used elsewhere in the
Emacs build system that could be used instead. Patch is attached and
quoted below.
Thanks,
Aaron
---
test/Makefile.in | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/test/Makefile.in b/test/Makefile.in
index b5954df..beb3ff9 100644
--- a/test/Makefile.in
+++ b/test/Makefile.in
@@ -29,6 +29,7 @@
### Code:
SHELL = @SHELL@
+MKDIR_P = @MKDIR_P@
srcdir = @srcdir@
VPATH = $(srcdir)
@@ -110,7 +111,7 @@ endif
fi; \
echo Testing $$loadfile; \
stat=OK ; \
- mkdir --parents $(dir $@) ; \
+ ${MKDIR_P} $(dir $@) ; \
$(emacs) -l ert -l $$loadfile \
--eval "(ert-run-tests-batch-and-exit ${SELECTOR_ACTUAL})" ${WRITE_LOG}
--
[-- Attachment #2: 0001-Use-MKDIR_P-instead-of-mkdir-parents.patch --]
[-- Type: application/octet-stream, Size: 896 bytes --]
From ca62ed00537d29cfd52f72765fff8bd7ca731e4d Mon Sep 17 00:00:00 2001
From: "Aaron S. Hawley" <aaron.s.hawley@gmail.com>
Date: Fri, 26 Feb 2016 11:45:45 -0500
Subject: [PATCH] Use MKDIR_P instead of mkdir --parents
* test/Makefile.in (MKDIR_P): New variable.
(%.log): Use MKDIR_P instead of mkdir --parents
---
test/Makefile.in | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/test/Makefile.in b/test/Makefile.in
index b5954df..beb3ff9 100644
--- a/test/Makefile.in
+++ b/test/Makefile.in
@@ -29,6 +29,7 @@
### Code:
SHELL = @SHELL@
+MKDIR_P = @MKDIR_P@
srcdir = @srcdir@
VPATH = $(srcdir)
@@ -110,7 +111,7 @@ endif
fi; \
echo Testing $$loadfile; \
stat=OK ; \
- mkdir --parents $(dir $@) ; \
+ ${MKDIR_P} $(dir $@) ; \
$(emacs) -l ert -l $$loadfile \
--eval "(ert-run-tests-batch-and-exit ${SELECTOR_ACTUAL})" ${WRITE_LOG}
--
2.3.0 (Apple Git-54)
next reply other threads:[~2016-02-26 16:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 16:55 Aaron S. Hawley [this message]
2016-02-28 3:02 ` bug#22822: Use MKDIR_P instead of mkdir --parents in test/Makefile.in Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFw1JJ4WVduuVTfz5EBEgkWCuji74_3AE=Kjv58XXUQ5hFcWMA@mail.gmail.com' \
--to=aaron.s.hawley@gmail.com \
--cc=22822@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.