From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Frank P Esposito Newsgroups: gmane.emacs.bugs Subject: bug#14409: emacs 24.3 -- windows Date: Thu, 30 May 2013 23:26:13 -0400 Message-ID: References: <83vc6j4hgr.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=e89a8fb1ebe452ffe904ddfb2d43 X-Trace: ger.gmane.org 1369970800 23061 80.91.229.3 (31 May 2013 03:26:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 31 May 2013 03:26:40 +0000 (UTC) Cc: 14409@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 31 05:26:41 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UiFzE-0005ED-GB for geb-bug-gnu-emacs@m.gmane.org; Fri, 31 May 2013 05:26:40 +0200 Original-Received: from localhost ([::1]:55412 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UiFzD-0007Tq-4D for geb-bug-gnu-emacs@m.gmane.org; Thu, 30 May 2013 23:26:39 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42344) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UiFz6-0007TW-So for bug-gnu-emacs@gnu.org; Thu, 30 May 2013 23:26:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UiFz3-00046t-Pt for bug-gnu-emacs@gnu.org; Thu, 30 May 2013 23:26:32 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55181) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UiFz3-00046p-MX for bug-gnu-emacs@gnu.org; Thu, 30 May 2013 23:26:29 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UiG0X-0001l4-Rt for bug-gnu-emacs@gnu.org; Thu, 30 May 2013 23:28:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Frank P Esposito Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 31 May 2013 03:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14409 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14409-submit@debbugs.gnu.org id=B14409.13699708756735 (code B ref 14409); Fri, 31 May 2013 03:28:01 +0000 Original-Received: (at 14409) by debbugs.gnu.org; 31 May 2013 03:27:55 +0000 Original-Received: from localhost ([127.0.0.1]:43539 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UiG0Q-0001ka-Iq for submit@debbugs.gnu.org; Thu, 30 May 2013 23:27:55 -0400 Original-Received: from mail-ob0-f175.google.com ([209.85.214.175]:34168) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UiG0O-0001kC-DL for 14409@debbugs.gnu.org; Thu, 30 May 2013 23:27:53 -0400 Original-Received: by mail-ob0-f175.google.com with SMTP id xn12so2088976obc.34 for <14409@debbugs.gnu.org>; Thu, 30 May 2013 20:26:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=MhTrr/Y7qt4Qiup69ChmlSdya69oV4wxM7YavYtYDQ4=; b=F5wZU2N18zx+J4+tWk/dpwPz1Vaq8W1gH7lY/qm1weytubY4y8oOTxEzYk8UhY+G1l nrcpg7l6DujljuU78w57HsORRNfeto9bgHKMH8PDC1Do5WcWnZ6Ypp2i3T5n9vIXj5Rh Ip5UCB9Z9SuX52GRKzPT2Nv3FP+lnj9nD4vQO2ui31PRK+pW2og4dK8bdrxAiM51cG0F 06LuZHIluzMeOKOgEpZ+etg1evcHsJkeBJHQu+fxyi/WDPGDtAmLUVxA+D1dOf4a+Ime kVZGqFnk795o8CsgM/W6euu6wafaazYpeDDotIqxQwaOvCCZ1JYfYEix308ZMG5q813I IqsA== X-Received: by 10.182.129.101 with SMTP id nv5mr5103436obb.56.1369970773784; Thu, 30 May 2013 20:26:13 -0700 (PDT) Original-Received: by 10.182.187.104 with HTTP; Thu, 30 May 2013 20:26:13 -0700 (PDT) In-Reply-To: <83vc6j4hgr.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:74696 Archived-At: --e89a8fb1ebe452ffe904ddfb2d43 Content-Type: text/plain; charset=UTF-8 Hello -- Were you able to debug the expanded macros with the i-files I sent to you? here is a link to the i-file (in a zip) http://db.tt/VYWpHtIP Frank Esposito On Thu, May 16, 2013 at 1:33 AM, Eli Zaretskii wrote: > > Date: Wed, 15 May 2013 22:31:48 -0400 > > From: Frank P Esposito > > > > You need to fix the code, or update the readme / install (text) files to > > note that this version of emacs DOES NOT COMPILE with versions of visual > > studio that ARE NOT C99 compliant. > > There was no intent to break compilation with Studio 2003. It's just > that the number of people who use that seems to be vanishingly small, > and in particular none of them tried the pretest version and reported > problems. > > > there are references to defines that are part of stdint.h (C99) -- you > > need to define them or not use them > > We have a replacement stdint.h in nt/inc. If something is missing > from there, please tell what that is. > > > it seems that there is new code in "charset.c charset.h" that have very > > complex macros that are imbedded in other complex macros > > that expand to something like (see below) which is impossible to debug > -- > > this is causing the error > > > > coding.c > > coding.c(2604) : error C2065: 'value' : undeclared identifier > > coding.c(2604) : error C2143: syntax error : missing ':' before ')' > > coding.c(2604) : error C2059: syntax error : ')' > > coding.c(2604) : error C2059: syntax error : ')' > > coding.c(2604) : error C2059: syntax error : ')' > > coding.c(2604) : fatal error C1013: compiler limit : too many open > > parentheses > > This is about CODING_CHAR_CHARSET, right? But then I don't understand > the expansion you are showing, which starts with this: > > > charset = (charset_table + (preferred_charset_id)); > > do { ptrdiff_t offset; charset_map_loaded = 0; result = > (((((sizeof > > ((c) + 0)) > (sizeof ((0x80) + 0)) ? (sizeof ((c) + 0)) : (sizeof > ((0x80) + > > 0))) <= sizeof (unsigned) ? ((c) + (unsigned) 0) < ((0x80) + (unsigned) > 0) > > : ((c) + (unsigned long) 0) < ((0x80) + (unsigned long) 0)) && > > I see no "result = ...", or anything that could expand into it, the > definition of CODING_CHAR_CHARSET. What am I missing? > > > I would be willing work to get this cleaned up -- VC 7.1 supports inline > > functions > > Please do, and thanks. Just one request: try to keep the > MSVC-specific stuff separate, preferably somewhere under the nt/ > directory (e.g., nt/inc/ms-w32.h) or in a clearly #ifdef'ed section at > the beginning of a .c or .h file in src/, so that these changes don't > make reading of the code harder. > > Thanks. > --e89a8fb1ebe452ffe904ddfb2d43 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hello --=C2=A0

Were you able to debug the expanded macro= s with the i-files I sent to you?=C2=A0

here is a = link to the i-file (in a zip)=C2=A0


Frank Esposito=C2=A0



<= div class=3D"gmail_quote">On Thu, May 16, 2013 at 1:33 AM, Eli Zaretskii <eliz@= gnu.org> wrote:
> Date: Wed, 15 May 2013 22:31:48 -0400 > From: Frank P Esposito <fpe= sposito@gmail.com>
>
> You need to fix the code, or =C2=A0update the readme / install (text) = files to
> note that this version of emacs =C2=A0DOES NOT COMPILE with versions o= f visual
> studio that ARE NOT C99 compliant.

There was no intent to break compilation with Studio 2003. =C2=A0It's j= ust
that the number of people who use that seems to be vanishingly small,
and in particular none of them tried the pretest version and reported
problems.

> there are references to =C2=A0defines that are =C2=A0part of stdint.h = (C99) -- =C2=A0you
> need to define them or not use them

We have a replacement stdint.h in nt/inc. =C2=A0If something is missing
from there, please tell what that is.

> it seems that there is new code in =C2=A0"charset.c charset.h&quo= t; that have very
> complex macros that are imbedded in other complex macros
> that expand to something =C2=A0like (see below) =C2=A0which is impossi= ble to debug --
> this is causing the error
>
> coding.c
> coding.c(2604) : error C2065: 'value' : undeclared identifier<= br> > coding.c(2604) : error C2143: syntax error : missing ':' befor= e ')'
> coding.c(2604) : error C2059: syntax error : ')'
> coding.c(2604) : error C2059: syntax error : ')'
> coding.c(2604) : error C2059: syntax error : ')'
> coding.c(2604) : fatal error C1013: compiler limit : too many open
> parentheses

This is about CODING_CHAR_CHARSET, right? =C2=A0But then I don't unders= tand
the expansion you are showing, which starts with this:

> =C2=A0 =C2=A0 =C2=A0 =C2=A0 charset =3D (charset_table + (preferred_ch= arset_id));
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 do { ptrdiff_t offset; charset_map_loaded = =3D 0; result =3D (((((sizeof
> ((c) + 0)) > (sizeof ((0x80) + 0)) ? (sizeof ((c) + 0)) : (sizeof (= (0x80) +
> 0))) <=3D sizeof (unsigned) ? ((c) + (unsigned) 0) < ((0x80) + (= unsigned) 0)
> : ((c) + (unsigned long) 0) < ((0x80) + (unsigned long) 0)) &&a= mp;

I see no "result =3D ...", or anything that could expand into it,= the
definition of CODING_CHAR_CHARSET. =C2=A0What am I missing?

> I would be willing work to get this cleaned up =C2=A0-- VC 7.1 support= s inline
> functions

Please do, and thanks. =C2=A0Just one request: try to keep the
MSVC-specific stuff separate, preferably somewhere under the nt/
directory (e.g., nt/inc/ms-w32.h) or in a clearly #ifdef'ed section at<= br> the beginning of a .c or .h file in src/, so that these changes don't make reading of the code harder.

Thanks.

--e89a8fb1ebe452ffe904ddfb2d43--