From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Nicolas =?UTF-8?Q?B=C3=A9rtolo?= Newsgroups: gmane.emacs.bugs Subject: bug#41242: Port feature/native-comp to Windows Date: Wed, 20 May 2020 15:48:52 -0300 Message-ID: References: <83k11e4a0s.fsf@gnu.org> <83blmp4tob.fsf@gnu.org> <83o8qp1hfr.fsf@gnu.org> <837dxcv1po.fsf@gnu.org> <83imgvdf94.fsf@gnu.org> <83eerjde6k.fsf@gnu.org> <838shm7g9m.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000006a0c705a618dbb0" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="18566"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41242@debbugs.gnu.org To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 20 20:50:21 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jbTnI-0004jq-R5 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 May 2020 20:50:20 +0200 Original-Received: from localhost ([::1]:54450 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jbTnH-0008CG-T8 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 May 2020 14:50:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34012) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jbTn1-0008B6-G8 for bug-gnu-emacs@gnu.org; Wed, 20 May 2020 14:50:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42705) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jbTn0-0002hn-3m for bug-gnu-emacs@gnu.org; Wed, 20 May 2020 14:50:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jbTmz-0005a9-Ud for bug-gnu-emacs@gnu.org; Wed, 20 May 2020 14:50:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Nicolas =?UTF-8?Q?B=C3=A9rtolo?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 May 2020 18:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41242 X-GNU-PR-Package: emacs Original-Received: via spool by 41242-submit@debbugs.gnu.org id=B41242.159000057421418 (code B ref 41242); Wed, 20 May 2020 18:50:01 +0000 Original-Received: (at 41242) by debbugs.gnu.org; 20 May 2020 18:49:34 +0000 Original-Received: from localhost ([127.0.0.1]:54251 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbTmY-0005ZM-DF for submit@debbugs.gnu.org; Wed, 20 May 2020 14:49:34 -0400 Original-Received: from mail-ot1-f66.google.com ([209.85.210.66]:45703) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jbTmX-0005ZA-Gx for 41242@debbugs.gnu.org; Wed, 20 May 2020 14:49:33 -0400 Original-Received: by mail-ot1-f66.google.com with SMTP id c3so3353835otr.12 for <41242@debbugs.gnu.org>; Wed, 20 May 2020 11:49:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TCR22K+LGX0Zq6Tv6B0iEJk3fQoyDALmKv7cUQOCe78=; b=kqmjDXkFvAv0pMN6QpfW3swCoG7tULgEyRe6P1una0FjpmbDT+mjlmpBdYcGBXI8QO tdnzd4uI6LcMCyrltscg402e86YKHPuAEIkZ8mD3i4/dyl6EUITUQsRVDAo+lbu+MdQ2 6V5NVLHEiZNv/FXVKA6k9hpWjfW8v3DJhJn1obePy0g7mEQaq3rDIUB/uw2pwYH9z2mR qUAM6fLnQ239E5fa6VIPO5JAuMOGOz7+VMLtXUnPgpzr2SN7WOCcHW3E0cGTpUsrF5Qq 2vHU1hq5FiEcCbZEjt06R6hhbI0v+RarVq+bnBEiw1ydZFPNFSHKJ59/k5Zfm9/+vnXI oJqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TCR22K+LGX0Zq6Tv6B0iEJk3fQoyDALmKv7cUQOCe78=; b=oKrfXHvTLmTUIBi5k3Dphgcgo9CLaR/o/UKgN87VHh6bFupFx1HLsne2DTZgMMkT1M QXfkUur4OQiNchHM9DwSFUMl4Rw3XaqclxPG7OkIDMsg7HVE4ZFAOC9CUS9nBtgycg89 hG87RRTUH+NYz0/xY02KLCX9RRZ9vXBI4aUopUEODidRaI8VOK1Z0FmlA0B5opZawLFw 7+XwhLn7F3a9j9zq2+B8pq1o9R5XNukfwI7Vfq14TFEtFFEMcSWi1kLk8VuYOIn2/IX9 rSLE4iP+Q+HlI3jMjpq/3dHREZhEWxqRvwJNDqelizieoq1CsiZfrmemN6AqTSADpZg9 O7Aw== X-Gm-Message-State: AOAM530ka9bDHY2WCOpuI3MZ2/aph0e1QaypNyNY7qNaYXJY1W4sVo5u 0he3M2PgjtIg77sVtu4D+9S17ioUaVT3nZDk9Yg= X-Google-Smtp-Source: ABdhPJz84AehPakE+ZPS9zCWi904d6y2iJxZ4QgerI/PJ1syhSnFIFe/XvO1T/oS2ErKfBszd1JKCBfbHsoIrHUGpbw= X-Received: by 2002:a4a:ad0d:: with SMTP id r13mr4486041oon.22.1590000567622; Wed, 20 May 2020 11:49:27 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180684 Archived-At: --00000000000006a0c705a618dbb0 Content-Type: text/plain; charset="UTF-8" > This won't compile on Posix because setjmp_ctx_func is under #ifdef > _WIN32. Fixed. > Given setjmp_ctx_func is used only in emit_setjmp I suggest to invoke > directly gcc_jit_context_get_builtin_function there while emitting the > corresponding call. Done. > The following patches do not currently apply, please update them from > your rebase branch: > 0004-Handle-LISP_WORDS_ARE_POINTERS-and-CHECK_LISP_OBJECT.patch > 0005-Remove-a-layer-of-indirection-for-access-to-pure-sto.patch Done. > While you are refreshing patches please have a look into the GNU style > of the diff (spaces in function calls and in pointer declaration) ;) Fixed :). > Sorry, still looking at > 0003-Handle-setjmp-taking-two-arguments-in-Windows.patch forgot to ask > if you could comment on this change: > > comp.char_type, > > - sizeof (jmp_buf)), > > + sizeof (sys_jmp_buf)), It is just a little bit more portable. I uploaded new patches to https://github.com/nicber/emacs branch feature/native-comp. Please tell me I if you'd rather I posted patches here. --00000000000006a0c705a618dbb0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> This won't compile on Posix because setjmp_ctx_fu= nc is under #ifdef
> _WIN32.

Fixed.

> Given setjmp_c= tx_func is used only in emit_setjmp I suggest to invoke
> directly gc= c_jit_context_get_builtin_function there while emitting the
> corresp= onding call.

Done.

> The following patches do not currentl= y apply, please update them from
> your rebase branch:

> 00= 04-Handle-LISP_WORDS_ARE_POINTERS-and-CHECK_LISP_OBJECT.patch
> 0005-= Remove-a-layer-of-indirection-for-access-to-pure-sto.patch

Done.
=
> While you are refreshing patches please have a look into the GNU s= tyle
> of the diff (spaces in function calls and in pointer declarati= on) ;)

Fixed :).

> Sorry, still looking at
> 0003-Ha= ndle-setjmp-taking-two-arguments-in-Windows.patch forgot to ask
> if = you could comment on this change:
> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 comp.char_type,
> > - =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 sizeof (jmp_buf)),
> > + =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 sizeof (sys_jmp_buf)),

It is just a = little bit more portable.

I uploaded new patches to https://github.com/nicber/emacs branch
f= eature/native-comp. Please tell me I if you'd rather I posted patches h= ere.
--00000000000006a0c705a618dbb0--