From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Nicolas =?UTF-8?Q?B=C3=A9rtolo?= Newsgroups: gmane.emacs.bugs Subject: bug#41755: feature/native-comp (master?): temacs crash in GC during mark phase Date: Tue, 9 Jun 2020 11:20:01 -0300 Message-ID: References: <87tuzlwf82.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000ff3dd405a7a76c82" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="8480"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Paul Eggert , Pip Cet , Andrea Corallo To: 41755@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 09 16:22:42 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jif9G-0002B7-BT for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Jun 2020 16:22:42 +0200 Original-Received: from localhost ([::1]:39748 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jif9F-00018s-AR for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Jun 2020 10:22:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55532) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jif7f-0007V8-7r for bug-gnu-emacs@gnu.org; Tue, 09 Jun 2020 10:21:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48964) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jif7e-0000Ud-St for bug-gnu-emacs@gnu.org; Tue, 09 Jun 2020 10:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jif7e-000287-P1 for bug-gnu-emacs@gnu.org; Tue, 09 Jun 2020 10:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Nicolas =?UTF-8?Q?B=C3=A9rtolo?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jun 2020 14:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41755 X-GNU-PR-Package: emacs Original-Received: via spool by 41755-submit@debbugs.gnu.org id=B41755.15917124218076 (code B ref 41755); Tue, 09 Jun 2020 14:21:02 +0000 Original-Received: (at 41755) by debbugs.gnu.org; 9 Jun 2020 14:20:21 +0000 Original-Received: from localhost ([127.0.0.1]:60509 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jif6z-00026C-EE for submit@debbugs.gnu.org; Tue, 09 Jun 2020 10:20:21 -0400 Original-Received: from mail-oi1-f180.google.com ([209.85.167.180]:33819) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jif6x-00025V-E8 for 41755@debbugs.gnu.org; Tue, 09 Jun 2020 10:20:19 -0400 Original-Received: by mail-oi1-f180.google.com with SMTP id b8so18925370oic.1 for <41755@debbugs.gnu.org>; Tue, 09 Jun 2020 07:20:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=H6KCZbh756LH8sptEI55y/J1D6EQiQdqeasfO1cw1ns=; b=PyvsQo6XtpQAkqrWyheyW1lyyd3AgqmvCkXoROHMFZdh90XgU3aJq32JGJ+H/cQYB4 r54v4U/QEiNc3Ncr1VUVjwVr1Uk2a7usspvqy/eMAt5k8ZzJXAeeYxXoX7gX3fHqYqYo CGfKQHE8h88NI8emRrsYa+3ol/89oEGEmcp7tK6wlg+DzMAhJUFD25EsYofl1AxBRef8 T4LvK9DHxrUhc6EaeKvy+fiRWy16trOCK9vk40J44qcD8hlwbLh9RSGXao7hlbO2gU6j i6PxLrxy2+LvHruJrMFOb3YI+9wAwd6lg5fwzOJz7/xLzD6aq6cmrLakkIywQx2+nO0v Iw0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=H6KCZbh756LH8sptEI55y/J1D6EQiQdqeasfO1cw1ns=; b=dCmszWnuIh1z+WoXXlp+8AXlPblsjzWuHrPoHtQ3j2x3yUmK2FPNA8JHVaEzhuky3o On/Z05fMa4cups1IRmNWPkBOK3ktoo1Y4BNc816+WpJOCpMfuhJ7tZA06qXHQ+9uhPzB mVIsC7pvk4R5vfEju4jCtj2obSt18nC9qfxCj92WHTcEWy/hggk/7285WXJMqjdixc9w x11tETSuHLaROSq1/D8mH5KTAjqPeX5p2Cwi4tC3PseaPdSXO/KJaiUIo6AATxrelXC9 ZLT7I7SXV5zw04KfxbYsT735lNSih9ApSviy70BRHXurCx0HczcaU/7jxzJwJbF/e3FY bPZg== X-Gm-Message-State: AOAM5315CkzAsh8s/grwspNQhk4eHS/1eARHXCoJZOYmZdaWaTqfUDRN hdIAXoSPwb3vQ85m+qXhbMzHThkJBFB3yJkhzm2IuyC/3xpEEg== X-Google-Smtp-Source: ABdhPJzCGmjmbUM4RrLh6ycyuT2e8HOkWgOxCcDtMMd7zT3Qb+ly75mvFy+2bKFDiOD2mUvcVV6xNAhAsSIKQWLnpRw= X-Received: by 2002:aca:58c5:: with SMTP id m188mr3641856oib.175.1591712413517; Tue, 09 Jun 2020 07:20:13 -0700 (PDT) In-Reply-To: <87tuzlwf82.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181776 Archived-At: --000000000000ff3dd405a7a76c82 Content-Type: text/plain; charset="UTF-8" Hi, Here's a new patch that copies the suffixes before building the heap-based list in openp. I know this is not the solution I proposed, but I couldn't adapt the code without increasing its complexity way too much for my liking. If you think this is not an appropriate solution I will come up with another one. Thanks, Nico. --000000000000ff3dd405a7a76c82 Content-Type: application/octet-stream; name="0001-Copy-suffixes-passed-to-openp-to-avoid-GC-crashes.-F.patch" Content-Disposition: attachment; filename="0001-Copy-suffixes-passed-to-openp-to-avoid-GC-crashes.-F.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kb80gfhe0 RnJvbSA0YjRmZDUyNmFiZTEyNGM4YTc0YmZhMTEyMDlkZDUzYzNhNTY0Y2M3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Tmljb2w9QzM9QTFzPTIwQj1DMz1BOXJ0b2xv Pz0gPG5pY29sYXNiZXJ0b2xvQGdtYWlsLmNvbT4KRGF0ZTogTW9uLCA4IEp1biAyMDIwIDIyOjAx OjI1IC0wMzAwClN1YmplY3Q6IFtQQVRDSF0gQ29weSBzdWZmaXhlcyBwYXNzZWQgdG8gJ29wZW5w JyB0byBhdm9pZCBHQyBjcmFzaGVzLiBGaXhlcwogYnVnIzQxNzU1CgpJbiBvcGVucF9hZGRfbWlk ZGxlX2Rpcl90b19zdWZmaXhlcyB3ZSBidWlsZCBhIGhlYXAtYmFzZWQgbGlzdCBmcm9tCnRoZSBw YXNzZWQgc3VmZml4ZXMuICBJdCBpcyBjcnVjaWFsIHRoYXQgd2UgZG9uJ3QgY3JlYXRlIGEgaGVh cC1iYXNlZApjb25zIHRoYXQgcG9pbnRzIHRvIGEgc3RhY2stYmFzZWQgbGlzdC4KCiogc3JjL2xy ZWFkLmMgKG9wZW5wX2FkZF9taWRkbGVfZGlyX3RvX3N1ZmZpeGVzKTogQ29weSBzdWZmaXhlcyB3 aGVuCmJ1aWxkaW5nIGEgbGlzdCBvZiBtaWRkbGUtZGlycyBhbmQgc3VmZml4ZXMuCi0tLQogc3Jj L2xyZWFkLmMgfCAxNCArKysrKysrKysrLS0tLQogMSBmaWxlIGNoYW5nZWQsIDEwIGluc2VydGlv bnMoKyksIDQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2xyZWFkLmMgYi9zcmMvbHJl YWQuYwppbmRleCBjMTI3ZDMyZWIxNy4uNjVkODQ0NjJjNGMgMTAwNjQ0Ci0tLSBhL3NyYy9scmVh ZC5jCisrKyBiL3NyYy9scmVhZC5jCkBAIC0xNjM1LDIxICsxNjM1LDI3IEBAIG9wZW5wX2FkZF9t aWRkbGVfZGlyX3RvX3N1ZmZpeGVzIChMaXNwX09iamVjdCBzdWZmaXhlcykKICAgTGlzcF9PYmpl Y3QgZXh0ZW5kZWRfc3VmID0gUW5pbDsKICAgRk9SX0VBQ0hfVEFJTF9TQUZFICh0YWlsKQogICAg IHsKLSNpZmRlZiBIQVZFX05BVElWRV9DT01QCisgICAgICAvKiAgc3VmZml4ZXMgbWF5IGJlIGEg c3RhY2stYmFzZWQgY29ucyBwb2ludGluZyB0byBzdGFjay1iYXNlZAorICAgICAgICAgIHN0cmlu Z3MuICBXZSBtdXN0IGNvcHkgdGhlIHN1ZmZpeCBpZiB3ZSBhcmUgcHV0dGluZyBpdCBpbnRvCisg ICAgICAgICAgYSBoZWFwLWJhc2VkIGNvbnMgdG8gYXZvaWQgYSBkYW5nbGluZyByZWZlcmVuY2Uu ICBUaGlzIHdvdWxkCisgICAgICAgICAgbGVhZCB0byBjcmFzaGVzIGR1cmluZyB0aGUgR0MuICAq LwogICAgICAgQ0hFQ0tfU1RSSU5HX0NBUiAodGFpbCk7CiAgICAgICBjaGFyICogc3VmID0gU1NE QVRBIChYQ0FSICh0YWlsKSk7CisgICAgICBMaXNwX09iamVjdCBjb3BpZWRfc3VmZml4ID0gYnVp bGRfc3RyaW5nIChzdWYpOworI2lmZGVmIEhBVkVfTkFUSVZFX0NPTVAKICAgICAgIGlmIChzdHJj bXAgKE5BVElWRV9FTElTUF9TVUZGSVgsIHN1ZikgPT0gMCkKICAgICAgICAgewogICAgICAgICAg IENIRUNLX1NUUklORyAoVmNvbXBfbmF0aXZlX3BhdGhfcG9zdGZpeCk7CiAgICAgICAgICAgLyog SGVyZSB3ZSBhZGQgdGhlbSBpbiB0aGUgb3Bwb3NpdGUgb3JkZXIgc28gdGhhdCBucmV2ZXJzZQog ICAgICAgICAgICAgIGNvcnJlY3RzIGl0LiAgKi8KLSAgICAgICAgICBleHRlbmRlZF9zdWYgPSBG Y29ucyAoRmNvbnMgKFFuaWwsIFhDQVIgKHRhaWwpKSwgZXh0ZW5kZWRfc3VmKTsKLSAgICAgICAg ICBleHRlbmRlZF9zdWYgPSBGY29ucyAoRmNvbnMgKFZjb21wX25hdGl2ZV9wYXRoX3Bvc3RmaXgs IFhDQVIgKHRhaWwpKSwKKyAgICAgICAgICBleHRlbmRlZF9zdWYgPSBGY29ucyAoRmNvbnMgKFFu aWwsIGNvcGllZF9zdWZmaXgpLCBleHRlbmRlZF9zdWYpOworICAgICAgICAgIGV4dGVuZGVkX3N1 ZiA9IEZjb25zIChGY29ucyAoVmNvbXBfbmF0aXZlX3BhdGhfcG9zdGZpeCwKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvcGllZF9zdWZmaXgpLAogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBleHRlbmRlZF9zdWYpOwogICAgICAgICB9CiAgICAgICBlbHNl CiAjZW5kaWYKLQlleHRlbmRlZF9zdWYgPSBGY29ucyAoRmNvbnMgKFFuaWwsIFhDQVIgKHRhaWwp KSwgZXh0ZW5kZWRfc3VmKTsKKwlleHRlbmRlZF9zdWYgPSBGY29ucyAoRmNvbnMgKFFuaWwsIGNv cGllZF9zdWZmaXgpLCBleHRlbmRlZF9zdWYpOwogICAgIH0KIAogICBzdWZmaXhlcyA9IEZucmV2 ZXJzZSAoZXh0ZW5kZWRfc3VmKTsKLS0gCjIuMjUuMS53aW5kb3dzLjEKCg== --000000000000ff3dd405a7a76c82--