From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Nicolas =?UTF-8?Q?B=C3=A9rtolo?= Newsgroups: gmane.emacs.bugs Subject: bug#41242: Port feature/native-comp to Windows - Determine the emacs root dir... Date: Sat, 30 May 2020 17:15:05 -0300 Message-ID: References: <83k10wshvg.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="1967"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41242@debbugs.gnu.org To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 30 22:16:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jf7tr-0000OW-Bx for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 May 2020 22:16:11 +0200 Original-Received: from localhost ([::1]:35770 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jf7tq-0005NK-0U for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 May 2020 16:16:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54990) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jf7tj-0005N8-0T for bug-gnu-emacs@gnu.org; Sat, 30 May 2020 16:16:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47711) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jf7ti-0003pO-MW for bug-gnu-emacs@gnu.org; Sat, 30 May 2020 16:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jf7ti-0007cj-HT for bug-gnu-emacs@gnu.org; Sat, 30 May 2020 16:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Nicolas =?UTF-8?Q?B=C3=A9rtolo?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 May 2020 20:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41242 X-GNU-PR-Package: emacs Original-Received: via spool by 41242-submit@debbugs.gnu.org id=B41242.159086972429249 (code B ref 41242); Sat, 30 May 2020 20:16:02 +0000 Original-Received: (at 41242) by debbugs.gnu.org; 30 May 2020 20:15:24 +0000 Original-Received: from localhost ([127.0.0.1]:59257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jf7t6-0007bh-3G for submit@debbugs.gnu.org; Sat, 30 May 2020 16:15:24 -0400 Original-Received: from mail-oi1-f169.google.com ([209.85.167.169]:37524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jf7t4-0007bS-TZ for 41242@debbugs.gnu.org; Sat, 30 May 2020 16:15:23 -0400 Original-Received: by mail-oi1-f169.google.com with SMTP id m67so5734512oif.4 for <41242@debbugs.gnu.org>; Sat, 30 May 2020 13:15:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4Jha/KupkG2WCLDKSoyWZTNjaIQMttUqAlZK8fcETaA=; b=GmwIRsH9cT5KxM4loQ8Sz2nScNY8IjCVD1gbbzNAT5Td684QkQu8GgDgzHYELnsPZK WgD2yJ9F1m2oubJCPyaI1GymTUzu43EfJA79/GAn6GPorZpcKe/gcvInNHbBzIFdMDqO AS2+XaeMbZ/nG61ECDztW6ZlOvcSdQxTKmDtM6CmBLQFEDlpNqnES0VeurYgJ+WOVCKQ EGREHq3GjIzMb1OH/UvRMR9s538+yfxSVKUGYuS4fBVeSYlou9xyYEAYaiE5dkyvc0ra F4wsr/ndTwNNuCQ4qFiZsEpY8FZpeFrrgZ6Zrbi6PaAmAzcw6lyECINWm0gsk3gER62X vvSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4Jha/KupkG2WCLDKSoyWZTNjaIQMttUqAlZK8fcETaA=; b=GISPLL1Hvjz/ZrWxy7280GRtivEpoVfBdadw9IBvCFHoZcbpWCVnNvdW5Gxf4ODiex mKgcmpUKRCL77Vn9/mWuaVaOC4RN52ceFyMoPbGYNNB6eT+cEMPcPRI4RHD3A9Anr1PS 9aDCVM+35uwGlkgZ+Mc5sz/TrQf7Qje/3p12knagpmhU7/Uh7dr1BfLoEjgdim7I+l2z 25a2iJeeZ4ekI6HDpxPKX2eDq3D5wQTve3uJSDnPvUVYmAw+dgtfsw0aQmSF5wy25L72 ynMEanWyXghGGhjMiqpsuR8hHJzIIVMupGZjiBhtFTKcMB2u5Gu+vZiCCV7SFOQSxTHJ SR3A== X-Gm-Message-State: AOAM533wULV1EcGAbey+iphuj9TWLlWbplxOJEPrLQwrULC9zYE3UY/E dfkmOPKCU/DewxNbAy4O8Q6tsFavgtzQ+cLk9+w= X-Google-Smtp-Source: ABdhPJxINEi8SXY1QylNh4shBkE6Gq8Vr+SqWchoPlt7HdxsOOchTzcYtL8nmzqJwndtrZXRS+dTIYA7WzdoTHlQvKY= X-Received: by 2002:a54:4701:: with SMTP id k1mr10390741oik.175.1590869716951; Sat, 30 May 2020 13:15:16 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181260 Archived-At: > Again as suggested, *please* run 'check_GNU_style.sh' on your patches if > you are not used to GNU code style to fix it. I will set it as a git hook, so I won't be able to commit unless the code is well formatted. > Presenting a patch correctly formatted, well tested and fully understood > is a sign of respect for reviewers and the time they are going to invest > in the review process. > We are all volunteers and we all have to cope with time constraints. > Investing time in reviews means subtracting it to other activities > including working on other patches and features. I have great respect for you and Eli, and for all the time you have spent reviewing my patches. I am sorry that my lack of attention has been taken as a lack respect for you. It will not happen again. > We aim for code quality rather then quantity or other metrics. > The followings are to be considered as basic features we want for all > patches (not just this) to be applied to this branch: > - Compiles and bootstrap --with-nativecomp --without-nativecomp I had setup an AppVeyor instance that compiles my repo without native-comp on Windows. I could not detect the build problems in my latest patch for some unknown reason. I didn't expect that to happen. I will add two instances that build the code on GNU/Linux with and without native-comp, that should help me catch more build errors. > - Formatting is correct > Obviously we can always make mistakes that is totally okay, but does not > have to be a routine that is expected to be fixed by reviewers. > Please apply these suggestions to all patches that are submitted or > pending for review to speed-up the process so we can leave the > discussion for interesting topics. I am really sorry for wasting your time like this. It will not happen again. Nico