From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Nicolas =?UTF-8?Q?B=C3=A9rtolo?= Newsgroups: gmane.emacs.bugs Subject: bug#41615: [feature/native-comp] Dump prettier C code. Date: Sun, 31 May 2020 16:38:15 -0300 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="25631"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41615@debbugs.gnu.org To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 31 21:39:22 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jfTnl-0006aS-Sp for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 31 May 2020 21:39:21 +0200 Original-Received: from localhost ([::1]:54964 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jfTnk-0007rC-UE for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 31 May 2020 15:39:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46200) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jfTnS-0007pJ-Ld for bug-gnu-emacs@gnu.org; Sun, 31 May 2020 15:39:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50569) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jfTnS-0004Gj-9H for bug-gnu-emacs@gnu.org; Sun, 31 May 2020 15:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jfTnS-0005oV-7H for bug-gnu-emacs@gnu.org; Sun, 31 May 2020 15:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Nicolas =?UTF-8?Q?B=C3=A9rtolo?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 31 May 2020 19:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41615 X-GNU-PR-Package: emacs Original-Received: via spool by 41615-submit@debbugs.gnu.org id=B41615.159095391522315 (code B ref 41615); Sun, 31 May 2020 19:39:02 +0000 Original-Received: (at 41615) by debbugs.gnu.org; 31 May 2020 19:38:35 +0000 Original-Received: from localhost ([127.0.0.1]:33882 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jfTn1-0005nq-Jw for submit@debbugs.gnu.org; Sun, 31 May 2020 15:38:35 -0400 Original-Received: from mail-ot1-f47.google.com ([209.85.210.47]:44281) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jfTn0-0005nd-2q for 41615@debbugs.gnu.org; Sun, 31 May 2020 15:38:34 -0400 Original-Received: by mail-ot1-f47.google.com with SMTP id f18so6247603otq.11 for <41615@debbugs.gnu.org>; Sun, 31 May 2020 12:38:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0RBl1NeOgoIdVBv/eAp5Zlx5fgRZ7IblZF4SW+kqRlc=; b=LluaFcoowiJG57ZPsmG9ZKL9cP3OwS8A6duO069Ulq1jigdyskMSjkozjcUgkNdE5k OsrtZq+R2y6JkCdw5BwSSpyEr4pIRAefUg8Q0hoYtQiLp9RUSlysb04de1yq5CJBcVI2 HNajSzSmgoGrvXqItoPV9pt2ZiqW+swtc6qJ1wAFDvsYEhJw8YQrxyPDAOeQvLCknZTd SGcQwlP3AIbQqkG0GHdfD3Pw7clhZbt7FzGOToO0IbYj1eBl20FqoW2p0SE4NRIhc+0d gKSfDZzbdGcei0i9SsK4jZzipP1aXsqTYrJG5z8dgKBmKVdEX4TjCQuv6I7NWDdBC19b 0q/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0RBl1NeOgoIdVBv/eAp5Zlx5fgRZ7IblZF4SW+kqRlc=; b=prBiEAhQjCvJ5wk2gMAWunYcjvCu0z9DmoQ/OtPLnhUdiUU1yk4PnloZluWP9h5r00 ZrdhiFRV8orAHsffX2GojGAox9EkGxO/kBhTZD9SqALcTPpIhQ2GHu/+K0v87Zj7MSWJ QD9/YCnjXSMToUaSeNVDBm28ooyFuMe36Wmr3b0/qHJzKutBP9Cm0ALa2Q1+GpD3uzSt NzYqtxuoNjck1DcD0phyg9JZ0WOPx9JelXB9C+SAUrAxp+czAxlCrEoRWfMCzPsToIRQ rBtoIkY3oyQAT20cfUyLmfG15CnAZn8681bVJqUbG0z1om6LKxAZXBKkHnYyAfeNZQGc OR4Q== X-Gm-Message-State: AOAM531hp5Z1uGpjMSGFgcMnV65TVwT7/GYVtEsQqo+PNDPZ9jK90Hd/ JneRm6fxToYPlPVNEf78miRcSgzFMZ2i3blPrrU= X-Google-Smtp-Source: ABdhPJwdNSZ12GNMjpSqNC4+uuolIxJjvQn9IItkECXRriH3eQSxBMYXJGXLr4B5pvfUEuCB51wQBkSa4jefUV37AAg= X-Received: by 2002:a9d:5f09:: with SMTP id f9mr14078144oti.202.1590953908178; Sun, 31 May 2020 12:38:28 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181317 Archived-At: > The whole compilation is something like 5x faster here. Amazing.I took a closer look at the code that uses casts to bools and I think I found a bug. Casting to bool using an enum is equivalent to taking the lowest byte using a byte mask. This wrongly casts to "false" integers whose lowest byte is nil. bool cast_from_unsigned_long_long_to_bool (unsigned long long x) { return (x & 0xFF); } The correct way to cast to bool is to mimic C semantics: bool cast_from_unsigned_long_long_to_bool (unsigned long long x) { if (x != 0) return true; else return false; } Am I right? Nico.