From: "Nicolas Bértolo" <nicolasbertolo@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: eggert@cs.ucla.edu, 41755@debbugs.gnu.org, pipcet@gmail.com,
akrl@sdf.org
Subject: bug#41755: feature/native-comp (master?): temacs crash in GC during mark phase
Date: Mon, 8 Jun 2020 15:24:23 -0300 [thread overview]
Message-ID: <CAFnS-OkgrRYmRd=q3F5F2peSxm1uiZhS6paBj52uPiC6w8RVSQ@mail.gmail.com> (raw)
In-Reply-To: <5CB87F9A-431C-4BC6-99CD-753844A26BCC@gnu.org>
> Thanks, but are you sure the fix should be in load_charset_map_from_file and
> not in the new code added to openp in the offending commit? Why does the
> additional code in openp need to cons its list off the heap?
Good idea. It should be easy to rework the openp to avoid putting the suffixes
in a heap based list.
What openp() does now is turn a list of suffixes into a list of suffixes and
associated directories that need to be added to the file path.
For example, it turns this:
(".eln" ".elc" ".elc.gz" ".el" ".el.gz")
into this:
((nil . ".eln")
(comp-native-path-postfix . ".eln")
(nil . ".elc")
(nil . ".elc.gz")
(nil . ".el")
(nil . ".el.gz"))
I did it this way because then iterating over it can be done using a
FOR_EACH_TAIL macro. I'll change this to use two lists, one for the suffixes and
another one for the directories. The code for iterating them will be just a
little more complicated, but it should be safe to pass stack-based suffixes.
next prev parent reply other threads:[~2020-06-08 18:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-07 19:16 bug#41755: feature/native-comp (master?): temacs crash in GC during mark phase Andrea Corallo
2020-06-07 19:41 ` Pip Cet
2020-06-07 19:57 ` Nicolas Bértolo
2020-06-07 20:18 ` Pip Cet
2020-06-07 23:09 ` Nicolas Bértolo
2020-06-08 3:39 ` Nicolas Bértolo
2020-06-08 6:29 ` Eli Zaretskii
2020-06-08 18:24 ` Nicolas Bértolo [this message]
2020-06-08 6:41 ` Pip Cet
2020-06-08 18:51 ` Nicolas Bértolo
2020-06-08 19:05 ` Pip Cet
2020-06-09 14:20 ` Nicolas Bértolo
2020-06-10 12:53 ` Andrea Corallo
2020-06-27 14:39 ` Andrea Corallo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFnS-OkgrRYmRd=q3F5F2peSxm1uiZhS6paBj52uPiC6w8RVSQ@mail.gmail.com' \
--to=nicolasbertolo@gmail.com \
--cc=41755@debbugs.gnu.org \
--cc=akrl@sdf.org \
--cc=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=pipcet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.