all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [PATCH] org-fold: (org-fold-hide-drawer-all): Make interactive
@ 2023-10-18 14:42 Ivan Necas
  2023-10-19  9:34 ` Ihor Radchenko
  0 siblings, 1 reply; 3+ messages in thread
From: Ivan Necas @ 2023-10-18 14:42 UTC (permalink / raw)
  To: emacs-orgmode


[-- Attachment #1.1: Type: text/plain, Size: 339 bytes --]

Hi,

Sometimes, I want to unfold all the drawers using `org-fold-show-all',
and then I want to hide them all back. I've noticed, there is a function
`org-fold-hide-drawer-all' does just that, but it's not marked
as a command, so the patch is as simple as adding `(interactive)` there,
as I don't see a reason it shouldn't be one.

-- Ivan

[-- Attachment #1.2: Type: text/html, Size: 473 bytes --]

[-- Attachment #2: 0001-lisp-org-fold.el-org-fold-hide-drawer-all-Make-inter.patch --]
[-- Type: text/x-patch, Size: 726 bytes --]

From b059c1def1df57921b08b5a350f8b67148dfbc67 Mon Sep 17 00:00:00 2001
From: Ivan Necas <necasik@gmail.com>
Date: Wed, 18 Oct 2023 14:51:33 +0200
Subject: [PATCH] * lisp/org-fold.el (org-fold-hide-drawer-all): Make
 interactive

TINYCHANGE
---
 lisp/org-fold.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/org-fold.el b/lisp/org-fold.el
index 18ccbf0bb..67a2a25a6 100644
--- a/lisp/org-fold.el
+++ b/lisp/org-fold.el
@@ -594,6 +594,7 @@ (defun org-fold-hide-block-all ()
   (org-block-map (apply-partially #'org-fold-hide-block-toggle 'hide)))
 
 (defun org-fold-hide-drawer-all ()
+  (interactive)
   "Fold all drawers in the current buffer."
   (let ((begin (point-min))
         (end (point-max)))
-- 
2.41.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] org-fold: (org-fold-hide-drawer-all): Make interactive
  2023-10-18 14:42 [PATCH] org-fold: (org-fold-hide-drawer-all): Make interactive Ivan Necas
@ 2023-10-19  9:34 ` Ihor Radchenko
  2023-10-19 15:15   ` Ivan Necas
  0 siblings, 1 reply; 3+ messages in thread
From: Ihor Radchenko @ 2023-10-19  9:34 UTC (permalink / raw)
  To: Ivan Necas; +Cc: emacs-orgmode

Ivan Necas <necasik@gmail.com> writes:

> Sometimes, I want to unfold all the drawers using `org-fold-show-all',
> and then I want to hide them all back. I've noticed, there is a function
> `org-fold-hide-drawer-all' does just that, but it's not marked
> as a command, so the patch is as simple as adding `(interactive)` there,
> as I don't see a reason it shouldn't be one.

Makes sense.
I applied an alternative version of the patch onto main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=13353f1fa
Handled.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] org-fold: (org-fold-hide-drawer-all): Make interactive
  2023-10-19  9:34 ` Ihor Radchenko
@ 2023-10-19 15:15   ` Ivan Necas
  0 siblings, 0 replies; 3+ messages in thread
From: Ivan Necas @ 2023-10-19 15:15 UTC (permalink / raw)
  To: Ihor Radchenko; +Cc: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 891 bytes --]

Oh nice, thanks!

-- Ivan

On Thu, 19 Oct 2023 at 11:32, Ihor Radchenko <yantar92@posteo.net> wrote:

> Ivan Necas <necasik@gmail.com> writes:
>
> > Sometimes, I want to unfold all the drawers using `org-fold-show-all',
> > and then I want to hide them all back. I've noticed, there is a function
> > `org-fold-hide-drawer-all' does just that, but it's not marked
> > as a command, so the patch is as simple as adding `(interactive)` there,
> > as I don't see a reason it shouldn't be one.
>
> Makes sense.
> I applied an alternative version of the patch onto main.
> https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=13353f1fa
> Handled.
>
> --
> Ihor Radchenko // yantar92,
> Org mode contributor,
> Learn more about Org mode at <https://orgmode.org/>.
> Support Org development at <https://liberapay.com/org-mode>,
> or support my work at <https://liberapay.com/yantar92>
>

[-- Attachment #2: Type: text/html, Size: 1716 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-10-19 15:16 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-18 14:42 [PATCH] org-fold: (org-fold-hide-drawer-all): Make interactive Ivan Necas
2023-10-19  9:34 ` Ihor Radchenko
2023-10-19 15:15   ` Ivan Necas

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.