all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Constantin Kulikov <zxnotdead@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: kill-buffer calls frame's buffer-predicate for all buffers even if the killed buffer was not shown in any window.
Date: Mon, 16 Jan 2017 11:14:10 +0300	[thread overview]
Message-ID: <CAFkz2ypR1RJMBn1-61Rwt8-8aWOxbP=Y1OYbzVyRGoBYB7F15w@mail.gmail.com> (raw)
In-Reply-To: <83inpg9ib5.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 947 bytes --]

> it needs to find another buffer to become the current one
The current in what sense? In the sense of 1)(current-buffer) or 2)
(windown-buffer (selected-window))?
If 1) then why require that this buffer is not visible?
If 2) then why call the buffer-predicate in the case where the killed
buffer was not shown in any window?

What I understand of how kill-buffer must work:
First call kill-buffer hooks
Then find windows with the buffer and replace it, here the call to
buffer-predicate it legit if the buffer was visible in any window.
Then really kill the buffer.
At this point we can set selected window buffer as current because we
already have called the replace-buffer-in-window.
If there is no selected window, then we can take the first buffer in
(buffer-list) as current
or create the *sctatch* and set it as current.

I can not see why there is a need to call buffer-predicate when killing a
buffer that was not visible in any window.)

[-- Attachment #2: Type: text/html, Size: 1546 bytes --]

  reply	other threads:[~2017-01-16  8:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-15 19:32 kill-buffer calls frame's buffer-predicate for all buffers even if the killed buffer was not shown in any window Constantin Kulikov
2017-01-15 20:31 ` Eli Zaretskii
2017-01-16  8:14   ` Constantin Kulikov [this message]
2017-01-16 16:26     ` Eli Zaretskii
2017-01-16 16:55       ` Eli Zaretskii
2017-01-16 22:21       ` Constantin Kulikov
2017-01-17 14:26         ` Stefan Monnier
2017-01-17 14:40         ` Constantin Kulikov
2017-01-18 10:03           ` Constantin Kulikov
2017-01-18 15:43             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFkz2ypR1RJMBn1-61Rwt8-8aWOxbP=Y1OYbzVyRGoBYB7F15w@mail.gmail.com' \
    --to=zxnotdead@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.