From: Chris McMahan <cmcmahan@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 41086@debbugs.gnu.org
Subject: bug#41086: Fwd: bug#41086: [PATCH] Add user-defined column widths to package-list (package.el)
Date: Tue, 5 May 2020 13:12:26 -0400 [thread overview]
Message-ID: <CAFgt8u3RGRH8-6A7WnGvTm+iQT6Vi1YxUvCnO+42SeWm3CiEQA@mail.gmail.com> (raw)
In-Reply-To: <83zhaml5xf.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 3930 bytes --]
I may have found a solution.... but I have no idea if it's a decent one....
;; Original non-functioning code. Trying to get the value of the
package-archive-column-width into the list rather than hardcode it.
(setq tabulated-list-format
`[("Package" ,package-name-column-width
package-menu--name-predicate)
("Version" ,package-version-column-width
package-menu--version-predicate)
("Status" ,package-status-column-width
package-menu--status-predicate)])
,@(if (cdr package-archives)
'(("Archive" ,package-archive-column-width
package-menu--archive-predicate)))
("Description" 0 package-menu--description-predicate)])
;; potential solution.... any thoughts?
(setq tabulated-list-format
`[("Package" ,package-name-column-width
package-menu--name-predicate)
("Version" ,package-version-column-width
package-menu--version-predicate)
("Status" ,package-status-column-width
package-menu--status-predicate)])
(if (cdr package-archives)
(setq tabulated-list-format (append tabulated-list-format `(("Archive"
,package-archive-column-width package-menu--archive-predicate)))))
(setq tabulated-list-format (append tabulated-list-format `(("Description"
0 package-menu--description-predicate))))
- Chris
On Tue, May 5, 2020 at 12:09 PM Eli Zaretskii <eliz@gnu.org> wrote:
> [Forwarding to everyone; please use Reply All.]
>
> > From: Chris McMahan <cmcmahan@gmail.com>
> > Date: Tue, 5 May 2020 11:28:13 -0400
> >
> > Hi Eli,
> > I hope I'm not being too difficult getting this set up.
> >
> > The format for the patch commit message has been incorporated.
> >
> > The other hardcoded values (13 in this case) are for aligning the labels
> and values in the package description
> > page, and not related to the package-menu table that this patch covers.
> >
> > On the question of the Archive column... I have been trying to figure
> out how to have the value of the variable
> > substituted in to the list, rather than the variable name as a string.
> >
> > Evaluating this code results in the following error:
> >
> > [("Package" 30 package-menu--name-predicate) ("Version" 14
> package-menu--version-predicate) ("Status"
> > 12 package-menu--status-predicate) ("Archive" (\,
> package-archive-column-width)
> > package-menu--archive-predicate) q ("Description" 0
> package-menu--description-predicate)]
> >
> > (defcustom package-name-column-width 30
> > "Column width for the Package name in the package menu."
> > :type 'number
> > :version "28.1")
> >
> > (defcustom package-version-column-width 14
> > "Column width for the Package version in the package menu."
> > :type 'number
> > :version "28.1")
> >
> > (defcustom package-status-column-width 12
> > "Column width for the Package status in the package menu."
> > :type 'number
> > :version "28.1")
> >
> > (defcustom package-archive-column-width 12
> > "Column width for the Package status in the package menu."
> > :type 'number
> > :version "28.1")
> >
> > (setq tabulated-list-format
> > `[("Package" ,package-name-column-width
> package-menu--name-predicate)
> > ("Version" ,package-version-column-width
> package-menu--version-predicate)
> > ("Status" ,package-status-column-width
> package-menu--status-predicate)
> > ,@(if (cdr package-archives)
> > '(("Archive" ,package-status-column-width
> package-menu--archive-predicate)))
> > ("Description" 0 package-menu--description-predicate)])
> >
> >
> > I can't figure out how to get it to use the value of
> package-archive-column-width and not the string literal.
> >
> > I'll hold off another patch to try to solve this one. Any help you could
> offer would be greatly appreciated!
>
--
*Chris McMahan <cmcmahan@gmail.com <cmcmahan@gmail.com>>*
[-- Attachment #2: Type: text/html, Size: 6202 bytes --]
next prev parent reply other threads:[~2020-05-05 17:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 20:10 bug#41086: [PATCH] Add user-defined column widths to package-list (package.el) Chris McMahan
2020-05-04 21:01 ` bug#41086: Corrcted patch for bug #41086 Chris McMahan
2020-05-04 21:02 ` bug#41086: [PATCH] Add user-defined column widths to package-list (package.el) Stefan Kangas
[not found] ` <CAFgt8u2GWpZHnSevoGMQwVQP1x6n8mvRVFJEZbXW-iqM7qNaaw@mail.gmail.com>
2020-05-05 1:39 ` bug#41086: Fwd: " Stefan Kangas
2020-05-05 14:14 ` Eli Zaretskii
[not found] ` <CAFgt8u018fvLKF8xWsUs5Ky1TLhSceSPJSuKhrFrgvcm_zOU8g@mail.gmail.com>
2020-05-05 16:09 ` Eli Zaretskii
2020-05-05 17:12 ` Chris McMahan [this message]
2020-05-05 17:24 ` Noam Postavsky
2020-05-05 17:54 ` Chris McMahan
[not found] ` <87eerznyav.fsf@stefankangas.se>
[not found] ` <CAFgt8u2CgqfwWQ2xraK=c9ceALC6VXksdFNV3wBvvV0sr1m+hw@mail.gmail.com>
2020-05-05 1:39 ` Stefan Kangas
2020-05-05 1:42 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFgt8u3RGRH8-6A7WnGvTm+iQT6Vi1YxUvCnO+42SeWm3CiEQA@mail.gmail.com \
--to=cmcmahan@gmail.com \
--cc=41086@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.