From: Fabrice Popineau <fabrice.popineau@supelec.fr>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: Eli Zaretskii <eliz@gnu.org>,
AJMR <ajmr@ilovetortilladepatatas.com>,
emacs-devel@gnu.org
Subject: Re: Windows 64 port
Date: Tue, 28 Feb 2012 22:00:37 +0100 [thread overview]
Message-ID: <CAFgFV9Pjp_n9_S7rWPpRcUFo1RUKJu_NHA3taJxMafEfJtQZ_g@mail.gmail.com> (raw)
In-Reply-To: <4F428780.8070902@cs.ucla.edu>
[-- Attachment #1: Type: text/plain, Size: 1619 bytes --]
>
> The patch is too intrusive to the mainline code
> and many of its changes should be omitted.
>
I maintain my point of view. Most of my patch is to ensure that 32bits and
64bits values are not mixed up,
and that unsigned and signed values aren't either. Maybe some of it can be
omitted, that doesn't mean one day
or another they won't be missed.
>
> - int i = 0, aligned = (intptr_t) ABLOCKS_BUSY (abase);
> + int i = 0;
> + intptr_t aligned = (intptr_t) ABLOCKS_BUSY (abase);
>
> Here, the value of 'aligned' is either 0 or 1, so there's
> no need to change its type.
>
Then
int aligned = (ABLOCKS_BUSY(abase) != NULL);
would have been cleaner.
The changes to src/m/amdx86-64.h would break GNU/Linux and
> need to be backed out and redone.
Obviously, they need to be made dependent on the target platform.
(Done in the patch to come).
> This mishandles Emacs integers outside the signed 32-bit range:
>
> -#define XFASTINT(a) ((a) + 0)
> +#define XFASTINT(a) ((int)((a) + 0))
>
Oops. Sorry for this one. It was a leftover.
There is something wrong around lib/strftime.c:946
if (negative_number)
u_number_value = - u_number_value;
u_number_value being unsigned, this is wrong. I haven't look for a proper
fix.
In src/dispnew.c:6402, height and width should probably be unsigned. The
checking by
INT_ADD_RANGE_OVERFLOW results in a compiler warning about integral
constant overflow
because it tries to compute (INTMIN - 2) which obviously is out of range.
The value is not used in this case, but the compiler may emit the warning
anyway.
Best regards,
--
Fabrice
[-- Attachment #2: Type: text/html, Size: 2589 bytes --]
next prev parent reply other threads:[~2012-02-28 21:00 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-19 20:18 Windows 64 port AJMR
2012-02-19 21:26 ` Eli Zaretskii
2012-02-19 22:05 ` Fabrice Popineau
2012-02-20 3:53 ` Eli Zaretskii
2012-02-20 17:48 ` Paul Eggert
2012-02-20 19:20 ` Fabrice Popineau
2012-02-20 20:43 ` Paul Eggert
2012-02-20 20:58 ` Eli Zaretskii
2012-02-20 23:11 ` Fabrice Popineau
2012-02-20 23:46 ` Paul Eggert
2012-02-21 13:22 ` Stefan Monnier
2012-02-21 18:26 ` Paul Eggert
2012-02-22 10:39 ` Richard Stallman
2012-02-22 16:27 ` Eli Zaretskii
2012-02-23 18:44 ` Richard Stallman
2012-02-23 19:16 ` Aurélien
2012-02-23 19:50 ` Lennart Borgman
2012-02-23 20:48 ` Fabrice Popineau
2012-02-24 5:52 ` Aurélien
2012-02-28 21:00 ` Fabrice Popineau [this message]
2012-02-28 22:09 ` Paul Eggert
2012-02-28 22:39 ` Fabrice Popineau
2012-02-29 18:08 ` Eli Zaretskii
2012-02-29 22:08 ` Paul Eggert
2012-02-29 18:04 ` Eli Zaretskii
2012-02-29 19:43 ` Paul Eggert
2012-02-29 21:24 ` Eli Zaretskii
2012-03-01 3:34 ` Paul Eggert
2012-03-01 4:03 ` Eli Zaretskii
2012-03-01 6:28 ` Paul Eggert
2012-03-01 7:04 ` Fabrice Popineau
2012-03-22 17:31 ` Fabrice Popineau
2012-03-23 18:26 ` Paul Eggert
2012-03-24 9:27 ` Fabrice Popineau
2012-03-22 17:39 ` Fabrice Popineau
2012-03-22 18:02 ` Andreas Schwab
2012-03-22 18:34 ` Fabrice Popineau
2012-03-22 22:46 ` Andreas Schwab
2012-03-22 23:06 ` Fabrice Popineau
2012-03-22 23:38 ` Andreas Schwab
2012-03-23 8:12 ` Eli Zaretskii
2012-03-23 9:45 ` Andreas Schwab
2012-03-23 10:27 ` Fabrice Popineau
2012-03-23 10:42 ` Andreas Schwab
2012-03-23 12:21 ` Eli Zaretskii
2012-03-23 10:11 ` Fabrice Popineau
2012-03-23 18:13 ` Paul Eggert
2012-02-20 20:47 ` Eli Zaretskii
2012-02-26 20:17 ` AJMR
2012-02-26 21:25 ` Eli Zaretskii
2012-02-27 17:37 ` AJMR
2012-02-28 21:32 ` Fabrice Popineau
2012-03-01 3:23 ` Paul Eggert
2012-03-01 7:24 ` Fabrice Popineau
2012-03-01 8:58 ` Paul Eggert
2012-03-01 17:45 ` Eli Zaretskii
2012-03-01 20:05 ` Fabrice Popineau
2012-03-02 9:22 ` Eli Zaretskii
2012-03-02 20:35 ` Paul Eggert
2012-03-02 21:32 ` Fabrice Popineau
2012-03-02 22:06 ` Eli Zaretskii
2012-03-03 5:42 ` Paul Eggert
2012-03-03 7:18 ` Eli Zaretskii
2012-03-04 21:48 ` Paul Eggert
2012-03-03 7:58 ` Eli Zaretskii
2012-03-10 13:43 ` Eli Zaretskii
2012-03-22 17:15 ` Fabrice Popineau
2012-03-22 17:22 ` Fabrice Popineau
2012-03-22 18:29 ` Fabrice Popineau
2012-03-22 20:53 ` Stefan Monnier
2012-03-27 12:47 ` Fabrice Popineau
2012-03-27 16:08 ` Paul Eggert
2012-02-20 9:41 ` Richard Stallman
2012-02-20 10:28 ` Dani Moncayo
2012-02-21 12:10 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFgFV9Pjp_n9_S7rWPpRcUFo1RUKJu_NHA3taJxMafEfJtQZ_g@mail.gmail.com \
--to=fabrice.popineau@supelec.fr \
--cc=ajmr@ilovetortilladepatatas.com \
--cc=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.