From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Fabrice Popineau Newsgroups: gmane.emacs.devel Subject: Re: dired-tests.el fails on MS-Windows Date: Tue, 1 Aug 2017 22:52:28 +0200 Message-ID: References: <83zibjz519.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="089e08225dac8666780555b754da" X-Trace: blaine.gmane.org 1501620818 27347 195.159.176.226 (1 Aug 2017 20:53:38 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 1 Aug 2017 20:53:38 +0000 (UTC) Cc: Emacs developers , Tino Calancha To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 01 22:53:34 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dceAU-0006kS-LR for ged-emacs-devel@m.gmane.org; Tue, 01 Aug 2017 22:53:30 +0200 Original-Received: from localhost ([::1]:44415 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dceAa-0006Fb-Ls for ged-emacs-devel@m.gmane.org; Tue, 01 Aug 2017 16:53:36 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53012) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dce9z-0006FH-LG for emacs-devel@gnu.org; Tue, 01 Aug 2017 16:53:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dce9x-0005EA-PF for emacs-devel@gnu.org; Tue, 01 Aug 2017 16:52:59 -0400 Original-Received: from smtp2.supelec.fr ([160.228.120.31]:39213) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dce9t-00058r-NK; Tue, 01 Aug 2017 16:52:54 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by smtp2.supelec.fr (Postfix) with ESMTP id 31F9380405; Tue, 1 Aug 2017 22:52:51 +0200 (CEST) X-Virus-Scanned: amavisd-new at smtp2.supelec.fr Original-Received: from smtp2.supelec.fr ([127.0.0.1]) by localhost (smtp2.supelec.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2aMylTcGP6Ux; Tue, 1 Aug 2017 22:52:50 +0200 (CEST) Original-Received: from mail-qt0-f180.google.com (mail-qt0-f180.google.com [209.85.216.180]) by smtp2.supelec.fr (Postfix) with ESMTPSA id C552C803FB; Tue, 1 Aug 2017 22:52:49 +0200 (CEST) Original-Received: by mail-qt0-f180.google.com with SMTP id 16so16412335qtz.4; Tue, 01 Aug 2017 13:52:49 -0700 (PDT) X-Gm-Message-State: AIVw110hWvPgpqEn0ZW66Vn4iimtR3mal8tU8MA2CphgUW5R3LAuwOtG FKJGuffUvZNLx09A43GYWuS85mXgFQ== X-Received: by 10.200.14.72 with SMTP id j8mr19439281qti.124.1501620769021; Tue, 01 Aug 2017 13:52:49 -0700 (PDT) Original-Received: by 10.140.82.21 with HTTP; Tue, 1 Aug 2017 13:52:28 -0700 (PDT) In-Reply-To: <83zibjz519.fsf@gnu.org> X-Gmail-Original-Message-ID: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 160.228.120.31 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217223 Archived-At: --089e08225dac8666780555b754da Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I don't get a failure on dired-test-bug25609 with windows 10 and running from a mingw64 bash. I get a failure on dired-test-bug27631 because "/bin/sh" is hardcoded in lisp/dired.el and the place for sh.exe in msys2 is in /usr/bin . I think that the various options for dired ls tests should be split in different test files (em-ls for example). Fabrice 2017-08-01 17:22 GMT+02:00 Eli Zaretskii : > The failed tests are shown below. 2 others failed originally, but I > fixed them. > > Tino, please always add comments to the tests explaining the idea > behind all the tricks and juggling. Otherwise, it is very hard to > understand why the test is doing what it's doing and how it is doing > that. Same request for ediff-ptch-tests.el, which also fails for me. > > Than ks. > > dired-tests.log: > > Running 12 tests (2017-08-01 17:44:38+0300) > passed 1/12 dired-autoload > Marking matching files... > Checking d:/gnu/git/emacs/trunk/test/bug22694/test > 1 matching file marked. > passed 2/12 dired-test-bug22694 > Copy: 1 of 1 > Copy: 1 file > Copy: 1 of 1 > Copy: 1 file > Test dired-test-bug25609 backtrace: > signal(ert-test-failed (((should (file-exists-p target)) :form (file > ert-fail(((should (file-exists-p target)) :form (file-exists-p "c:/D > (if (unwind-protect (setq value-17 (apply fn-15 args-16)) (setq form > (let (form-description-19) (if (unwind-protect (setq value-17 (apply > (let ((value-17 'ert-form-evaluation-aborted-18)) (let (form-descrip > (let ((fn-15 (function file-exists-p)) (args-16 (list target))) (let > (progn (let ((fn-15 (function file-exists-p)) (args-16 (list target) > (unwind-protect (progn (let ((fn-15 (function file-exists-p)) (args- > (let* ((from (make-temp-file "foo" 'dir)) (to (make-temp-file "bar" > (closure (t) nil (let* ((from (make-temp-file "foo" 'dir)) (to (make > ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test > ert-run-test(#s(ert-test :name dired-test-bug25609 :documentation "T > ert-run-or-rerun-test(#s(ert--stats :selector t :tests [#s(ert-test > ert-run-tests(t #f(compiled-function (event-type &rest event-args) # > ert-run-tests-batch(nil) > ert-run-tests-batch-and-exit(nil) > eval((ert-run-tests-batch-and-exit nil)) > command-line-1(("-L" ";." "-l" "ert" "-l" "lisp/dired-tests.el" "--e > command-line() > normal-top-level() > Test dired-test-bug25609 condition: > (ert-test-failed > ((should > (file-exists-p target)) > :form > (file-exists-p "c:/DOCUME~1/Zaretzky/LOCALS~ > 1/Temp/bar6828Ler/foo6828WPJ") > :value nil)) > FAILED 3/12 dired-test-bug25609 > passed 4/12 dired-test-bug27243-01 > passed 5/12 dired-test-bug27243-02 > passed 6/12 dired-test-bug27243-03 > Test dired-test-bug27631 backtrace: > signal(error ("em-ls is not a currently loaded feature")) > error("%s is not a currently loaded feature" "em-ls") > unload-feature(em-ls force) > (unwind-protect (progn (make-directory dir1) (make-directory dir2) ( > (let* ((dir (make-temp-file "bug27631" 'dir)) (dir1 (expand-file-nam > (closure (t) nil (let* ((dir (make-temp-file "bug27631" 'dir)) (dir1 > ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test > ert-run-test(#s(ert-test :name dired-test-bug27631 :documentation "T > ert-run-or-rerun-test(#s(ert--stats :selector t :tests [#s(ert-test > ert-run-tests(t #f(compiled-function (event-type &rest event-args) # > ert-run-tests-batch(nil) > ert-run-tests-batch-and-exit(nil) > eval((ert-run-tests-batch-and-exit nil)) > command-line-1(("-L" ";." "-l" "ert" "-l" "lisp/dired-tests.el" "--e > command-line() > normal-top-level() > Test dired-test-bug27631 condition: > (error "em-ls is not a currently loaded feature") > FAILED 7/12 dired-test-bug27631 > passed 8/12 dired-test-bug27693 > failed 9/12 dired-test-bug27762 > passed 10/12 dired-test-bug27817 > passed 11/12 dired-test-bug27843 > passed 12/12 dired-test-bug7131 > > Ran 12 tests, 10 results as expected, 2 unexpected (2017-08-01 > 17:44:46+0300) > 1 expected failures > > 2 unexpected results: > FAILED dired-test-bug25609 > FAILED dired-test-bug27631 > > ediff-ptch-tests.log: > > Running 2 tests (2017-08-01 18:21:40+0300) > passed 1/2 ediff-ptch-test-bug25010 > Test ediff-ptch-test-bug26084 backtrace: > Test ediff-ptch-test-bug26084 condition: > (wrong-type-argument stringp nil) > FAILED 2/2 ediff-ptch-test-bug26084 > > Ran 2 tests, 1 results as expected, 1 unexpected (2017-08-01 > 18:21:40+0300) > > 1 unexpected results: > FAILED ediff-ptch-test-bug26084 > > > --=20 Fabrice Popineau ----------------------------- CentraleSupelec D=C3=A9partement Informatique 3, rue Joliot Curie 91192 Gif/Yvette Cedex Tel direct : +33 (0) 169851950 Standard : +33 (0) 169851212 ------------------------------ --089e08225dac8666780555b754da Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I don't get a failure on=C2=A0dired-test-bug25609 with windows 10 and running from a mingw64 bas= h.

I get a failure on=C2=A0=C2=A0dired-test-bu= g27631 because "/bin/sh" is hardcoded in lisp/dired.el and the
place for sh.exe in msys2 is in /usr/bin .
<= span style=3D"font-size:12.8px">
I think that the various options for dired ls tests should be s= plit in different test files (em-ls for example).
=C2=A0
Fabrice


2017-08-0= 1 17:22 GMT+02:00 Eli Zaretskii <eliz@gnu.org>:
The failed tests are shown below.=C2=A0 2 others failed or= iginally, but I
fixed them.

Tino, please always add comments to the tests explaining the idea
behind all the tricks and juggling.=C2=A0 Otherwise, it is very hard to
understand why the test is doing what it's doing and how it is doing that.=C2=A0 Same request for ediff-ptch-tests.el, which also fails for me.<= br>
Than ks.

dired-tests.log:

=C2=A0 Running 12 tests (2017-08-01 17:44:38+0300)
=C2=A0 =C2=A0 =C2=A0passed=C2=A0 =C2=A01/12=C2=A0 dired-autoload
=C2=A0 Marking matching files...
=C2=A0 Checking d:/gnu/git/emacs/trunk/test/bug22694/test
=C2=A0 1 matching file marked.
=C2=A0 =C2=A0 =C2=A0passed=C2=A0 =C2=A02/12=C2=A0 dired-test-bug22694
=C2=A0 Copy: 1 of 1
=C2=A0 Copy: 1 file
=C2=A0 Copy: 1 of 1
=C2=A0 Copy: 1 file
=C2=A0 Test dired-test-bug25609 backtrace:
=C2=A0 =C2=A0 signal(ert-test-failed (((should (file-exists-p target)) :for= m (file
=C2=A0 =C2=A0 ert-fail(((should (file-exists-p target)) :form (file-exists-= p "c:/D
=C2=A0 =C2=A0 (if (unwind-protect (setq value-17 (apply fn-15 args-16)) (se= tq form
=C2=A0 =C2=A0 (let (form-description-19) (if (unwind-protect (setq value-17= (apply
=C2=A0 =C2=A0 (let ((value-17 'ert-form-evaluation-aborted-18)) (l= et (form-descrip
=C2=A0 =C2=A0 (let ((fn-15 (function file-exists-p)) (args-16 (list target)= )) (let
=C2=A0 =C2=A0 (progn (let ((fn-15 (function file-exists-p)) (args-16 (list = target)
=C2=A0 =C2=A0 (unwind-protect (progn (let ((fn-15 (function file-exists-p))= (args-
=C2=A0 =C2=A0 (let* ((from (make-temp-file "foo" 'dir)) (to (= make-temp-file "bar"
=C2=A0 =C2=A0 (closure (t) nil (let* ((from (make-temp-file "foo"= 'dir)) (to (make
=C2=A0 =C2=A0 ert--run-test-internal(#s(ert--test-execution-info :test= #s(ert-test
=C2=A0 =C2=A0 ert-run-test(#s(ert-test :name dired-test-bug25609 :documenta= tion "T
=C2=A0 =C2=A0 ert-run-or-rerun-test(#s(ert--stats :selector t :tests [= #s(ert-test
=C2=A0 =C2=A0 ert-run-tests(t #f(compiled-function (event-type &rest ev= ent-args) #
=C2=A0 =C2=A0 ert-run-tests-batch(nil)
=C2=A0 =C2=A0 ert-run-tests-batch-and-exit(nil)
=C2=A0 =C2=A0 eval((ert-run-tests-batch-and-exit nil))
=C2=A0 =C2=A0 command-line-1(("-L" ";." "-l" = "ert" "-l" "lisp/dired-tests.el" "--e =C2=A0 =C2=A0 command-line()
=C2=A0 =C2=A0 normal-top-level()
=C2=A0 Test dired-test-bug25609 condition:
=C2=A0 =C2=A0 =C2=A0 (ert-test-failed
=C2=A0 =C2=A0 =C2=A0 =C2=A0((should
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(file-exists-p target))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 :form
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (file-exists-p "c:/DOCUME~1/Zaretzky/LOCAL= S~1/Temp/bar6828Ler/foo6828WPJ")
=C2=A0 =C2=A0 =C2=A0 =C2=A0 :value nil))
=C2=A0 =C2=A0 =C2=A0FAILED=C2=A0 =C2=A03/12=C2=A0 dired-test-bug25609
=C2=A0 =C2=A0 =C2=A0passed=C2=A0 =C2=A04/12=C2=A0 dired-test-bug27243-01 =C2=A0 =C2=A0 =C2=A0passed=C2=A0 =C2=A05/12=C2=A0 dired-test-bug27243-02 =C2=A0 =C2=A0 =C2=A0passed=C2=A0 =C2=A06/12=C2=A0 dired-test-bug27243-03 =C2=A0 Test dired-test-bug27631 backtrace:
=C2=A0 =C2=A0 signal(error ("em-ls is not a currently loaded feature&q= uot;))
=C2=A0 =C2=A0 error("%s is not a currently loaded feature" "= em-ls")
=C2=A0 =C2=A0 unload-feature(em-ls force)
=C2=A0 =C2=A0 (unwind-protect (progn (make-directory dir1) (make-directory = dir2) (
=C2=A0 =C2=A0 (let* ((dir (make-temp-file "bug27631" 'dir)) (= dir1 (expand-file-nam
=C2=A0 =C2=A0 (closure (t) nil (let* ((dir (make-temp-file "bug27631&q= uot; 'dir)) (dir1
=C2=A0 =C2=A0 ert--run-test-internal(#s(ert--test-execution-info :test= #s(ert-test
=C2=A0 =C2=A0 ert-run-test(#s(ert-test :name dired-test-bug27631 :documenta= tion "T
=C2=A0 =C2=A0 ert-run-or-rerun-test(#s(ert--stats :selector t :tests [= #s(ert-test
=C2=A0 =C2=A0 ert-run-tests(t #f(compiled-function (event-type &rest ev= ent-args) #
=C2=A0 =C2=A0 ert-run-tests-batch(nil)
=C2=A0 =C2=A0 ert-run-tests-batch-and-exit(nil)
=C2=A0 =C2=A0 eval((ert-run-tests-batch-and-exit nil))
=C2=A0 =C2=A0 command-line-1(("-L" ";." "-l" = "ert" "-l" "lisp/dired-tests.el" "--e =C2=A0 =C2=A0 command-line()
=C2=A0 =C2=A0 normal-top-level()
=C2=A0 Test dired-test-bug27631 condition:
=C2=A0 =C2=A0 =C2=A0 (error "em-ls is not a currently loaded feature&q= uot;)
=C2=A0 =C2=A0 =C2=A0FAILED=C2=A0 =C2=A07/12=C2=A0 dired-test-bug27631
=C2=A0 =C2=A0 =C2=A0passed=C2=A0 =C2=A08/12=C2=A0 dired-test-bug27693
=C2=A0 =C2=A0 =C2=A0failed=C2=A0 =C2=A09/12=C2=A0 dired-test-bug27762
=C2=A0 =C2=A0 =C2=A0passed=C2=A0 10/12=C2=A0 dired-test-bug27817
=C2=A0 =C2=A0 =C2=A0passed=C2=A0 11/12=C2=A0 dired-test-bug27843
=C2=A0 =C2=A0 =C2=A0passed=C2=A0 12/12=C2=A0 dired-test-bug7131

=C2=A0 Ran 12 tests, 10 results as expected, 2 unexpected (2017-08-01 17:44= :46+0300)
=C2=A0 1 expected failures

=C2=A0 2 unexpected results:
=C2=A0 =C2=A0 =C2=A0FAILED=C2=A0 dired-test-bug25609
=C2=A0 =C2=A0 =C2=A0FAILED=C2=A0 dired-test-bug27631

ediff-ptch-tests.log:

=C2=A0 Running 2 tests (2017-08-01 18:21:40+0300)
=C2=A0 =C2=A0 =C2=A0passed=C2=A0 1/2=C2=A0 ediff-ptch-test-bug25010
=C2=A0 Test ediff-ptch-test-bug26084 backtrace:
=C2=A0 Test ediff-ptch-test-bug26084 condition:
=C2=A0 =C2=A0 =C2=A0 (wrong-type-argument stringp nil)
=C2=A0 =C2=A0 =C2=A0FAILED=C2=A0 2/2=C2=A0 ediff-ptch-test-bug26084

=C2=A0 Ran 2 tests, 1 results as expected, 1 unexpected (2017-08-01 18:21:4= 0+0300)

=C2=A0 1 unexpected results:
=C2=A0 =C2=A0 =C2=A0FAILED=C2=A0 ediff-ptch-test-bug26084





--
Fabrice Popineau
-----------------------------
CentraleSupelec
D=C3=A9partement Informatique
3, rue Joliot Curie
91192 Gif/Yvette Cedex
Tel direct : +33 (0) 169851950
Standard : +33 (0) 169851212
------------------------------
=
--089e08225dac8666780555b754da--