From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Fabrice Popineau Newsgroups: gmane.emacs.bugs Subject: bug#22534: File notify broken on Windows Date: Sun, 7 Feb 2016 14:37:34 +0100 Message-ID: References: <83h9hrytom.fsf@gnu.org> <87lh72xln0.fsf@gmx.de> <838u30wbx5.fsf@gnu.org> <83fux7v56c.fsf@gnu.org> <871t8rm5x8.fsf@gmx.de> <83si17t02p.fsf@gnu.org> <83wpqhsrv3.fsf@gnu.org> <874mdllk0f.fsf@gmx.de> <83r3gpsjey.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=089e0149d02003007d052b2e312f X-Trace: ger.gmane.org 1454852369 10040 80.91.229.3 (7 Feb 2016 13:39:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 7 Feb 2016 13:39:29 +0000 (UTC) Cc: 22534@debbugs.gnu.org, Michael Albinus To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Feb 07 14:39:20 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aSPYd-0004rQ-Ro for geb-bug-gnu-emacs@m.gmane.org; Sun, 07 Feb 2016 14:39:20 +0100 Original-Received: from localhost ([::1]:34388 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSPYd-0001fC-5o for geb-bug-gnu-emacs@m.gmane.org; Sun, 07 Feb 2016 08:39:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46874) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSPYV-0001e3-PD for bug-gnu-emacs@gnu.org; Sun, 07 Feb 2016 08:39:16 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSPYM-0002k4-1n for bug-gnu-emacs@gnu.org; Sun, 07 Feb 2016 08:39:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56180) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSPYL-0002k0-Uj for bug-gnu-emacs@gnu.org; Sun, 07 Feb 2016 08:39:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aSPYL-00034s-NK for bug-gnu-emacs@gnu.org; Sun, 07 Feb 2016 08:39:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Fabrice Popineau Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Feb 2016 13:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22534-submit@debbugs.gnu.org id=B22534.145485228311754 (code B ref 22534); Sun, 07 Feb 2016 13:39:01 +0000 Original-Received: (at 22534) by debbugs.gnu.org; 7 Feb 2016 13:38:03 +0000 Original-Received: from localhost ([127.0.0.1]:36536 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSPXO-00033W-Jg for submit@debbugs.gnu.org; Sun, 07 Feb 2016 08:38:03 -0500 Original-Received: from mail-ob0-f180.google.com ([209.85.214.180]:36572) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aSPXM-00032w-VP for 22534@debbugs.gnu.org; Sun, 07 Feb 2016 08:38:01 -0500 Original-Received: by mail-ob0-f180.google.com with SMTP id ba1so125607611obb.3 for <22534@debbugs.gnu.org>; Sun, 07 Feb 2016 05:38:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=6H903yj5h+d9kFCVvK2NnR0ciL/iWEdE8DUtxv+S3mQ=; b=an2pBAWBfqOD6KacPH/S4wWl61Ycti/SNYVGw41t5wOJRLTbf+r74R4oFQ9V3TZ1Th eou0MHst0l6FoPQhIaWvommul8Ui8a5fJx80hp867rOMEJNUZM2i+o9GB9TgiwJUx+a6 +e0eUDbobmDfR6cooP3wW2a/Lyo4AVgfkywixvz5zDPuuQiySFZ5nYRlA7IlTBstjGXF gBcXDBEhd+qQZu4ZA2yWDEKrhzzESfU2LYgZb+302OEvIC6jKMUgM136wZGvtuvloDjV rjpFdhkbxN0FF/CLZKYuTnCELTojlgrX9TA+nXbuzRwnS9143gA2RzaL2VfTEX5ou1fg +hbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=6H903yj5h+d9kFCVvK2NnR0ciL/iWEdE8DUtxv+S3mQ=; b=e7K2WbSu/0ZowXsfkNxybjFtEvtgbKb6x0qpZSvwIDsoyyjNb0MGaZGF+IzZAkoEBt aJJDUolQTfR4TYEh4mTme52aajQAnjnObhKQUOgnIUCUIDWKhuYEXSEtER4E1TF7bimi 8KFXATbGAtrfStUyauTw6ZYJgUlNIfZvEICVHFjrM2kn+xXVZJXlBdbTPkhPHC3WO9dI 5npgV4OjlQgYCE00tv0tOj8xQy1shiMRGPu8ZK6l8wPHSDrn23Tas6jH7IJ06dvHGvc9 B5uQ7wlJEYw38vuO1a7ce38+eGsqPZ4usaIk58u0xWrznnbzPYfANkCP53fJdCkfRKaE 8oUA== X-Gm-Message-State: AG10YOR68aMgmy2M6p6DxfaXU78r3BZVSxftnbn161LYEpzVYKZtBgr7sq8nuYuEUVAg1MNCzwfVc0dAy4bMig== X-Received: by 10.182.86.98 with SMTP id o2mr4248342obz.27.1454852274321; Sun, 07 Feb 2016 05:37:54 -0800 (PST) Original-Received: by 10.202.78.75 with HTTP; Sun, 7 Feb 2016 05:37:34 -0800 (PST) In-Reply-To: <83r3gpsjey.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:112622 Archived-At: --089e0149d02003007d052b2e312f Content-Type: text/plain; charset=UTF-8 The situation has improved especially with file-notify-test06-many-events, but I still see problems in batch mode. The remaining problems are in file-notify-test02-events. In the 'check for attribute change', I see only 2 'changed' notifications, and not 4 as expected by the test (around line 512: w32notify does not distinguish between 'changed' and 'attribute-changed'). So I need to apply : diff --git a/test/automated/file-notify-tests.el b/test/automated/file-notify-tests.el index 5fc4ff8..943bd7e 100644 --- a/test/automated/file-notify-tests.el +++ b/test/automated/file-notify-tests.el @@ -507,7 +512,7 @@ file-notify--test-with-events ;; w32notify does not distinguish between `changed' and ;; `attribute-changed'. ((string-equal (file-notify--test-library) "w32notify") - '(changed changed changed changed)) + '(changed changed)) ;; For kqueue and in the remote case, `write-region' ;; raises also an `attribute-changed' event. ((or (string-equal (file-notify--test-library) "kqueue") For the rest of this test, whereas the test passes in interactive mode, it fails in batch mode with several 'deleted' notifications. Namely, I need to apply the following for the test to pass. diff --git a/test/automated/file-notify-tests.el b/test/automated/file-notify-tests.el index 5fc4ff8..943bd7e 100644 --- a/test/automated/file-notify-tests.el +++ b/test/automated/file-notify-tests.el @@ -396,7 +397,8 @@ file-notify--test-with-events ;; w32notify does raise a `stopped' event when a ;; watched directory is deleted. ((string-equal (file-notify--test-library) "w32notify") - '(created changed deleted)) + '(created changed ; deleted + )) ;; cygwin recognizes only `deleted' and `stopped' events. ((eq system-type 'cygwin) '(deleted stopped)) @@ -430,7 +432,8 @@ file-notify--test-with-events ;; `attribute-changed'. ((string-equal (file-notify--test-library) "w32notify") '(created changed created changed changed changed changed - deleted deleted)) + ;; deleted deleted + )) ;; cygwin recognizes only `deleted' and `stopped' events. ((eq system-type 'cygwin) '(deleted stopped)) @@ -479,6 +482,8 @@ file-notify--test-with-events ;; the directory. Except for kqueue. ((string-equal (file-notify--test-library) "kqueue") '(created changed renamed deleted stopped)) + ((string-equal (file-notify--test-library) "w32notify") + '(created changed renamed)) (t '(created changed renamed deleted deleted stopped))) (read-event nil nil 0.1) (write-region Fabrice 2016-02-06 20:55 GMT+01:00 Eli Zaretskii : > > From: Michael Albinus > > Cc: 22534@debbugs.gnu.org, fabrice.popineau@gmail.com > > Date: Sat, 06 Feb 2016 20:24:32 +0100 > > > > Please install the patch > > Done. > --089e0149d02003007d052b2e312f Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
The situation has improved especially with=C2=A0file-notif= y-test06-many-events, but I still see problems in batch mode.
The remai= ning problems are in file-notify-test02-events.

In= the 'check for attribute change', I see only 2 'changed' n= otifications, and not 4
as expected by the test (around line 512:= w32notify does not distinguish between=C2=A0
'changed' a= nd 'attribute-changed').

So I need to appl= y :

diff --git a/test/automated/file-notify-t= ests.el b/test/automated/file-notify-tests.el
index 5fc4ff8..943b= d7e 100644
--- a/test/automated/file-notify-tests.el
++= + b/test/automated/file-notify-tests.el
@@ -507,7 +512,7 @@ file-= notify--test-with-events
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 ;; w32notify does not distinguish between `changed'= ; and
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; = `attribute-changed'.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 ((string-equal (file-notify--test-library) "w32notif= y")
- =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 '= (changed changed changed changed))
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 '(changed changed))
=C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; For kqueue and in the remote case, `= write-region'
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 ;; raises also an `attribute-changed' event.
=C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ((or (string-equal (fi= le-notify--test-library) "kqueue")

For the rest of this test, whereas the test passes in interactive mode, it= fails in batch mode with
several 'deleted' notifications= . Namely, I need to apply the following for the test to pass.
diff --git a/test/automated/file-notify-tests.el b/test/automat= ed/file-notify-tests.el
index 5fc4ff8..943bd7e 100644
-= -- a/test/automated/file-notify-tests.el
+++ b/test/automated/fil= e-notify-tests.el
@@ -396,7 +397,8 @@ file-notify--test-with-even= ts
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ;;= w32notify does raise a `stopped' event when a
=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; watched directory is deleted.<= /div>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ((string-= equal (file-notify--test-library) "w32notify")
- =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 '(created changed deleted))<= /div>
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 '(created = changed ; deleted
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0))
=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; cygwin recognizes only `deleted&#= 39; and `stopped' events.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 ((eq system-type 'cygwin)
=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 '(deleted stopped))
@@ -430,7 +432,8 @@ file-notify--test-with-events
=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; `attribute-changed'.
=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ((string-equal= (file-notify--test-library) "w32notify")
=C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 '(created changed created ch= anged changed changed changed
- =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 deleted deleted))
+ =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0;; de= leted deleted
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0))
=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; cygwin recognizes only `deleted' = and `stopped' events.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 ((eq system-type 'cygwin)
=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 '(deleted stopped))
@@= -479,6 +482,8 @@ file-notify--test-with-events
=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ;; the directory.=C2=A0 Except for k= queue.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ((= string-equal (file-notify--test-library) "kqueue")
=C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 '(created changed = renamed deleted stopped))
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 ((string-equal (file-notify--test-library) "w32notify&qu= ot;)
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 '(cre= ated changed renamed))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 (t '(created changed renamed deleted deleted stopped)))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(read-event nil ni= l 0.1)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(write-reg= ion
=C2=A0

Fabrice

2016-02-06 20:55 GMT+01= :00 Eli Zaretskii <eliz@gnu.org>:
> From: Michael Albinus <michael.albinus@gmx.de>
> Cc: 22534@debbugs.gnu.org= ,=C2=A0 fabrice.popineau@gmai= l.com
> Date: Sat, 06 Feb 2016 20:24:32 +0100
>
> Please install the patch

Done.

--089e0149d02003007d052b2e312f--