From: Fabrice Popineau <fabrice.popineau@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 22534@debbugs.gnu.org, Michael Albinus <michael.albinus@gmx.de>
Subject: bug#22534: File notify broken on Windows
Date: Sun, 7 Feb 2016 14:37:34 +0100 [thread overview]
Message-ID: <CAFgFV9PUs8zX=BNAzbviOpo3kOHEh4mfru0NoOTHD=FceMByfw@mail.gmail.com> (raw)
In-Reply-To: <83r3gpsjey.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 3278 bytes --]
The situation has improved especially with file-notify-test06-many-events,
but I still see problems in batch mode.
The remaining problems are in file-notify-test02-events.
In the 'check for attribute change', I see only 2 'changed' notifications,
and not 4
as expected by the test (around line 512: w32notify does not distinguish
between
'changed' and 'attribute-changed').
So I need to apply :
diff --git a/test/automated/file-notify-tests.el
b/test/automated/file-notify-tests.el
index 5fc4ff8..943bd7e 100644
--- a/test/automated/file-notify-tests.el
+++ b/test/automated/file-notify-tests.el
@@ -507,7 +512,7 @@ file-notify--test-with-events
;; w32notify does not distinguish between `changed' and
;; `attribute-changed'.
((string-equal (file-notify--test-library) "w32notify")
- '(changed changed changed changed))
+ '(changed changed))
;; For kqueue and in the remote case, `write-region'
;; raises also an `attribute-changed' event.
((or (string-equal (file-notify--test-library) "kqueue")
For the rest of this test, whereas the test passes in interactive mode, it
fails in batch mode with
several 'deleted' notifications. Namely, I need to apply the following for
the test to pass.
diff --git a/test/automated/file-notify-tests.el
b/test/automated/file-notify-tests.el
index 5fc4ff8..943bd7e 100644
--- a/test/automated/file-notify-tests.el
+++ b/test/automated/file-notify-tests.el
@@ -396,7 +397,8 @@ file-notify--test-with-events
;; w32notify does raise a `stopped' event when a
;; watched directory is deleted.
((string-equal (file-notify--test-library) "w32notify")
- '(created changed deleted))
+ '(created changed ; deleted
+ ))
;; cygwin recognizes only `deleted' and `stopped' events.
((eq system-type 'cygwin)
'(deleted stopped))
@@ -430,7 +432,8 @@ file-notify--test-with-events
;; `attribute-changed'.
((string-equal (file-notify--test-library) "w32notify")
'(created changed created changed changed changed changed
- deleted deleted))
+ ;; deleted deleted
+ ))
;; cygwin recognizes only `deleted' and `stopped' events.
((eq system-type 'cygwin)
'(deleted stopped))
@@ -479,6 +482,8 @@ file-notify--test-with-events
;; the directory. Except for kqueue.
((string-equal (file-notify--test-library) "kqueue")
'(created changed renamed deleted stopped))
+ ((string-equal (file-notify--test-library) "w32notify")
+ '(created changed renamed))
(t '(created changed renamed deleted deleted stopped)))
(read-event nil nil 0.1)
(write-region
Fabrice
2016-02-06 20:55 GMT+01:00 Eli Zaretskii <eliz@gnu.org>:
> > From: Michael Albinus <michael.albinus@gmx.de>
> > Cc: 22534@debbugs.gnu.org, fabrice.popineau@gmail.com
> > Date: Sat, 06 Feb 2016 20:24:32 +0100
> >
> > Please install the patch
>
> Done.
>
[-- Attachment #2: Type: text/html, Size: 4872 bytes --]
next prev parent reply other threads:[~2016-02-07 13:37 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 6:23 bug#22534: File notify broken on Windows Fabrice Popineau
2016-02-02 16:15 ` Eli Zaretskii
2016-02-02 23:36 ` Fabrice Popineau
2016-02-03 8:07 ` Michael Albinus
2016-02-03 12:15 ` Fabrice Popineau
2016-02-04 9:49 ` Fabrice Popineau
2016-02-04 18:47 ` Eli Zaretskii
2016-02-05 5:59 ` Fabrice Popineau
2016-02-05 10:10 ` Eli Zaretskii
2016-02-05 15:34 ` Fabrice Popineau
2016-02-05 17:18 ` Michael Albinus
2016-02-05 19:43 ` Eli Zaretskii
2016-02-05 21:58 ` Michael Albinus
2016-02-06 16:53 ` Eli Zaretskii
2016-02-06 19:24 ` Michael Albinus
2016-02-06 19:55 ` Eli Zaretskii
2016-02-07 13:37 ` Fabrice Popineau [this message]
2016-02-07 17:46 ` Eli Zaretskii
2016-02-07 18:37 ` Michael Albinus
2016-02-07 19:34 ` Fabrice Popineau
2016-02-08 10:27 ` Michael Albinus
2016-02-08 10:43 ` Fabrice Popineau
2016-02-08 18:09 ` Eli Zaretskii
2016-02-08 19:14 ` Michael Albinus
2016-02-08 19:36 ` Eli Zaretskii
2016-02-08 20:00 ` Michael Albinus
2016-02-08 20:18 ` Eli Zaretskii
2016-02-08 20:51 ` Michael Albinus
2016-02-08 21:03 ` Eli Zaretskii
2016-02-08 21:13 ` Michael Albinus
2016-02-09 3:35 ` Eli Zaretskii
2016-02-09 8:13 ` Michael Albinus
2016-02-09 10:08 ` Michael Albinus
2016-02-09 17:09 ` Eli Zaretskii
2016-02-09 18:47 ` Michael Albinus
2016-02-10 11:25 ` Michael Albinus
2016-02-08 19:15 ` Fabrice Popineau
2016-02-10 19:15 ` Eli Zaretskii
2016-02-11 15:19 ` Fabrice Popineau
2016-02-12 8:38 ` Eli Zaretskii
2016-02-15 15:31 ` Michael Albinus
2016-02-15 15:59 ` Eli Zaretskii
2016-02-15 17:52 ` Michael Albinus
2016-02-15 19:46 ` Fabrice Popineau
2016-02-08 10:21 ` Michael Albinus
2016-02-08 10:40 ` Fabrice Popineau
2016-02-08 14:33 ` Fabrice Popineau
2016-02-05 19:31 ` Eli Zaretskii
2016-02-05 17:23 ` Michael Albinus
[not found] ` <CAFgFV9P2D6-dcuHnZ2VQ6F2sW85Aj3AZWL85RJxai-LyuE87xw@mail.gmail.com>
[not found] ` <CAFgFV9MghLviOcmwmDmasZNmkDjZfoBSuwFOoSHXQNtxxkg9mA@mail.gmail.com>
[not found] ` <83egcbun0o.fsf@gnu.org>
[not found] ` <CAFgFV9Og72xHW5O9JE8og=7NrTgeMvx01bg_HBOYzduH1vjLfQ@mail.gmail.com>
[not found] ` <8360xnukzx.fsf@gnu.org>
[not found] ` <CAFgFV9N-+bZf-bBXFaDNsv3dvFQjJbpggPMJrcZ30M-HSaZDwg@mail.gmail.com>
[not found] ` <83a8mvprbg.fsf@gnu.org>
[not found] ` <CAFgFV9Patgn1GJrDkSeMKsS4cewdQRp4F8VYoftybTQ5TmfPAg@mail.gmail.com>
[not found] ` <83oabbnxvs.fsf@gnu.org>
[not found] ` <CAFgFV9N55HuPkF+mVx6Eh9szUUxhu+BkF-2KJ7nx46-3wsph5Q@mail.gmail.com>
[not found] ` <83io1glmkg.fsf@gnu.org>
[not found] ` <CAFgFV9PxijF1Q3WPo1Ebfqe4cJQVYyiu4bOm41QV4L_OvYZ35w@mail.gmail.com>
[not found] ` <87y4abtwhq.fsf@gmx.de>
[not found] ` <8337sjjsql.fsf@gnu.org>
[not found] ` <CAFgFV9MkwdPHxf_6VqYZdBt8vXwbBUxcOivkCyZWYTvi0H24XQ@mail.gmail.com>
[not found] ` <87ziuc3gay.fsf@gmx.de>
[not found] ` <83twkkwxdi.fsf@gnu.org>
[not found] ` <CAFgFV9MdwHK8OG69Dpw6wPj6FK9Fi5c3vQ_jFZaz1BfgGLBLbw@mail.gmail.com>
[not found] ` <83mvqcwa2v.fsf@gnu.org>
[not found] ` <CAFgFV9NTSw1LKn_CzrKxNmZvRMbqrctSEer_8oaniH+Lti=n6g@mail.gmail.com>
2016-03-08 7:44 ` Michael Albinus
[not found] ` <83r3fil7z3.fsf@gnu.org>
[not found] ` <CAFgFV9Pkmz0E7h4mfCLCcxmt29dbDNfAOOp=mbPKnCpPt1B3LQ@mail.gmail.com>
[not found] ` <83bn6ljbku.fsf@gnu.org>
[not found] ` <CAFgFV9PnLRZ=2-C4S9jSMpmDUxijCUQQnu-YnAv2-ifm+6kZBA@mail.gmail.com>
[not found] ` <83fuvm8wjx.fsf@gnu.org>
2016-03-19 14:51 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFgFV9PUs8zX=BNAzbviOpo3kOHEh4mfru0NoOTHD=FceMByfw@mail.gmail.com' \
--to=fabrice.popineau@gmail.com \
--cc=22534@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.