2016-03-19 16:11 GMT+01:00 Michael Albinus : > Hi Fabrice, > > > diff --git a/test/lisp/filenotify-tests.el > b/test/lisp/filenotify-tests.el > > index d3610f0..3908894 100644 > > --- a/test/lisp/filenotify-tests.el > > +++ b/test/lisp/filenotify-tests.el > > @@ -754,7 +757,9 @@ longer than timeout seconds for the events to be > delivered." > > (should (file-notify-valid-p file-notify--test-desc)) > > ;; After removing the watch, the descriptor must not be valid > > ;; anymore. > > + (read-event nil nil file-notify--test-read-event-timeout) > > (file-notify-rm-watch file-notify--test-desc) > > + (read-event nil nil file-notify--test-read-event-timeout) > > (file-notify--wait-for-events > > (file-notify--test-timeout) > > (not (file-notify-valid-p file-notify--test-desc))) > > @@ -776,7 +781,9 @@ longer than timeout seconds for the events to be > delivered." > > (should (file-notify-valid-p file-notify--test-desc)) > > ;; After deleting the directory, the descriptor must not be > > ;; valid anymore. > > + (read-event nil nil file-notify--test-read-event-timeout) > > (delete-directory file-notify--test-tmpfile t) > > + (read-event nil nil file-notify--test-read-event-timeout) > > (file-notify--wait-for-events > > (file-notify--test-timeout) > > (not (file-notify-valid-p file-notify--test-desc))) > > I'm curious why you need the additional `read-event' calls. The > following `file-notify--wait-for-events' loops until the condition is > satisfied, calling `read-event' every iteration. > > Oh ... sorry, yes, we should revert those read-event calls then. I added them mechanically, overlooking the macro. Fabrice