Re: dired-tests.el fails on MS-Windows

[Fabrice Popineau <fabrice.popineau@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2967 bytes --]

I shall say : it almost passes on my side.

I had to apply the following :

diff --git a/test/lisp/dired-tests.el b/test/lisp/dired-tests.el
index 02dbf263b9..88cdbef6ac 100644
--- a/test/lisp/dired-tests.el
+++ b/test/lisp/dired-tests.el
@@ -282,7 +282,7 @@ dired-dwim-target
           (make-directory dir2)
           (with-temp-file (expand-file-name "a.txt" dir1))
           (with-temp-file (expand-file-name "b.txt" dir2))
-          (setq buf (dired (expand-file-name "dir*/*.txt" dir)))
+          (setq buf (dired (cons dir (file-expand-wildcards
"dir*/*.txt"))))
           (dired-toggle-marks)
           (should (cdr (dired-get-marked-files))))
       (delete-directory dir 'recursive)
diff --git a/test/lisp/eshell/em-ls-tests.el
b/test/lisp/eshell/em-ls-tests.el
index 71a555d1ea..cc0e68c47d 100644
--- a/test/lisp/eshell/em-ls-tests.el
+++ b/test/lisp/eshell/em-ls-tests.el
@@ -42,7 +42,7 @@
           (make-directory dir2)
           (with-temp-file (expand-file-name "a.txt" dir1))
           (with-temp-file (expand-file-name "b.txt" dir2))
-          (setq buf (dired (expand-file-name "dir*/*.txt" dir)))
+          (setq buf (dired (cons dir (file-expand-wildcards
"dir*/*.txt"))))
           (dired-toggle-marks)
           (should (cdr (dired-get-marked-files))))
       (customize-set-variable 'eshell-ls-use-in-dired orig)
diff --git a/test/lisp/ls-lisp-tests.el b/test/lisp/ls-lisp-tests.el
index d24b30e5f2..77a02c88dd 100644
--- a/test/lisp/ls-lisp-tests.el
+++ b/test/lisp/ls-lisp-tests.el
@@ -69,7 +69,7 @@
           (make-directory dir2)
           (with-temp-file (expand-file-name "a.txt" dir1))
           (with-temp-file (expand-file-name "b.txt" dir2))
-          (setq buf (dired (expand-file-name "dir*/*.txt" dir)))
+          (setq buf (dired (cons dir (file-expand-wildcards
"dir*/*.txt"))))
           (dired-toggle-marks)
           (should (cdr (dired-get-marked-files))))
       (delete-directory dir 'recursive)

Am I wrong thinking that `expand-file-name' is not supposed to expand
"dir*/*.txt"?

Fabrice


2017-08-04 15:18 GMT+02:00 Eli Zaretskii <eliz@gnu.org>:

> > From: Tino Calancha <tino.calancha@gmail.com>
> > Date: Wed, 2 Aug 2017 15:44:59 +0900 (JST)
> > cc: Eli Zaretskii <eliz@gnu.org>, Tino Calancha <tino.calancha@gmail.com
> >,
> >     Emacs developers <emacs-devel@gnu.org>
> >
> > > 2017-08-01 21:04 GMT+02:00 Eli Zaretskii <eliz@gnu.org>:
> > >
> > >       Only if there's no better way.  The Patch invocation definitely
> needs
> > >       the --binary switch on Windows, though.  But the failure above
> is not
> > >       about that, it's about something else, because directory-files
> returns
> > >       an empty list.  Something prevents Patch from creating backup
> files.
> > >
> > >
> > > When I add the '--binary' option to patch, the test passes.
> > > Again, windows 10, mingw64.
> > Fabrice, Eli
> > does the following work in your environments?
>
> Yes, it passes now.
>
> Thanks!
>

[-- Attachment #2: Type: text/html, Size: 4455 bytes --]