From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Fabrice Popineau Newsgroups: gmane.emacs.devel Subject: Re: Windows 9X crash Date: Fri, 15 Jan 2016 11:31:09 +0100 Message-ID: References: <568BBC58.50702@aprikoodi.fi> <83y4c43qkh.fsf@gnu.org> <5691667C.5000009@aprikoodi.fi> <838u3wkkvb.fsf@gnu.org> <5694E07E.8010005@aprikoodi.fi> <83fuy2kd2w.fsf@gnu.org> <56961607.2090504@aprikoodi.fi> <569634D6.6030404@aprikoodi.fi> <83oacpiial.fsf@gnu.org> <5697995B.5010306@aprikoodi.fi> <83mvs8gh7n.fsf@gnu.org> <56989810.70301@aprikoodi.fi> <5698A546.8020701@aprikoodi.fi> <831t9jgt8y.fsf@gnu.org> <5698BD58.2090708@aprikoodi.fi> <83oacnf8ne.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a113e42f6f8d2d205295ce7ef X-Trace: ger.gmane.org 1452853898 6312 80.91.229.3 (15 Jan 2016 10:31:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 15 Jan 2016 10:31:38 +0000 (UTC) Cc: Jussi Lahdenniemi , Emacs developers To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 15 11:31:37 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aK1fN-0007Qv-H4 for ged-emacs-devel@m.gmane.org; Fri, 15 Jan 2016 11:31:37 +0100 Original-Received: from localhost ([::1]:46271 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aK1fM-00040N-ML for ged-emacs-devel@m.gmane.org; Fri, 15 Jan 2016 05:31:36 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40862) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aK1fI-00040C-1U for emacs-devel@gnu.org; Fri, 15 Jan 2016 05:31:33 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aK1fH-0006FZ-4V for emacs-devel@gnu.org; Fri, 15 Jan 2016 05:31:31 -0500 Original-Received: from mail-oi0-x229.google.com ([2607:f8b0:4003:c06::229]:34120) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aK1fF-0006FE-LR; Fri, 15 Jan 2016 05:31:29 -0500 Original-Received: by mail-oi0-x229.google.com with SMTP id k206so133682564oia.1; Fri, 15 Jan 2016 02:31:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=GAYBhDOcIX3rx7w+eqEUYs+obBsOKg2zdgHuvmsatWE=; b=aHOTXojrfFKW/KdjazuNjfbL8MRjttyMc6hl74mUGhye8QNQQ/+nZj4j5PjQLcbIgo fkOCg0HrAOtr8uOxCugOOfnnaSVhceabuJiEHTVvup5BxctHvClYXCnz2muIzGDdC6od Aw/SylMZNr97dwZeKtYmq8rUCVy7fFw4Z8XxOoKInrKjnEp0ZG4/UBCpxiusslD946xK vTbVbYejI1Ot+LQJ2C8mFNw4qSodA1UGmG+ZO3KH69Ct2Bjv2QwsmZ4EeQRxUUyWSsC7 zh9AZJ3osbYPJVdIJ0Iu1QWIGSNZpqp5D0GbkZpcH8jP8dA4IIIcbzbxuVJn0zXKv3lv 5afg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=GAYBhDOcIX3rx7w+eqEUYs+obBsOKg2zdgHuvmsatWE=; b=D2wEMDsecozpkF3iJ+uHGr/02i9y7TQZM4GglfcApueEeIjVk86grOR7pdf+YRejH0 G3G59WhXJ/Y2np6grqtV7oBEZ7H8UY3xJAzL11WGlsACllcZofrvxdwsOrSxqz1PGNOu nT6nvZMqV3hbFvFPs5o9WRl7RuwRqxl59oHqqnvXuvgDNstfexLE+fH68LDyCAaQfLxt K6N0hHquVxBXyzGg9T2ldMHigsk+vjMTcuB5hchuumhRznowy6XTOPrZuofluPzq9KpL YqPkEUPq6eimoKEupTnQZ3f6zF/qHaGNrzeKwYpQF9aRon6eeizCglBMe5lQion2bp5K zuyg== X-Gm-Message-State: ALoCoQmwNfQ/yb/cogZYLyqdtJJQ6cue3HwdHR08VRJaSkKV62pCYrkoAUURupH2XUzPIcnihPuonds6/vq1dxlVTCfaXVWtAw== X-Received: by 10.202.197.72 with SMTP id v69mr7378684oif.19.1452853889124; Fri, 15 Jan 2016 02:31:29 -0800 (PST) Original-Received: by 10.202.79.215 with HTTP; Fri, 15 Jan 2016 02:31:09 -0800 (PST) In-Reply-To: <83oacnf8ne.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4003:c06::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:198179 Archived-At: --001a113e42f6f8d2d205295ce7ef Content-Type: text/plain; charset=UTF-8 2016-01-15 11:18 GMT+01:00 Eli Zaretskii : > > Cc: emacs-devel@gnu.org > > From: Jussi Lahdenniemi > > Date: Fri, 15 Jan 2016 11:35:20 +0200 > > > > > A proposal patch is attached. Reallocs needed some additional care, as > > there are two special cases to handle (source being in dumped memory, > > and source and destination alignments mismatching). > > Thanks. Fabrice, any comments to the patch? > > I think the 9X-specific code should be #ifdef'ed away in 64-bit > builds, is that right? The alignment code and the "p - 1" stuff is > wrong for 64-bit code anyway, I think. > I think it would be better, yes. Anyway, a 64 bit build won't run on W98. Fabrice --001a113e42f6f8d2d205295ce7ef Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


2016-01-15 11:18 GMT+01:00 Eli Zaretskii <eliz@gnu.org>:
=
> Cc: emacs-devel@gnu.org
> From: Jussi Lahdenniemi <juss= i@aprikoodi.fi>
> Date: Fri, 15 Jan 2016 11:35:20 +0200
>

> A proposal patch is attached.=C2=A0 Reallocs needed some additional ca= re, as
> there are two special cases to handle (source being in dumped memory,<= br> > and source and destination alignments mismatching).

Thanks.=C2=A0 Fabrice, any comments to the patch?

I think the 9X-specific code should be #ifdef'ed away in 64-bit
builds, is that right?=C2=A0 The alignment code and the "p - 1" s= tuff is
wrong for 64-bit code anyway, I think.

I think it would be= better, yes. Anyway, a 64 bit build won't run on W98.

Fabrice

--001a113e42f6f8d2d205295ce7ef--