From: Akira Komamura <akira.komamura@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 59900@debbugs.gnu.org
Subject: bug#59900: 30.0.50; map pattern in pcase causes a byte-compile error
Date: Thu, 8 Dec 2022 22:11:39 +0900 [thread overview]
Message-ID: <CAFYM7h4EAyzcr2yBMz=f6JTd0agUW8nwpO8Tw8JNTCmNDT3+fQ@mail.gmail.com> (raw)
In-Reply-To: <83ilim2lyz.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1524 bytes --]
> Could you please point out where does pcase.el uses 'map' in its
> source? The error message you quote doesn't reference pcase.el, only
> org-bookmark-heading.el, which is not part of Emacs and is not on
> ELPA, AFAICT.
Apology for the misleading title.
`pcase.el' itself doesn't depend on `map.el', nor does it contain `map'
pattern
in its source. `pcase.el' itself successfully compiles.
I encountered the error while trying to byte-compile
`org-bookmark-heading.el',
which contains a `map' pattern at the following location:
https://github.com/alphapapa/org-bookmark-heading/blob/f245c9023df28d6ee545dae4b96a1c237e6965ba/org-bookmark-heading.el#L176
The error vanishes if I add `(eval-when-compile (require 'map))' as in the
following PR:
https://github.com/alphapapa/org-bookmark-heading/pull/19/files
I encountered similar errors in other libraries that contain a `map' pattern
inside a `pcase' form. It didn't happen until recently, when I updated
Emacs and
began to get those errors.
> So I wonder where's the place in the core Emacs sources
> which causes the problem, and I couldn't find it. I'm probably
> missing something.
There are some other additional patterns for `pcase'. One of them is `rx'
pattern. There is an autoload cookie right above the definition of
`(pcase-defmacro rx ...' in `rx.el'. On the other hand, there is no autoload
above `(pcase-defmacro map ...' in `map.el'. I think this might be the
cause.
Is there any reason for not autoloading the `pcase-defmacro` form?
Thanks.
[-- Attachment #2: Type: text/html, Size: 2338 bytes --]
next prev parent reply other threads:[~2022-12-08 13:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 7:50 bug#59900: 30.0.50; map pattern in pcase causes a byte-compile error Akira Komamura
2022-12-08 11:06 ` Eli Zaretskii
2022-12-08 13:03 ` Visuwesh
2022-12-08 14:20 ` Eli Zaretskii
2022-12-08 14:49 ` Visuwesh
2022-12-08 13:11 ` Akira Komamura [this message]
2022-12-09 2:11 ` Michael Heerdegen
2022-12-09 7:12 ` Eli Zaretskii
2022-12-09 7:58 ` Akira Komamura
2022-12-09 18:02 ` Michael Heerdegen
2022-12-09 19:06 ` Eli Zaretskii
2022-12-09 21:02 ` Michael Heerdegen
2022-12-10 1:01 ` Michael Heerdegen
2022-12-10 7:53 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFYM7h4EAyzcr2yBMz=f6JTd0agUW8nwpO8Tw8JNTCmNDT3+fQ@mail.gmail.com' \
--to=akira.komamura@gmail.com \
--cc=59900@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.